From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Cixi Geng <gengcixi@gmail.com>,
orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, jic23@kernel.org, lars@metafoo.de,
robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, yuming.zhu1@unisoc.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620
Date: Mon, 10 Jan 2022 09:30:38 +0300 [thread overview]
Message-ID: <202201080313.70ZrhufR-lkp@intel.com> (raw)
In-Reply-To: <20220106125947.139523-7-gengcixi@gmail.com>
Hi Cixi,
url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/iio/adc/sc27xx_adc.c:196 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c
87da8dcc76b4aa Cixi Geng 2022-01-06 184 static int adc_nvmem_cell_calib_data(struct sc27xx_adc_data *data, const char *cell_name)
87da8dcc76b4aa Cixi Geng 2022-01-06 185 {
87da8dcc76b4aa Cixi Geng 2022-01-06 186 struct nvmem_cell *cell;
87da8dcc76b4aa Cixi Geng 2022-01-06 187 void *buf;
87da8dcc76b4aa Cixi Geng 2022-01-06 188 u32 calib_data = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 189 size_t len = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 190
87da8dcc76b4aa Cixi Geng 2022-01-06 191 if (!data)
87da8dcc76b4aa Cixi Geng 2022-01-06 192 return -EINVAL;
87da8dcc76b4aa Cixi Geng 2022-01-06 193
87da8dcc76b4aa Cixi Geng 2022-01-06 194 cell = nvmem_cell_get(data->dev, cell_name);
87da8dcc76b4aa Cixi Geng 2022-01-06 195 if (IS_ERR_OR_NULL(cell))
87da8dcc76b4aa Cixi Geng 2022-01-06 @196 return PTR_ERR(cell);
When functions return a both error pointers and NULL, then the NULL
return means that the feature has been deliberately disabled by the
admin.
nvmem_cell_get() cannot be disabled and never returns NULL so this code
should just be:
if (IS_ERR(cell))
return PTR_ERR(cell);
Otherwise we have to create the whole infrastructure to disable it. We
can't just create random sprinklings of dead code to half way support
disabling the feature.
87da8dcc76b4aa Cixi Geng 2022-01-06 197
87da8dcc76b4aa Cixi Geng 2022-01-06 198 buf = nvmem_cell_read(cell, &len);
87da8dcc76b4aa Cixi Geng 2022-01-06 199 if (IS_ERR_OR_NULL(buf)) {
87da8dcc76b4aa Cixi Geng 2022-01-06 200 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 201 return PTR_ERR(buf);
Same.
87da8dcc76b4aa Cixi Geng 2022-01-06 202 }
87da8dcc76b4aa Cixi Geng 2022-01-06 203
87da8dcc76b4aa Cixi Geng 2022-01-06 204 memcpy(&calib_data, buf, min(len, sizeof(u32)));
87da8dcc76b4aa Cixi Geng 2022-01-06 205
87da8dcc76b4aa Cixi Geng 2022-01-06 206 kfree(buf);
87da8dcc76b4aa Cixi Geng 2022-01-06 207 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 208 return calib_data;
87da8dcc76b4aa Cixi Geng 2022-01-06 209 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620
Date: Sat, 08 Jan 2022 03:17:50 +0800 [thread overview]
Message-ID: <202201080313.70ZrhufR-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3811 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220106125947.139523-7-gengcixi@gmail.com>
References: <20220106125947.139523-7-gengcixi@gmail.com>
TO: Cixi Geng <gengcixi@gmail.com>
TO: orsonzhai(a)gmail.com
TO: baolin.wang7(a)gmail.com
TO: zhang.lyra(a)gmail.com
TO: jic23(a)kernel.org
TO: lars(a)metafoo.de
TO: robh+dt(a)kernel.org
TO: lgirdwood(a)gmail.com
TO: broonie(a)kernel.org
CC: yuming.zhu1(a)unisoc.com
CC: linux-iio(a)vger.kernel.org
Hi Cixi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on v5.16-rc8 next-20220106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
:::::: branch date: 30 hours ago
:::::: commit date: 30 hours ago
config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/iio/adc/sc27xx_adc.c:196 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'
Old smatch warnings:
drivers/iio/adc/sc27xx_adc.c:201 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'
drivers/iio/adc/sc27xx_adc.c:706 sc27xx_adc_read() error: uninitialized symbol 'value'.
drivers/iio/adc/sc27xx_adc.c:1123 sc27xx_adc_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c
8ba0dbfd07a358 Baolin Wang 2018-08-29 183
87da8dcc76b4aa Cixi Geng 2022-01-06 184 static int adc_nvmem_cell_calib_data(struct sc27xx_adc_data *data, const char *cell_name)
87da8dcc76b4aa Cixi Geng 2022-01-06 185 {
87da8dcc76b4aa Cixi Geng 2022-01-06 186 struct nvmem_cell *cell;
87da8dcc76b4aa Cixi Geng 2022-01-06 187 void *buf;
87da8dcc76b4aa Cixi Geng 2022-01-06 188 u32 calib_data = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 189 size_t len = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 190
87da8dcc76b4aa Cixi Geng 2022-01-06 191 if (!data)
87da8dcc76b4aa Cixi Geng 2022-01-06 192 return -EINVAL;
87da8dcc76b4aa Cixi Geng 2022-01-06 193
87da8dcc76b4aa Cixi Geng 2022-01-06 194 cell = nvmem_cell_get(data->dev, cell_name);
87da8dcc76b4aa Cixi Geng 2022-01-06 195 if (IS_ERR_OR_NULL(cell))
87da8dcc76b4aa Cixi Geng 2022-01-06 @196 return PTR_ERR(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 197
87da8dcc76b4aa Cixi Geng 2022-01-06 198 buf = nvmem_cell_read(cell, &len);
87da8dcc76b4aa Cixi Geng 2022-01-06 199 if (IS_ERR_OR_NULL(buf)) {
87da8dcc76b4aa Cixi Geng 2022-01-06 200 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 201 return PTR_ERR(buf);
87da8dcc76b4aa Cixi Geng 2022-01-06 202 }
87da8dcc76b4aa Cixi Geng 2022-01-06 203
87da8dcc76b4aa Cixi Geng 2022-01-06 204 memcpy(&calib_data, buf, min(len, sizeof(u32)));
87da8dcc76b4aa Cixi Geng 2022-01-06 205
87da8dcc76b4aa Cixi Geng 2022-01-06 206 kfree(buf);
87da8dcc76b4aa Cixi Geng 2022-01-06 207 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 208 return calib_data;
87da8dcc76b4aa Cixi Geng 2022-01-06 209 }
87da8dcc76b4aa Cixi Geng 2022-01-06 210
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620
Date: Mon, 10 Jan 2022 09:30:38 +0300 [thread overview]
Message-ID: <202201080313.70ZrhufR-lkp@intel.com> (raw)
In-Reply-To: <20220106125947.139523-7-gengcixi@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]
Hi Cixi,
url: https://github.com/0day-ci/linux/commits/Cixi-Geng/iio-adc-sc27xx-adjust-structure-and-add-PMIC-s-support/20220106-210151
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: openrisc-randconfig-m031-20220106 (https://download.01.org/0day-ci/archive/20220108/202201080313.70ZrhufR-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/iio/adc/sc27xx_adc.c:196 adc_nvmem_cell_calib_data() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +196 drivers/iio/adc/sc27xx_adc.c
87da8dcc76b4aa Cixi Geng 2022-01-06 184 static int adc_nvmem_cell_calib_data(struct sc27xx_adc_data *data, const char *cell_name)
87da8dcc76b4aa Cixi Geng 2022-01-06 185 {
87da8dcc76b4aa Cixi Geng 2022-01-06 186 struct nvmem_cell *cell;
87da8dcc76b4aa Cixi Geng 2022-01-06 187 void *buf;
87da8dcc76b4aa Cixi Geng 2022-01-06 188 u32 calib_data = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 189 size_t len = 0;
87da8dcc76b4aa Cixi Geng 2022-01-06 190
87da8dcc76b4aa Cixi Geng 2022-01-06 191 if (!data)
87da8dcc76b4aa Cixi Geng 2022-01-06 192 return -EINVAL;
87da8dcc76b4aa Cixi Geng 2022-01-06 193
87da8dcc76b4aa Cixi Geng 2022-01-06 194 cell = nvmem_cell_get(data->dev, cell_name);
87da8dcc76b4aa Cixi Geng 2022-01-06 195 if (IS_ERR_OR_NULL(cell))
87da8dcc76b4aa Cixi Geng 2022-01-06 @196 return PTR_ERR(cell);
When functions return a both error pointers and NULL, then the NULL
return means that the feature has been deliberately disabled by the
admin.
nvmem_cell_get() cannot be disabled and never returns NULL so this code
should just be:
if (IS_ERR(cell))
return PTR_ERR(cell);
Otherwise we have to create the whole infrastructure to disable it. We
can't just create random sprinklings of dead code to half way support
disabling the feature.
87da8dcc76b4aa Cixi Geng 2022-01-06 197
87da8dcc76b4aa Cixi Geng 2022-01-06 198 buf = nvmem_cell_read(cell, &len);
87da8dcc76b4aa Cixi Geng 2022-01-06 199 if (IS_ERR_OR_NULL(buf)) {
87da8dcc76b4aa Cixi Geng 2022-01-06 200 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 201 return PTR_ERR(buf);
Same.
87da8dcc76b4aa Cixi Geng 2022-01-06 202 }
87da8dcc76b4aa Cixi Geng 2022-01-06 203
87da8dcc76b4aa Cixi Geng 2022-01-06 204 memcpy(&calib_data, buf, min(len, sizeof(u32)));
87da8dcc76b4aa Cixi Geng 2022-01-06 205
87da8dcc76b4aa Cixi Geng 2022-01-06 206 kfree(buf);
87da8dcc76b4aa Cixi Geng 2022-01-06 207 nvmem_cell_put(cell);
87da8dcc76b4aa Cixi Geng 2022-01-06 208 return calib_data;
87da8dcc76b4aa Cixi Geng 2022-01-06 209 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next parent reply other threads:[~2022-01-10 6:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 19:17 kernel test robot [this message]
2022-01-10 6:30 ` [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620 Dan Carpenter
2022-01-10 6:30 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2022-01-07 16:21 [PATCH 4/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 kernel test robot
2022-01-10 5:17 ` Dan Carpenter
2022-01-10 5:17 ` Dan Carpenter
2022-01-06 12:59 [PATCH 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-01-06 12:59 ` [PATCH 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dtbindings Cixi Geng
2022-01-06 17:39 ` Rob Herring
2022-01-06 12:59 ` [PATCH 2/7] iio: adc: sc27xx: fix read big scale voltage not right Cixi Geng
2022-01-07 6:55 ` Baolin Wang
2022-01-09 16:06 ` Jonathan Cameron
2022-01-06 12:59 ` [PATCH 3/7] iio: adc: sc27xx: structure adjuststment and optimization Cixi Geng
2022-01-07 7:04 ` Baolin Wang
2022-01-13 1:53 ` Cixi Geng
2022-01-17 6:16 ` Baolin Wang
2022-01-24 8:06 ` Cixi Geng
2022-02-10 8:08 ` Baolin Wang
2022-02-23 12:46 ` Cixi Geng
2022-02-25 10:19 ` Jonathan Cameron
2022-03-01 6:27 ` Cixi Geng
2022-01-06 12:59 ` [PATCH 4/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-01-07 7:16 ` Baolin Wang
2022-01-09 16:13 ` Jonathan Cameron
2022-01-06 12:59 ` [PATCH 5/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-01-06 12:59 ` [PATCH 6/7] iio: adc: sc27xx: add support for PMIC ump9620 Cixi Geng
2022-01-07 7:23 ` Baolin Wang
2022-01-06 12:59 ` [PATCH 7/7] iio: adc: sc27xx: add Ump9620 ADC suspend and resume pm support Cixi Geng
2022-01-07 7:34 ` Baolin Wang
2022-01-09 16:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201080313.70ZrhufR-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=gengcixi@gmail.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=lkp@intel.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yuming.zhu1@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.