From: David Sterba <dsterba@suse.cz>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ardb@kernel.org>,
Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH RFC v1 0/3] remove remaining users of SHA-1
Date: Wed, 12 Jan 2022 19:50:05 +0100 [thread overview]
Message-ID: <20220112185004.GZ14046@twin.jikos.cz> (raw)
In-Reply-To: <20220112131204.800307-1-Jason@zx2c4.com>
On Wed, Jan 12, 2022 at 02:12:01PM +0100, Jason A. Donenfeld wrote:
> Hi,
>
> There are currently two remaining users of SHA-1 left in the kernel: bpf
> tag generation, and ipv6 address calculation. In an effort to reduce
> code size and rid ourselves of insecure primitives, this RFC patchset
> moves to using the more secure BLAKE2s function.
What's the rationale to use 2s and not 2b? Everywhere I can find the 2s
version is said to be for 8bit up to 32bit machines and it's worse than
2b in benchmarks (reading https://bench.cr.yp.to/results-hash.html).
I'd understand you go with 2s because you also chose it for wireguard
but I'd like know why 2s again even if it's not made for 64bit
architectures that are preferred nowadays.
next prev parent reply other threads:[~2022-01-12 18:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 13:12 [PATCH RFC v1 0/3] remove remaining users of SHA-1 Jason A. Donenfeld
2022-01-12 13:12 ` [PATCH RFC v1 1/3] bpf: move from sha1 to blake2s in tag calculation Jason A. Donenfeld
2022-01-12 22:56 ` Toke Høiland-Jørgensen
2022-01-13 1:33 ` Alexei Starovoitov
2022-01-13 12:27 ` Jason A. Donenfeld
2022-01-13 22:45 ` Alexei Starovoitov
2022-01-14 8:33 ` Geert Uytterhoeven
2022-01-14 14:12 ` Jason A. Donenfeld
2022-01-14 15:08 ` Ard Biesheuvel
2022-01-14 15:20 ` Jason A. Donenfeld
2022-01-14 15:36 ` Geert Uytterhoeven
2022-01-14 15:59 ` David Laight
2022-01-14 16:19 ` Alexei Starovoitov
2022-01-14 16:34 ` Jason A. Donenfeld
2022-01-14 23:04 ` Jeffrey Walton
2022-01-12 13:12 ` [PATCH RFC v1 2/3] ipv6: move from sha1 to blake2s in address calculation Jason A. Donenfeld
2022-01-12 15:49 ` Jason A. Donenfeld
2022-01-12 23:05 ` Toke Høiland-Jørgensen
2022-01-12 23:31 ` Jason A. Donenfeld
2022-01-13 11:15 ` Hannes Frederic Sowa
2022-01-13 12:06 ` Ard Biesheuvel
2022-01-13 12:22 ` Jason A. Donenfeld
2022-01-13 12:29 ` Ard Biesheuvel
2022-01-13 13:30 ` Toke Høiland-Jørgensen
2022-01-13 13:40 ` Ard Biesheuvel
2022-01-13 13:45 ` Jason A. Donenfeld
2022-01-13 13:50 ` Ard Biesheuvel
2022-01-13 13:54 ` Jason A. Donenfeld
2022-01-13 16:18 ` Toke Høiland-Jørgensen
2022-01-14 16:07 ` Jason A. Donenfeld
2022-01-14 16:57 ` Toke Høiland-Jørgensen
2022-01-14 17:41 ` Hannes Frederic Sowa
2022-01-14 17:58 ` Jason A. Donenfeld
2022-01-12 13:12 ` [PATCH RFC v1 3/3] crypto: sha1_generic - import lib/sha1.c locally Jason A. Donenfeld
2022-01-12 18:50 ` David Sterba [this message]
2022-01-12 18:57 ` [PATCH RFC v1 0/3] remove remaining users of SHA-1 Jason A. Donenfeld
2022-01-13 3:24 ` Sandy Harris
2022-01-13 8:08 ` Ard Biesheuvel
2022-01-13 17:28 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112185004.GZ14046@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=jeanphilippe.aumasson@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.