Re: [RFC PATCH v3 2/2] security/inode.c: Add capabilities file.

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v3 2/2] security/inode.c: Add capabilities file.
Date: Fri, 21 Jan 2022 12:01:42 +0800	[thread overview]
Message-ID: <202201211107.0Qa4Y0bI-lkp@intel.com> (raw)
In-Reply-To: <20220120180116.167702-3-flaniel@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]

Hi Francis,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master jmorris-security/next-testing v5.16 next-20220120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Francis-Laniel/Add-capabilities-file-to-sysfs/20220121-020524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1d1df41c5a33359a00e919d54eaebfb789711fdc
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220121/202201211107.0Qa4Y0bI-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/48b37f6e79a73709d7bcf17ea19464073f5da9b6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Francis-Laniel/Add-capabilities-file-to-sysfs/20220121-020524
        git checkout 48b37f6e79a73709d7bcf17ea19464073f5da9b6
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   security/inode.c: In function 'securityfs_init':
>> security/inode.c:362:24: error: implicit declaration of function 'securityfs'; did you mean 'security_bpf'? [-Werror=implicit-function-declaration]
     362 |  capabilities_dentry = securityfs("capabilities", 0444, NULL, NULL,
         |                        ^~~~~~~~~~
         |                        security_bpf
>> security/inode.c:362:22: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     362 |  capabilities_dentry = securityfs("capabilities", 0444, NULL, NULL,
         |                      ^
   cc1: some warnings being treated as errors

vim +362 security/inode.c

   344	
   345	static int __init securityfs_init(void)
   346	{
   347		int retval;
   348	
   349		retval = sysfs_create_mount_point(kernel_kobj, "security");
   350		if (retval)
   351			return retval;
   352	
   353		retval = register_filesystem(&fs_type);
   354		if (retval) {
   355			sysfs_remove_mount_point(kernel_kobj, "security");
   356			return retval;
   357		}
   358	#ifdef CONFIG_SECURITY
   359		lsm_dentry = securityfs_create_file("lsm", 0444, NULL, NULL,
   360							&lsm_ops);
   361	#endif
 > 362		capabilities_dentry = securityfs("capabilities", 0444, NULL, NULL,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org