From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: thomas.hellstrom@linux.intel.com, sumit.semwal@linaro.org, gustavo@padovan.org, daniel.vetter@ffwll.ch, zackr@vmware.com, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 04/11] dma-buf: warn about dma_fence_array container rules v2 Date: Mon, 24 Jan 2022 14:03:21 +0100 [thread overview] Message-ID: <20220124130328.2376-5-christian.koenig@amd.com> (raw) In-Reply-To: <20220124130328.2376-1-christian.koenig@amd.com> It's not allowed to nest another dma_fence container into a dma_fence_array or otherwise we can run into recursion. Warn about that when we create a dma_fence_array. v2: fix comment style and typo in the warning pointed out by Thomas Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/dma-buf/dma-fence-array.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c index 3e07f961e2f3..cb1bacb5a42b 100644 --- a/drivers/dma-buf/dma-fence-array.c +++ b/drivers/dma-buf/dma-fence-array.c @@ -176,6 +176,20 @@ struct dma_fence_array *dma_fence_array_create(int num_fences, array->base.error = PENDING_ERROR; + /* + * dma_fence_array objects should never contain any other fence + * containers or otherwise we run into recursion and potential kernel + * stack overflow on operations on the dma_fence_array. + * + * The correct way of handling this is to flatten out the array by the + * caller instead. + * + * Enforce this here by checking that we don't create a dma_fence_array + * with any container inside. + */ + while (num_fences--) + WARN_ON(dma_fence_is_container(fences[num_fences])); + return array; } EXPORT_SYMBOL(dma_fence_array_create); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: thomas.hellstrom@linux.intel.com, sumit.semwal@linaro.org, gustavo@padovan.org, daniel.vetter@ffwll.ch, zackr@vmware.com, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 04/11] dma-buf: warn about dma_fence_array container rules v2 Date: Mon, 24 Jan 2022 14:03:21 +0100 [thread overview] Message-ID: <20220124130328.2376-5-christian.koenig@amd.com> (raw) In-Reply-To: <20220124130328.2376-1-christian.koenig@amd.com> It's not allowed to nest another dma_fence container into a dma_fence_array or otherwise we can run into recursion. Warn about that when we create a dma_fence_array. v2: fix comment style and typo in the warning pointed out by Thomas Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/dma-buf/dma-fence-array.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c index 3e07f961e2f3..cb1bacb5a42b 100644 --- a/drivers/dma-buf/dma-fence-array.c +++ b/drivers/dma-buf/dma-fence-array.c @@ -176,6 +176,20 @@ struct dma_fence_array *dma_fence_array_create(int num_fences, array->base.error = PENDING_ERROR; + /* + * dma_fence_array objects should never contain any other fence + * containers or otherwise we run into recursion and potential kernel + * stack overflow on operations on the dma_fence_array. + * + * The correct way of handling this is to flatten out the array by the + * caller instead. + * + * Enforce this here by checking that we don't create a dma_fence_array + * with any container inside. + */ + while (num_fences--) + WARN_ON(dma_fence_is_container(fences[num_fences])); + return array; } EXPORT_SYMBOL(dma_fence_array_create); -- 2.25.1
next prev parent reply other threads:[~2022-01-24 13:03 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-24 13:03 Add WARN_ON nested dma_fence containers Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 01/11] drm/radeon: use ttm_resource_manager_debug Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 16:33 ` Thomas Hellström 2022-01-24 16:33 ` [Intel-gfx] " Thomas Hellström 2022-01-24 20:21 ` Christian König 2022-01-24 20:21 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 02/11] drm/amdgpu: " Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 03/11] dma-buf: consolidate dma_fence subclass checking Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` Christian König [this message] 2022-01-24 13:03 ` [Intel-gfx] [PATCH 04/11] dma-buf: warn about dma_fence_array container rules v2 Christian König 2022-01-24 16:32 ` Thomas Hellström 2022-01-24 16:32 ` [Intel-gfx] " Thomas Hellström 2022-01-24 13:03 ` [PATCH 05/11] dma-buf: Warn about dma_fence_chain " Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 06/11] dma-buf: warn about containers in dma_resv object Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 16:36 ` Thomas Hellström (Intel) 2022-01-24 20:22 ` Christian König 2022-01-24 13:03 ` [PATCH 07/11] dma-buf: Add dma_fence_array_for_each (v2) Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 08/11] dma-buf: add dma_fence_chain_contained helper Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 16:52 ` Thomas Hellström 2022-01-24 16:52 ` [Intel-gfx] " Thomas Hellström 2022-01-24 13:03 ` [PATCH 09/11] drm/amdgpu: use dma_fence_chain_contained Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 13:03 ` [PATCH 10/11] drm/i915: use dma_fence extractor functions Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-29 8:31 ` [drm/i915] 9366257fc0: igt.i915_pm_rc6_residency.rc6-idle.fail kernel test robot 2022-01-29 8:31 ` kernel test robot 2022-01-29 8:31 ` kernel test robot 2022-01-29 8:31 ` [Intel-gfx] " kernel test robot 2022-01-24 13:03 ` [PATCH 11/11] drm/vmwgfx: remove vmw_wait_dma_fence Christian König 2022-01-24 13:03 ` [Intel-gfx] " Christian König 2022-01-24 15:25 ` Zack Rusin 2022-01-24 15:25 ` [Intel-gfx] " Zack Rusin 2022-01-24 21:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/radeon: use ttm_resource_manager_debug Patchwork 2022-01-24 21:43 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-01-24 22:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220124130328.2376-5-christian.koenig@amd.com \ --to=ckoenig.leichtzumerken@gmail.com \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gustavo@padovan.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-media@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=thomas.hellstrom@linux.intel.com \ --cc=zackr@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.