From: kernel test robot <lkp@intel.com>
To: NeilBrown <neilb@suse.de>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Chuck Lever <chuck.lever@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Christoph Hellwig <hch@infradead.org>,
David Howells <dhowells@redhat.com>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space
Date: Mon, 24 Jan 2022 16:25:22 +0800 [thread overview]
Message-ID: <202201241613.8J5z5arQ-lkp@intel.com> (raw)
In-Reply-To: <164299611278.26253.14950274629759580371.stgit@noble.brown>
Hi NeilBrown,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc1 next-20220124]
[cannot apply to trondmy-nfs/linux-next cifs/for-next hnaz-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over_NFS/20220124-115716
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220124/202201241613.8J5z5arQ-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/63bff668aa0537d7ccef9ed428809fc16c1a6b6c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over_NFS/20220124-115716
git checkout 63bff668aa0537d7ccef9ed428809fc16c1a6b6c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from mm/vmscan.c:61:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function]
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
--
In file included from mm/memory.c:89:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
>> mm/swap.h:65:19: warning: 'swap_readpage' used but never defined
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
--
In file included from mm/page_alloc.c:84:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
mm/page_alloc.c:3821:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3821 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from mm/page_alloc.c:84:
mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function]
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
vim +67 mm/swap.h
50dceef273a619 NeilBrown 2022-01-24 45
50dceef273a619 NeilBrown 2022-01-24 46 struct page *read_swap_cache_async(swp_entry_t, gfp_t,
50dceef273a619 NeilBrown 2022-01-24 47 struct vm_area_struct *vma,
50dceef273a619 NeilBrown 2022-01-24 48 unsigned long addr,
63bff668aa0537 NeilBrown 2022-01-24 49 bool do_poll,
63bff668aa0537 NeilBrown 2022-01-24 50 struct swap_iocb **plug);
50dceef273a619 NeilBrown 2022-01-24 51 struct page *__read_swap_cache_async(swp_entry_t, gfp_t,
50dceef273a619 NeilBrown 2022-01-24 52 struct vm_area_struct *vma,
50dceef273a619 NeilBrown 2022-01-24 53 unsigned long addr,
50dceef273a619 NeilBrown 2022-01-24 54 bool *new_page_allocated);
50dceef273a619 NeilBrown 2022-01-24 55 struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag,
50dceef273a619 NeilBrown 2022-01-24 56 struct vm_fault *vmf);
50dceef273a619 NeilBrown 2022-01-24 57 struct page *swapin_readahead(swp_entry_t entry, gfp_t flag,
50dceef273a619 NeilBrown 2022-01-24 58 struct vm_fault *vmf);
50dceef273a619 NeilBrown 2022-01-24 59
12cf545fe71035 NeilBrown 2022-01-24 60 static inline unsigned int page_swap_flags(struct page *page)
12cf545fe71035 NeilBrown 2022-01-24 61 {
12cf545fe71035 NeilBrown 2022-01-24 62 return page_swap_info(page)->flags;
12cf545fe71035 NeilBrown 2022-01-24 63 }
50dceef273a619 NeilBrown 2022-01-24 64 #else /* CONFIG_SWAP */
63bff668aa0537 NeilBrown 2022-01-24 @65 static inline int swap_readpage(struct page *page, bool do_poll,
63bff668aa0537 NeilBrown 2022-01-24 @66 struct swap_iocb **plug);
50dceef273a619 NeilBrown 2022-01-24 @67 {
50dceef273a619 NeilBrown 2022-01-24 68 return 0;
50dceef273a619 NeilBrown 2022-01-24 69 }
50dceef273a619 NeilBrown 2022-01-24 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space
Date: Mon, 24 Jan 2022 16:25:22 +0800 [thread overview]
Message-ID: <202201241613.8J5z5arQ-lkp@intel.com> (raw)
In-Reply-To: <164299611278.26253.14950274629759580371.stgit@noble.brown>
[-- Attachment #1: Type: text/plain, Size: 5830 bytes --]
Hi NeilBrown,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc1 next-20220124]
[cannot apply to trondmy-nfs/linux-next cifs/for-next hnaz-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over_NFS/20220124-115716
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220124/202201241613.8J5z5arQ-lkp(a)intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/63bff668aa0537d7ccef9ed428809fc16c1a6b6c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over_NFS/20220124-115716
git checkout 63bff668aa0537d7ccef9ed428809fc16c1a6b6c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from mm/vmscan.c:61:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function]
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
--
In file included from mm/memory.c:89:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
>> mm/swap.h:65:19: warning: 'swap_readpage' used but never defined
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
--
In file included from mm/page_alloc.c:84:
mm/swap.h:66:40: warning: 'struct swap_iocb' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct swap_iocb **plug);
| ^~~~~~~~~
>> mm/swap.h:67:1: error: expected identifier or '(' before '{' token
67 | {
| ^
mm/page_alloc.c:3821:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
3821 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from mm/page_alloc.c:84:
mm/swap.h:65:19: warning: 'swap_readpage' declared 'static' but never defined [-Wunused-function]
65 | static inline int swap_readpage(struct page *page, bool do_poll,
| ^~~~~~~~~~~~~
vim +67 mm/swap.h
50dceef273a619 NeilBrown 2022-01-24 45
50dceef273a619 NeilBrown 2022-01-24 46 struct page *read_swap_cache_async(swp_entry_t, gfp_t,
50dceef273a619 NeilBrown 2022-01-24 47 struct vm_area_struct *vma,
50dceef273a619 NeilBrown 2022-01-24 48 unsigned long addr,
63bff668aa0537 NeilBrown 2022-01-24 49 bool do_poll,
63bff668aa0537 NeilBrown 2022-01-24 50 struct swap_iocb **plug);
50dceef273a619 NeilBrown 2022-01-24 51 struct page *__read_swap_cache_async(swp_entry_t, gfp_t,
50dceef273a619 NeilBrown 2022-01-24 52 struct vm_area_struct *vma,
50dceef273a619 NeilBrown 2022-01-24 53 unsigned long addr,
50dceef273a619 NeilBrown 2022-01-24 54 bool *new_page_allocated);
50dceef273a619 NeilBrown 2022-01-24 55 struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag,
50dceef273a619 NeilBrown 2022-01-24 56 struct vm_fault *vmf);
50dceef273a619 NeilBrown 2022-01-24 57 struct page *swapin_readahead(swp_entry_t entry, gfp_t flag,
50dceef273a619 NeilBrown 2022-01-24 58 struct vm_fault *vmf);
50dceef273a619 NeilBrown 2022-01-24 59
12cf545fe71035 NeilBrown 2022-01-24 60 static inline unsigned int page_swap_flags(struct page *page)
12cf545fe71035 NeilBrown 2022-01-24 61 {
12cf545fe71035 NeilBrown 2022-01-24 62 return page_swap_info(page)->flags;
12cf545fe71035 NeilBrown 2022-01-24 63 }
50dceef273a619 NeilBrown 2022-01-24 64 #else /* CONFIG_SWAP */
63bff668aa0537 NeilBrown 2022-01-24 @65 static inline int swap_readpage(struct page *page, bool do_poll,
63bff668aa0537 NeilBrown 2022-01-24 @66 struct swap_iocb **plug);
50dceef273a619 NeilBrown 2022-01-24 @67 {
50dceef273a619 NeilBrown 2022-01-24 68 return 0;
50dceef273a619 NeilBrown 2022-01-24 69 }
50dceef273a619 NeilBrown 2022-01-24 70
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2022-01-24 8:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 3:48 [PATCH 00/23 V3] Repair SWAP-over_NFS NeilBrown
2022-01-24 3:48 ` [PATCH 05/23] MM: reclaim mustn't enter FS for SWP_FS_OPS swap-space NeilBrown
2022-01-24 7:31 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 03/23] MM: drop swap_set_page_dirty NeilBrown
2022-01-24 7:28 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 14/23] NFS: swap IO handling is slightly different for O_DIRECT IO NeilBrown
2022-01-24 8:58 ` Christoph Hellwig
2022-01-24 13:22 ` Mark Hemment
2022-01-26 22:51 ` NeilBrown
2022-01-24 3:48 ` [PATCH 22/23] NFS: swap-out must always use STABLE writes NeilBrown
2022-01-26 3:45 ` Trond Myklebust
2022-01-26 21:42 ` NeilBrown
2022-01-24 3:48 ` [PATCH 23/23] SUNRPC: lock against ->sock changing during sysfs read NeilBrown
2022-01-24 3:48 ` [PATCH 08/23] DOC: update documentation for swap_activate and swap_rw NeilBrown
2022-01-24 8:50 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 07/23] MM: perform async writes to SWP_FS_OPS swap-space using ->swap_rw NeilBrown
2022-01-24 8:49 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 02/23] MM: extend block-plugging to cover all swap reads with read-ahead NeilBrown
2022-01-24 7:27 ` Christoph Hellwig
2022-01-26 21:47 ` NeilBrown
2022-01-26 23:09 ` Hugh Dickins
2022-01-27 0:32 ` NeilBrown
2022-01-24 3:48 ` [PATCH 16/23] SUNRPC/auth: async tasks mustn't block waiting for memory NeilBrown
2022-01-24 3:48 ` [PATCH 04/23] MM: move responsibility for setting SWP_FS_OPS to ->swap_activate NeilBrown
2022-01-24 7:30 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 06/23] MM: introduce ->swap_rw and use it for reads from SWP_FS_OPS swap-space NeilBrown
2022-01-24 8:48 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 15/23] SUNRPC/call_alloc: async tasks mustn't block waiting for memory NeilBrown
2022-01-24 3:48 ` [PATCH 20/23] SUNRPC: improve 'swap' handling: scheduling and PF_MEMALLOC NeilBrown
2022-01-24 3:48 ` [PATCH 01/23] MM: create new mm/swap.h header file NeilBrown
2022-02-07 13:51 ` Geert Uytterhoeven
2022-01-24 3:48 ` [PATCH 09/23] MM: submit multipage reads for SWP_FS_OPS swap-space NeilBrown
2022-01-24 8:25 ` kernel test robot [this message]
2022-01-24 8:25 ` kernel test robot
2022-01-24 8:52 ` Christoph Hellwig
2022-01-24 9:27 ` kernel test robot
2022-01-24 9:27 ` kernel test robot
2022-01-24 13:16 ` Mark Hemment
2022-01-26 22:04 ` NeilBrown
2022-02-08 11:07 ` Geert Uytterhoeven
2022-01-24 3:48 ` [PATCH 12/23] NFS: remove IS_SWAPFILE hack NeilBrown
2022-01-24 8:56 ` Christoph Hellwig
2022-01-24 3:48 ` [PATCH 19/23] NFS: discard NFS_RPC_SWAPFLAGS and RPC_TASK_ROOTCREDS NeilBrown
2022-01-24 3:48 ` [PATCH 17/23] SUNRPC/xprt: async tasks mustn't block waiting for memory NeilBrown
2022-01-24 3:48 ` [PATCH 18/23] SUNRPC: remove scheduling boost for "SWAPPER" tasks NeilBrown
2022-01-24 3:48 ` [PATCH 21/23] NFSv4: keep state manager thread active if swap is enabled NeilBrown
2022-01-24 3:48 ` [PATCH 11/23] VFS: Add FMODE_CAN_ODIRECT file flag NeilBrown
2022-01-24 8:56 ` Christoph Hellwig
2022-01-26 22:14 ` NeilBrown
2022-01-24 3:48 ` [PATCH 10/23] MM: submit multipage write for SWP_FS_OPS swap-space NeilBrown
2022-01-24 8:55 ` Christoph Hellwig
2022-01-24 10:29 ` kernel test robot
2022-01-24 10:29 ` kernel test robot
2022-01-24 3:48 ` [PATCH 13/23] NFS: rename nfs_direct_IO and use as ->swap_rw NeilBrown
2022-01-24 8:57 ` Christoph Hellwig
2022-02-07 17:55 ` [PATCH 00/23 V3] Repair SWAP-over_NFS Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201241613.8J5z5arQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=neilb@suse.de \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.