Re: [PATCH v15 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver

From: kernel test robot <lkp@intel.com>
To: Ming Qian <ming.qian@nxp.com>,
	mchehab@kernel.org, shawnguo@kernel.org, robh+dt@kernel.org,
	s.hauer@pengutronix.de
Cc: kbuild-all@lists.01.org, hverkuil-cisco@xs4all.nl,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	aisheng.dong@nxp.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v15 07/13] media: amphion: add v4l2 m2m vpu encoder stateful driver
Date: Tue, 25 Jan 2022 19:34:45 +0800	[thread overview]
Message-ID: <202201251914.xAqudfEM-lkp@intel.com> (raw)
In-Reply-To: <b42d02b6572468483da10acb41807df8ed7ff8cd.1643077283.git.ming.qian@nxp.com>

Hi Ming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on e783362eb54cd99b2cac8b3a9aeac942e6f6ac07]

url:    https://github.com/0day-ci/linux/commits/Ming-Qian/amphion-video-decoder-encoder-driver/20220125-152112
base:   e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220125/202201251914.xAqudfEM-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0d6244aad6fd7e7c377163865a29319cb2a6df84
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Qian/amphion-video-decoder-encoder-driver/20220125-152112
        git checkout 0d6244aad6fd7e7c377163865a29319cb2a6df84
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/media/platform/amphion/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/media/platform/amphion/venc.c: In function 'venc_get_encoded_frames':
   drivers/media/platform/amphion/venc.c:832:17: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
     832 |                 vfree(frame);
         |                 ^~~~~
         |                 kvfree
   drivers/media/platform/amphion/venc.c: In function 'venc_frame_encoded':
   drivers/media/platform/amphion/venc.c:848:17: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
     848 |         frame = vzalloc(sizeof(*frame));
         |                 ^~~~~~~
         |                 kvzalloc
>> drivers/media/platform/amphion/venc.c:848:15: warning: assignment to 'struct venc_frame_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     848 |         frame = vzalloc(sizeof(*frame));
         |               ^
   drivers/media/platform/amphion/venc.c: In function 'venc_open':
>> drivers/media/platform/amphion/venc.c:1321:14: warning: assignment to 'struct vpu_inst *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1321 |         inst = vzalloc(sizeof(*inst));
         |              ^
>> drivers/media/platform/amphion/venc.c:1325:14: warning: assignment to 'struct venc_t *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1325 |         venc = vzalloc(sizeof(*venc));
         |              ^
   cc1: some warnings being treated as errors

vim +848 drivers/media/platform/amphion/venc.c

   837	
   838	static int venc_frame_encoded(struct vpu_inst *inst, void *arg)
   839	{
   840		struct vpu_enc_pic_info *info = arg;
   841		struct venc_frame_t *frame;
   842		struct venc_t *venc;
   843		int ret = 0;
   844	
   845		if (!inst || !info)
   846			return -EINVAL;
   847		venc = inst->priv;
 > 848		frame = vzalloc(sizeof(*frame));
   849		if (!frame)
   850			return -ENOMEM;
   851	
   852		memcpy(&frame->info, info, sizeof(frame->info));
   853		frame->bytesused = info->frame_size;
   854	
   855		vpu_inst_lock(inst);
   856		list_add_tail(&frame->list, &venc->frames);
   857		venc->encode_count++;
   858		venc_get_encoded_frames(inst);
   859		vpu_inst_unlock(inst);
   860	
   861		return ret;
   862	}
   863	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org