From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>
Subject: Re: [PATCH 22/31] clk: mediatek: gate: Implement error handling in register API
Date: Wed, 26 Jan 2022 15:42:42 +0800 [thread overview]
Message-ID: <20220126074242.18291-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220122091731.283592-23-wenst@chromium.org>
> The gate clk type registration function does not stop or return errors
> if any clk failed to be registered, nor does it implement an error
> handling path. This may result in a partially working device if any
> step failed.
>
> Make the register function return proper error codes, and bail out if
> errors occur. Proper cleanup, i.e. unregister any clks that were
> successfully registered, is done in the new error path.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-gate.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index e8881ae1489a..631ff170b7b9 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -237,13 +237,26 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
>
> if (IS_ERR(clk)) {
> pr_err("Failed to register clk %s: %pe\n", gate->name, clk);
> - continue;
> + goto err;
> }
>
> clk_data->clks[gate->id] = clk;
> }
>
> return 0;
> +
> +err:
> + while (--i >= 0) {
> + const struct mtk_gate *gate = &clks[i];
> +
> + if (IS_ERR_OR_NULL(clk_data->clks[gate->id]))
> + continue;
> +
> + mtk_clk_unregister_gate(clk_data->clks[gate->id]);
> + clk_data->clks[gate->id] = ERR_PTR(-ENOENT);
> + }
> +
> + return PTR_ERR(clk);
> }
>
> int mtk_clk_register_gates(struct device_node *node,
> --
> 2.35.0.rc0.227.g00780c9af4-goog
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>
Subject: Re: [PATCH 22/31] clk: mediatek: gate: Implement error handling in register API
Date: Wed, 26 Jan 2022 15:42:42 +0800 [thread overview]
Message-ID: <20220126074242.18291-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220122091731.283592-23-wenst@chromium.org>
> The gate clk type registration function does not stop or return errors
> if any clk failed to be registered, nor does it implement an error
> handling path. This may result in a partially working device if any
> step failed.
>
> Make the register function return proper error codes, and bail out if
> errors occur. Proper cleanup, i.e. unregister any clks that were
> successfully registered, is done in the new error path.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-gate.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index e8881ae1489a..631ff170b7b9 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -237,13 +237,26 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
>
> if (IS_ERR(clk)) {
> pr_err("Failed to register clk %s: %pe\n", gate->name, clk);
> - continue;
> + goto err;
> }
>
> clk_data->clks[gate->id] = clk;
> }
>
> return 0;
> +
> +err:
> + while (--i >= 0) {
> + const struct mtk_gate *gate = &clks[i];
> +
> + if (IS_ERR_OR_NULL(clk_data->clks[gate->id]))
> + continue;
> +
> + mtk_clk_unregister_gate(clk_data->clks[gate->id]);
> + clk_data->clks[gate->id] = ERR_PTR(-ENOENT);
> + }
> +
> + return PTR_ERR(clk);
> }
>
> int mtk_clk_register_gates(struct device_node *node,
> --
> 2.35.0.rc0.227.g00780c9af4-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<mturquette@baylibre.com>, <sboyd@kernel.org>
Subject: Re: [PATCH 22/31] clk: mediatek: gate: Implement error handling in register API
Date: Wed, 26 Jan 2022 15:42:42 +0800 [thread overview]
Message-ID: <20220126074242.18291-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220122091731.283592-23-wenst@chromium.org>
> The gate clk type registration function does not stop or return errors
> if any clk failed to be registered, nor does it implement an error
> handling path. This may result in a partially working device if any
> step failed.
>
> Make the register function return proper error codes, and bail out if
> errors occur. Proper cleanup, i.e. unregister any clks that were
> successfully registered, is done in the new error path.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-gate.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
> index e8881ae1489a..631ff170b7b9 100644
> --- a/drivers/clk/mediatek/clk-gate.c
> +++ b/drivers/clk/mediatek/clk-gate.c
> @@ -237,13 +237,26 @@ int mtk_clk_register_gates_with_dev(struct device_node *node,
>
> if (IS_ERR(clk)) {
> pr_err("Failed to register clk %s: %pe\n", gate->name, clk);
> - continue;
> + goto err;
> }
>
> clk_data->clks[gate->id] = clk;
> }
>
> return 0;
> +
> +err:
> + while (--i >= 0) {
> + const struct mtk_gate *gate = &clks[i];
> +
> + if (IS_ERR_OR_NULL(clk_data->clks[gate->id]))
> + continue;
> +
> + mtk_clk_unregister_gate(clk_data->clks[gate->id]);
> + clk_data->clks[gate->id] = ERR_PTR(-ENOENT);
> + }
> +
> + return PTR_ERR(clk);
> }
>
> int mtk_clk_register_gates(struct device_node *node,
> --
> 2.35.0.rc0.227.g00780c9af4-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-26 7:42 UTC|newest]
Thread overview: 205+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-22 9:17 [PATCH 00/31] clk: mediatek: Cleanups and Improvements - Part 1 Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` [PATCH 01/31] clk: mediatek: Use %pe to print errors Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 15:56 ` Miles Chen
2022-01-24 15:56 ` Miles Chen
2022-01-22 9:17 ` [PATCH 02/31] clk: mediatek: gate: Consolidate gate type clk related code Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 16:04 ` Miles Chen
2022-01-24 16:04 ` Miles Chen
2022-01-24 16:04 ` Miles Chen
2022-01-22 9:17 ` [PATCH 03/31] clk: mediatek: gate: Internalize clk implementation Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 16:09 ` Miles Chen
2022-01-24 16:09 ` Miles Chen
2022-01-24 16:09 ` Miles Chen
2022-01-22 9:17 ` [PATCH 04/31] clk: mediatek: gate: Implement unregister API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 16:21 ` Miles Chen
2022-01-24 16:21 ` Miles Chen
2022-01-24 16:21 ` Miles Chen
2022-01-22 9:17 ` [PATCH 05/31] clk: mediatek: gate: Clean up included headers Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 16:29 ` Miles Chen
2022-01-24 16:29 ` Miles Chen
2022-01-24 16:29 ` Miles Chen
2022-01-22 9:17 ` [PATCH 06/31] clk: mediatek: cpumux: Implement unregister API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:11 ` Miles Chen
2022-01-25 17:11 ` Miles Chen
2022-01-25 17:11 ` Miles Chen
2022-01-22 9:17 ` [PATCH 07/31] clk: mediatek: cpumux: Internalize struct mtk_clk_cpumux Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:14 ` Miles Chen
2022-01-25 17:14 ` Miles Chen
2022-01-25 17:14 ` Miles Chen
2022-01-22 9:17 ` [PATCH 08/31] clk: mediatek: cpumux: Clean up included headers Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:16 ` Miles Chen
2022-01-25 17:16 ` Miles Chen
2022-01-25 17:16 ` Miles Chen
2022-01-22 9:17 ` [PATCH 09/31] clk: mediatek: mux: Implement unregister API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:20 ` Miles Chen
2022-01-25 17:20 ` Miles Chen
2022-01-25 17:20 ` Miles Chen
2022-01-26 6:04 ` [PATCH 13/31] clk: mediatek: pll: " Miles Chen
2022-01-26 6:04 ` Miles Chen
2022-01-26 6:04 ` Miles Chen
2022-01-26 6:18 ` Chen-Yu Tsai
2022-01-26 6:18 ` Chen-Yu Tsai
2022-01-26 6:18 ` Chen-Yu Tsai
2022-01-22 9:17 ` [PATCH 10/31] clk: mediatek: mux: Internalize struct mtk_clk_mux Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:22 ` Miles Chen
2022-01-25 17:22 ` Miles Chen
2022-01-25 17:22 ` Miles Chen
2022-01-22 9:17 ` [PATCH 11/31] clk: mediatek: mux: Clean up included headers Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-25 17:38 ` Miles Chen
2022-01-25 17:38 ` Miles Chen
2022-01-25 17:38 ` Miles Chen
2022-01-26 6:32 ` Chen-Yu Tsai
2022-01-26 6:32 ` Chen-Yu Tsai
2022-01-26 6:32 ` Chen-Yu Tsai
2022-01-22 9:17 ` [PATCH 12/31] clk: mediatek: pll: Split definitions into separate header file Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 6:06 ` Miles Chen
2022-01-26 6:06 ` Miles Chen
2022-01-26 6:06 ` Miles Chen
2022-01-22 9:17 ` [PATCH 13/31] clk: mediatek: pll: Implement unregister API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` [PATCH 14/31] clk: mediatek: pll: Clean up included headers Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 6:36 ` Miles Chen
2022-01-26 6:36 ` Miles Chen
2022-01-26 6:36 ` Miles Chen
2022-02-02 12:58 ` Chen-Yu Tsai
2022-02-02 12:58 ` Chen-Yu Tsai
2022-02-02 12:58 ` Chen-Yu Tsai
2022-01-22 9:17 ` [PATCH 15/31] clk: mediatek: Implement mtk_clk_unregister_fixed_clks() API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 6:55 ` Miles Chen
2022-01-26 6:55 ` Miles Chen
2022-01-26 6:55 ` Miles Chen
2022-01-22 9:17 ` [PATCH 16/31] clk: mediatek: Implement mtk_clk_unregister_factors() API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 6:56 ` Miles Chen
2022-01-26 6:56 ` Miles Chen
2022-01-26 6:56 ` Miles Chen
2022-01-22 9:17 ` [PATCH 17/31] clk: mediatek: Implement mtk_clk_unregister_divider_clks() API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 6:58 ` Miles Chen
2022-01-26 6:58 ` Miles Chen
2022-01-26 6:58 ` Miles Chen
2022-01-22 9:17 ` [PATCH 18/31] clk: mediatek: Implement mtk_clk_unregister_composites() API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 7:06 ` Miles Chen
2022-01-26 7:06 ` Miles Chen
2022-01-26 7:06 ` Miles Chen
2022-01-22 9:17 ` [PATCH 19/31] clk: mediatek: Add mtk_clk_simple_remove() Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 7:13 ` Miles Chen
2022-01-26 7:13 ` Miles Chen
2022-01-26 7:13 ` Miles Chen
2022-01-22 9:17 ` [PATCH 20/31] clk: mediatek: mtk: Clean up included headers Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 7:26 ` Miles Chen
2022-01-26 7:26 ` Miles Chen
2022-01-26 7:26 ` Miles Chen
2022-01-22 9:17 ` [PATCH 21/31] clk: mediatek: cpumux: Implement error handling in register API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 7:29 ` Miles Chen
2022-01-26 7:29 ` Miles Chen
2022-01-26 7:29 ` Miles Chen
2022-01-22 9:17 ` [PATCH 22/31] clk: mediatek: gate: " Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 7:42 ` Miles Chen [this message]
2022-01-26 7:42 ` Miles Chen
2022-01-26 7:42 ` Miles Chen
2022-01-22 9:17 ` [PATCH 23/31] clk: mediatek: mux: Reverse check for existing clk to reduce nesting level Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:08 ` Miles Chen
2022-01-26 8:08 ` Miles Chen
2022-01-26 8:08 ` Miles Chen
2022-01-22 9:17 ` [PATCH 24/31] clk: mediatek: mux: Implement error handling in register API Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:09 ` Miles Chen
2022-01-26 8:09 ` Miles Chen
2022-01-26 8:09 ` Miles Chen
2022-01-22 9:17 ` [PATCH 25/31] clk: mediatek: pll: " Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-24 12:05 ` [PATCH] clk: mediatek: pll: fix semicolon.cocci warnings kernel test robot
2022-01-24 12:05 ` kernel test robot
2022-01-24 12:05 ` kernel test robot
2022-01-24 12:05 ` kernel test robot
2022-01-24 12:14 ` [PATCH 25/31] clk: mediatek: pll: Implement error handling in register API kernel test robot
2022-01-24 12:14 ` kernel test robot
2022-01-24 12:14 ` kernel test robot
2022-01-24 12:14 ` kernel test robot
2022-01-26 8:13 ` Miles Chen
2022-01-26 8:13 ` Miles Chen
2022-01-26 8:13 ` Miles Chen
2022-01-22 9:17 ` [PATCH 26/31] clk: mediatek: mtk: Implement error handling in register APIs Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:16 ` Miles Chen
2022-01-26 8:16 ` Miles Chen
2022-01-26 8:16 ` Miles Chen
2022-01-22 9:17 ` [PATCH 27/31] clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:19 ` Miles Chen
2022-01-26 8:19 ` Miles Chen
2022-01-26 8:19 ` Miles Chen
2022-01-22 9:17 ` [PATCH 28/31] clk: mediatek: mt8195: Hook up mtk_clk_simple_remove() Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:23 ` Miles Chen
2022-01-26 8:23 ` Miles Chen
2022-01-26 8:23 ` Miles Chen
2022-01-22 9:17 ` [PATCH 29/31] clk: mediatek: mt8195: Implement error handling in probe functions Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:37 ` Miles Chen
2022-01-26 8:37 ` Miles Chen
2022-01-26 8:37 ` Miles Chen
2022-01-22 9:17 ` [PATCH 30/31] clk: mediatek: mt8195: Implement remove functions Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:40 ` Miles Chen
2022-01-26 8:40 ` Miles Chen
2022-01-26 8:40 ` Miles Chen
2022-01-22 9:17 ` [PATCH 31/31] clk: mediatek: Warn if clk IDs are duplicated Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-22 9:17 ` Chen-Yu Tsai
2022-01-26 8:59 ` Miles Chen
2022-01-26 8:59 ` Miles Chen
2022-01-26 8:59 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126074242.18291-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.