All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	"Emma Anholt" <emma@anholt.net>,
	"Yiwei Zhang" <zzyiwei@chromium.org>,
	"Rob Clark" <robdclark@chromium.org>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Akhil P Oommen" <quic_akhilpo@quicinc.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Jonathan Marek" <jonathan@marek.ca>,
	"Jordan Crouse" <jordan@cosmicpenguin.net>,
	linux-kernel@vger.kernel.org (open list),
	"Stephen Boyd" <swboyd@chromium.org>,
	"Vladimir Lypak" <vladimir.lypak@gmail.com>,
	"Yangtao Li" <tiny.windzz@gmail.com>
Subject: [PATCH v2 0/2] drm/msm: Add tracking for faults associated with an address space
Date: Tue,  1 Feb 2022 08:16:10 -0800	[thread overview]
Message-ID: <20220201161618.778455-1-robdclark@gmail.com> (raw)

From: Rob Clark <robdclark@chromium.org>

Currently, for GL_EXT_robustness userspace uses the global and per-
submitqueue fault counters to determine GUILTY_CONTEXT_RESET_EXT vs
INNOCENT_CONTEXT_RESET_EXT.  But that is a bit overly paranoid, in
that a fault in a different process's context (when it has it's own
isolated address space) should not hurt anything.

This is particularly annoying with CrOS and chrome's exit_on_context_lost quirk,
while running deqp in the android container, as the deqp-egl suite has
tests that intentionally trigger gpu hangs (for the purpose of testing
the robustness extension), which triggers chrome to restart, which
restarts the android container!

But chrome doesn't need to know about these faults, thanks to address
space isolation.

Applies on top of https://patchwork.freedesktop.org/series/98907/

Rob Clark (2):
  drm/msm/gpu: Add ctx to get_param()
  drm/msm/gpu: Track global faults per address-space

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 +++--
 drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 ++-
 drivers/gpu/drm/msm/msm_drv.c           | 3 ++-
 drivers/gpu/drm/msm/msm_gem.h           | 3 +++
 drivers/gpu/drm/msm/msm_gpu.c           | 8 +++++++-
 drivers/gpu/drm/msm/msm_gpu.h           | 8 ++++++--
 drivers/gpu/drm/msm/msm_rd.c            | 6 ++++--
 7 files changed, 27 insertions(+), 9 deletions(-)

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: "Rob Clark" <robdclark@chromium.org>,
	"Jonathan Marek" <jonathan@marek.ca>,
	"Emma Anholt" <emma@anholt.net>,
	"Akhil P Oommen" <quic_akhilpo@quicinc.com>,
	linux-arm-msm@vger.kernel.org,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Vladimir Lypak" <vladimir.lypak@gmail.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Yangtao Li" <tiny.windzz@gmail.com>,
	"Yiwei Zhang" <zzyiwei@chromium.org>,
	"Jordan Crouse" <jordan@cosmicpenguin.net>,
	freedreno@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/2] drm/msm: Add tracking for faults associated with an address space
Date: Tue,  1 Feb 2022 08:16:10 -0800	[thread overview]
Message-ID: <20220201161618.778455-1-robdclark@gmail.com> (raw)

From: Rob Clark <robdclark@chromium.org>

Currently, for GL_EXT_robustness userspace uses the global and per-
submitqueue fault counters to determine GUILTY_CONTEXT_RESET_EXT vs
INNOCENT_CONTEXT_RESET_EXT.  But that is a bit overly paranoid, in
that a fault in a different process's context (when it has it's own
isolated address space) should not hurt anything.

This is particularly annoying with CrOS and chrome's exit_on_context_lost quirk,
while running deqp in the android container, as the deqp-egl suite has
tests that intentionally trigger gpu hangs (for the purpose of testing
the robustness extension), which triggers chrome to restart, which
restarts the android container!

But chrome doesn't need to know about these faults, thanks to address
space isolation.

Applies on top of https://patchwork.freedesktop.org/series/98907/

Rob Clark (2):
  drm/msm/gpu: Add ctx to get_param()
  drm/msm/gpu: Track global faults per address-space

 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 +++--
 drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 ++-
 drivers/gpu/drm/msm/msm_drv.c           | 3 ++-
 drivers/gpu/drm/msm/msm_gem.h           | 3 +++
 drivers/gpu/drm/msm/msm_gpu.c           | 8 +++++++-
 drivers/gpu/drm/msm/msm_gpu.h           | 8 ++++++--
 drivers/gpu/drm/msm/msm_rd.c            | 6 ++++--
 7 files changed, 27 insertions(+), 9 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-02-01 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 16:16 Rob Clark [this message]
2022-02-01 16:16 ` [PATCH v2 0/2] drm/msm: Add tracking for faults associated with an address space Rob Clark
2022-02-01 16:16 ` [PATCH v2 1/2] drm/msm/gpu: Add ctx to get_param() Rob Clark
2022-02-01 16:16   ` Rob Clark
2022-02-02 19:27   ` Emma Anholt
2022-02-02 19:27     ` Emma Anholt
2022-02-01 16:16 ` [PATCH v2 2/2] drm/msm/gpu: Track global faults per address-space Rob Clark
2022-02-01 16:16   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201161618.778455-1-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jonathan@marek.ca \
    --cc=jordan@cosmicpenguin.net \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_akhilpo@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=swboyd@chromium.org \
    --cc=tiny.windzz@gmail.com \
    --cc=vladimir.lypak@gmail.com \
    --cc=zzyiwei@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.