All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <anup@brainfault.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: qemu-riscv@nongnu.org, Frank Chang <frank.chang@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	qemu-devel@nongnu.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Atish Patra <atishp@atishpatra.org>,
	Bin Meng <bmeng.cn@gmail.com>
Subject: [PATCH v9 08/23] target/riscv: Allow AIA device emulation to set ireg rmw callback
Date: Fri,  4 Feb 2022 23:16:44 +0530	[thread overview]
Message-ID: <20220204174700.534953-9-anup@brainfault.org> (raw)
In-Reply-To: <20220204174700.534953-1-anup@brainfault.org>

From: Anup Patel <anup.patel@wdc.com>

The AIA device emulation (such as AIA IMSIC) should be able to set
(or provide) AIA ireg read-modify-write callback for each privilege
level of a RISC-V HART.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
 target/riscv/cpu.h        | 23 +++++++++++++++++++++++
 target/riscv/cpu_helper.c | 14 ++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 8838c61ae4..6b6df57c42 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -256,6 +256,22 @@ struct CPURISCVState {
     uint64_t (*rdtime_fn)(uint32_t);
     uint32_t rdtime_fn_arg;
 
+    /* machine specific AIA ireg read-modify-write callback */
+#define AIA_MAKE_IREG(__isel, __priv, __virt, __vgein, __xlen) \
+    ((((__xlen) & 0xff) << 24) | \
+     (((__vgein) & 0x3f) << 20) | \
+     (((__virt) & 0x1) << 18) | \
+     (((__priv) & 0x3) << 16) | \
+     (__isel & 0xffff))
+#define AIA_IREG_ISEL(__ireg)                  ((__ireg) & 0xffff)
+#define AIA_IREG_PRIV(__ireg)                  (((__ireg) >> 16) & 0x3)
+#define AIA_IREG_VIRT(__ireg)                  (((__ireg) >> 18) & 0x1)
+#define AIA_IREG_VGEIN(__ireg)                 (((__ireg) >> 20) & 0x3f)
+#define AIA_IREG_XLEN(__ireg)                  (((__ireg) >> 24) & 0xff)
+    int (*aia_ireg_rmw_fn[4])(void *arg, target_ulong reg,
+        target_ulong *val, target_ulong new_val, target_ulong write_mask);
+    void *aia_ireg_rmw_fn_arg[4];
+
     /* True if in debugger mode.  */
     bool debugger;
 
@@ -433,6 +449,13 @@ uint32_t riscv_cpu_update_mip(RISCVCPU *cpu, uint32_t mask, uint32_t value);
 #define BOOL_TO_MASK(x) (-!!(x)) /* helper for riscv_cpu_update_mip value */
 void riscv_cpu_set_rdtime_fn(CPURISCVState *env, uint64_t (*fn)(uint32_t),
                              uint32_t arg);
+void riscv_cpu_set_aia_ireg_rmw_fn(CPURISCVState *env, uint32_t priv,
+                                   int (*rmw_fn)(void *arg,
+                                                 target_ulong reg,
+                                                 target_ulong *val,
+                                                 target_ulong new_val,
+                                                 target_ulong write_mask),
+                                   void *rmw_fn_arg);
 #endif
 void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv);
 
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index f7b8645a13..5ed4e9223c 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -396,6 +396,20 @@ void riscv_cpu_set_rdtime_fn(CPURISCVState *env, uint64_t (*fn)(uint32_t),
     env->rdtime_fn_arg = arg;
 }
 
+void riscv_cpu_set_aia_ireg_rmw_fn(CPURISCVState *env, uint32_t priv,
+                                   int (*rmw_fn)(void *arg,
+                                                 target_ulong reg,
+                                                 target_ulong *val,
+                                                 target_ulong new_val,
+                                                 target_ulong write_mask),
+                                   void *rmw_fn_arg)
+{
+    if (priv <= PRV_M) {
+        env->aia_ireg_rmw_fn[priv] = rmw_fn;
+        env->aia_ireg_rmw_fn_arg[priv] = rmw_fn_arg;
+    }
+}
+
 void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv)
 {
     if (newpriv > PRV_M) {
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <anup@brainfault.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>
Cc: Atish Patra <atishp@atishpatra.org>,
	Anup Patel <anup@brainfault.org>, Bin Meng <bmeng.cn@gmail.com>,
	qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
	Alistair Francis <alistair.francis@wdc.com>,
	Frank Chang <frank.chang@sifive.com>
Subject: [PATCH v9 08/23] target/riscv: Allow AIA device emulation to set ireg rmw callback
Date: Fri,  4 Feb 2022 23:16:44 +0530	[thread overview]
Message-ID: <20220204174700.534953-9-anup@brainfault.org> (raw)
In-Reply-To: <20220204174700.534953-1-anup@brainfault.org>

From: Anup Patel <anup.patel@wdc.com>

The AIA device emulation (such as AIA IMSIC) should be able to set
(or provide) AIA ireg read-modify-write callback for each privilege
level of a RISC-V HART.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Signed-off-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
 target/riscv/cpu.h        | 23 +++++++++++++++++++++++
 target/riscv/cpu_helper.c | 14 ++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 8838c61ae4..6b6df57c42 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -256,6 +256,22 @@ struct CPURISCVState {
     uint64_t (*rdtime_fn)(uint32_t);
     uint32_t rdtime_fn_arg;
 
+    /* machine specific AIA ireg read-modify-write callback */
+#define AIA_MAKE_IREG(__isel, __priv, __virt, __vgein, __xlen) \
+    ((((__xlen) & 0xff) << 24) | \
+     (((__vgein) & 0x3f) << 20) | \
+     (((__virt) & 0x1) << 18) | \
+     (((__priv) & 0x3) << 16) | \
+     (__isel & 0xffff))
+#define AIA_IREG_ISEL(__ireg)                  ((__ireg) & 0xffff)
+#define AIA_IREG_PRIV(__ireg)                  (((__ireg) >> 16) & 0x3)
+#define AIA_IREG_VIRT(__ireg)                  (((__ireg) >> 18) & 0x1)
+#define AIA_IREG_VGEIN(__ireg)                 (((__ireg) >> 20) & 0x3f)
+#define AIA_IREG_XLEN(__ireg)                  (((__ireg) >> 24) & 0xff)
+    int (*aia_ireg_rmw_fn[4])(void *arg, target_ulong reg,
+        target_ulong *val, target_ulong new_val, target_ulong write_mask);
+    void *aia_ireg_rmw_fn_arg[4];
+
     /* True if in debugger mode.  */
     bool debugger;
 
@@ -433,6 +449,13 @@ uint32_t riscv_cpu_update_mip(RISCVCPU *cpu, uint32_t mask, uint32_t value);
 #define BOOL_TO_MASK(x) (-!!(x)) /* helper for riscv_cpu_update_mip value */
 void riscv_cpu_set_rdtime_fn(CPURISCVState *env, uint64_t (*fn)(uint32_t),
                              uint32_t arg);
+void riscv_cpu_set_aia_ireg_rmw_fn(CPURISCVState *env, uint32_t priv,
+                                   int (*rmw_fn)(void *arg,
+                                                 target_ulong reg,
+                                                 target_ulong *val,
+                                                 target_ulong new_val,
+                                                 target_ulong write_mask),
+                                   void *rmw_fn_arg);
 #endif
 void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv);
 
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index f7b8645a13..5ed4e9223c 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -396,6 +396,20 @@ void riscv_cpu_set_rdtime_fn(CPURISCVState *env, uint64_t (*fn)(uint32_t),
     env->rdtime_fn_arg = arg;
 }
 
+void riscv_cpu_set_aia_ireg_rmw_fn(CPURISCVState *env, uint32_t priv,
+                                   int (*rmw_fn)(void *arg,
+                                                 target_ulong reg,
+                                                 target_ulong *val,
+                                                 target_ulong new_val,
+                                                 target_ulong write_mask),
+                                   void *rmw_fn_arg)
+{
+    if (priv <= PRV_M) {
+        env->aia_ireg_rmw_fn[priv] = rmw_fn;
+        env->aia_ireg_rmw_fn_arg[priv] = rmw_fn_arg;
+    }
+}
+
 void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv)
 {
     if (newpriv > PRV_M) {
-- 
2.25.1



  parent reply	other threads:[~2022-02-04 18:33 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 17:46 [PATCH v9 00/23] QEMU RISC-V AIA support Anup Patel
2022-02-04 17:46 ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 01/23] target/riscv: Fix trap cause for RV32 HS-mode CSR access from RV64 HS-mode Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 02/23] target/riscv: Implement SGEIP bit in hip and hie CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 03/23] target/riscv: Implement hgeie and hgeip CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 04/23] target/riscv: Improve delivery of guest external interrupts Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 05/23] target/riscv: Allow setting CPU feature from machine/device emulation Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 06/23] target/riscv: Add AIA cpu feature Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 07/23] target/riscv: Add defines for AIA CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` Anup Patel [this message]
2022-02-04 17:46   ` [PATCH v9 08/23] target/riscv: Allow AIA device emulation to set ireg rmw callback Anup Patel
2022-02-04 17:46 ` [PATCH v9 09/23] target/riscv: Implement AIA local interrupt priorities Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 10/23] target/riscv: Implement AIA CSRs for 64 local interrupts on RV32 Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 11/23] target/riscv: Implement AIA hvictl and hviprioX CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 12/23] target/riscv: Implement AIA interrupt filtering CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 13/23] target/riscv: Implement AIA mtopi, stopi, and vstopi CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 14/23] target/riscv: Implement AIA xiselect and xireg CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 15/23] target/riscv: Implement AIA IMSIC interface CSRs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 16/23] hw/riscv: virt: Use AIA INTC compatible string when available Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 17/23] target/riscv: Allow users to force enable AIA CSRs in HART Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 18/23] hw/intc: Add RISC-V AIA APLIC device emulation Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 19/23] hw/riscv: virt: Add optional AIA APLIC support to virt machine Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 20/23] hw/intc: Add RISC-V AIA IMSIC device emulation Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 21/23] hw/riscv: virt: Add optional AIA IMSIC support to virt machine Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 22/23] docs/system: riscv: Document AIA options for " Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-04 17:46 ` [PATCH v9 23/23] hw/riscv: virt: Increase maximum number of allowed CPUs Anup Patel
2022-02-04 17:46   ` Anup Patel
2022-02-08  4:16 ` [PATCH v9 00/23] QEMU RISC-V AIA support Alistair Francis
2022-02-08  4:16   ` Alistair Francis
2022-02-08  6:51   ` Alistair Francis
2022-02-08  6:51     ` Alistair Francis
2022-02-08  7:32     ` Anup Patel
2022-02-08  7:32       ` Anup Patel
2022-02-10  8:28     ` Atish Patra
2022-02-10  8:28       ` Atish Patra
2022-02-10 10:24       ` Anup Patel
2022-02-10 10:24         ` Anup Patel
2022-02-11  8:28         ` Alistair Francis
2022-02-11  8:28           ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204174700.534953-9-anup@brainfault.org \
    --to=anup@brainfault.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=atishp@atishpatra.org \
    --cc=bmeng.cn@gmail.com \
    --cc=frank.chang@sifive.com \
    --cc=palmer@dabbelt.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.