From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Dan Williams" <dan.j.williams@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Karol Herbst" <kherbst@redhat.com>,
"Lyude Paul" <lyude@redhat.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
nouveau@lists.freedesktop.org,
"Linux NVDIMM" <nvdimm@lists.linux.dev>,
"Linux MM" <linux-mm@kvack.org>
Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount
Date: Wed, 9 Feb 2022 14:53:51 +0100 [thread overview]
Message-ID: <20220209135351.GA20631@lst.de> (raw)
In-Reply-To: <20220209122956.GI49147@ziepe.ca>
On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote:
> It is nice, but the other series are still impacted by the fsdax mess
> - they still stuff pages into ptes without proper refcounts and have
> to carry nonsense to dance around this problem.
>
> I certainly would be unhappy if the amd driver, for instance, gained
> the fsdax problem as well and started pushing 4k pages into PMDs.
As said before: I think this all needs to be fixed. But I'd rather
fix it gradually and I think this series is a nice step forward.
After that we can look at the pte mappings.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Linux NVDIMM" <nvdimm@lists.linux.dev>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
nouveau@lists.freedesktop.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
"Linux MM" <linux-mm@kvack.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount
Date: Wed, 9 Feb 2022 14:53:51 +0100 [thread overview]
Message-ID: <20220209135351.GA20631@lst.de> (raw)
In-Reply-To: <20220209122956.GI49147@ziepe.ca>
On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote:
> It is nice, but the other series are still impacted by the fsdax mess
> - they still stuff pages into ptes without proper refcounts and have
> to carry nonsense to dance around this problem.
>
> I certainly would be unhappy if the amd driver, for instance, gained
> the fsdax problem as well and started pushing 4k pages into PMDs.
As said before: I think this all needs to be fixed. But I'd rather
fix it gradually and I think this series is a nice step forward.
After that we can look at the pte mappings.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Linux NVDIMM" <nvdimm@lists.linux.dev>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Karol Herbst" <kherbst@redhat.com>,
nouveau@lists.freedesktop.org,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>,
"Linux MM" <linux-mm@kvack.org>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount
Date: Wed, 9 Feb 2022 14:53:51 +0100 [thread overview]
Message-ID: <20220209135351.GA20631@lst.de> (raw)
In-Reply-To: <20220209122956.GI49147@ziepe.ca>
On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote:
> It is nice, but the other series are still impacted by the fsdax mess
> - they still stuff pages into ptes without proper refcounts and have
> to carry nonsense to dance around this problem.
>
> I certainly would be unhappy if the amd driver, for instance, gained
> the fsdax problem as well and started pushing 4k pages into PMDs.
As said before: I think this all needs to be fixed. But I'd rather
fix it gradually and I think this series is a nice step forward.
After that we can look at the pte mappings.
next prev parent reply other threads:[~2022-02-09 13:54 UTC|newest]
Thread overview: 141+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 6:32 start sorting out the ZONE_DEVICE refcount mess Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 6:32 ` [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 18:08 ` Dan Williams
2022-02-07 18:08 ` Dan Williams
2022-02-07 18:08 ` [Nouveau] " Dan Williams
2022-02-07 19:22 ` Jason Gunthorpe
2022-02-07 19:22 ` Jason Gunthorpe
2022-02-07 19:22 ` [Nouveau] " Jason Gunthorpe
2022-02-08 7:17 ` Chaitanya Kulkarni
2022-02-08 7:17 ` [Nouveau] " Chaitanya Kulkarni
2022-02-08 7:17 ` Chaitanya Kulkarni
2022-02-08 8:06 ` Muchun Song
2022-02-08 8:06 ` [Nouveau] " Muchun Song
2022-02-08 8:06 ` Muchun Song
2022-02-07 6:32 ` [PATCH 2/8] mm: remove the __KERNEL__ guard from <linux/mm.h> Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 18:08 ` Dan Williams
2022-02-07 18:08 ` Dan Williams
2022-02-07 18:08 ` [Nouveau] " Dan Williams
2022-02-07 19:26 ` Jason Gunthorpe
2022-02-07 19:26 ` [Nouveau] " Jason Gunthorpe
2022-02-07 19:26 ` Jason Gunthorpe
2022-02-08 7:21 ` Chaitanya Kulkarni
2022-02-08 7:21 ` [Nouveau] " Chaitanya Kulkarni
2022-02-08 7:21 ` Chaitanya Kulkarni
2022-02-08 8:07 ` Muchun Song
2022-02-08 8:07 ` [Nouveau] " Muchun Song
2022-02-08 8:07 ` Muchun Song
2022-02-07 6:32 ` [PATCH 3/8] mm: remove pointless includes from <linux/hmm.h> Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 14:01 ` Jason Gunthorpe
2022-02-07 14:01 ` Jason Gunthorpe
2022-02-07 14:01 ` [Nouveau] " Jason Gunthorpe
2022-02-08 7:27 ` Chaitanya Kulkarni
2022-02-08 7:27 ` [Nouveau] " Chaitanya Kulkarni
2022-02-08 7:27 ` Chaitanya Kulkarni
2022-02-07 6:32 ` [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 19:06 ` Dan Williams
2022-02-07 19:06 ` Dan Williams
2022-02-07 19:06 ` [Nouveau] " Dan Williams
2022-02-07 19:27 ` Jason Gunthorpe
2022-02-07 19:27 ` Jason Gunthorpe
2022-02-07 19:27 ` [Nouveau] " Jason Gunthorpe
2022-02-08 7:34 ` Chaitanya Kulkarni
2022-02-08 7:34 ` [Nouveau] " Chaitanya Kulkarni
2022-02-08 7:34 ` Chaitanya Kulkarni
2022-02-08 8:09 ` Muchun Song
2022-02-08 8:09 ` [Nouveau] " Muchun Song
2022-02-08 8:09 ` Muchun Song
2022-02-07 6:32 ` [PATCH 5/8] mm: simplify freeing of devmap managed pages Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 19:34 ` Jason Gunthorpe
2022-02-07 19:34 ` Jason Gunthorpe
2022-02-07 19:34 ` [Nouveau] " Jason Gunthorpe
2022-02-07 23:42 ` Dan Williams
2022-02-07 23:42 ` Dan Williams
2022-02-07 23:42 ` [Nouveau] " Dan Williams
2022-02-08 7:50 ` Chaitanya Kulkarni
2022-02-08 7:50 ` [Nouveau] " Chaitanya Kulkarni
2022-02-08 7:50 ` Chaitanya Kulkarni
2022-02-07 6:32 ` [PATCH 6/8] mm: don't include <linux/memremap.h> in <linux/mm.h> Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 17:38 ` Logan Gunthorpe
2022-02-07 17:38 ` Logan Gunthorpe
2022-02-07 17:38 ` [Nouveau] " Logan Gunthorpe
2022-02-07 19:35 ` Jason Gunthorpe
2022-02-07 19:35 ` Jason Gunthorpe
2022-02-07 19:35 ` [Nouveau] " Jason Gunthorpe
2022-02-07 21:19 ` Felix Kuehling
2022-02-07 21:19 ` Felix Kuehling
2022-02-07 21:19 ` [Nouveau] " Felix Kuehling
2022-02-08 6:46 ` Christoph Hellwig
2022-02-08 6:46 ` Christoph Hellwig
2022-02-08 6:46 ` [Nouveau] " Christoph Hellwig
2022-02-09 17:48 ` Christoph Hellwig
2022-02-09 17:48 ` Christoph Hellwig
2022-02-09 17:48 ` [Nouveau] " Christoph Hellwig
2022-02-10 2:10 ` Alistair Popple
2022-02-10 2:10 ` Alistair Popple
2022-02-10 2:10 ` [Nouveau] " Alistair Popple
2022-02-10 6:45 ` Christoph Hellwig
2022-02-10 6:45 ` Christoph Hellwig
2022-02-10 6:45 ` [Nouveau] " Christoph Hellwig
2022-02-10 21:00 ` Felix Kuehling
2022-02-10 21:00 ` Felix Kuehling
2022-02-10 21:00 ` [Nouveau] " Felix Kuehling
2022-02-07 23:49 ` Dan Williams
2022-02-07 23:49 ` Dan Williams
2022-02-07 23:49 ` [Nouveau] " Dan Williams
2022-02-08 23:53 ` Dan Williams
2022-02-08 23:53 ` Dan Williams
2022-02-08 23:53 ` [Nouveau] " Dan Williams
2022-02-09 6:22 ` Christoph Hellwig
2022-02-09 6:22 ` Christoph Hellwig
2022-02-09 6:22 ` [Nouveau] " Christoph Hellwig
2022-02-07 6:32 ` [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 19:21 ` Jason Gunthorpe
2022-02-07 19:21 ` Jason Gunthorpe
2022-02-07 19:21 ` [Nouveau] " Jason Gunthorpe
2022-02-08 2:25 ` Ralph Campbell
2022-02-08 2:25 ` Ralph Campbell
2022-02-08 2:25 ` [Nouveau] " Ralph Campbell
2022-02-09 3:30 ` Dan Williams
2022-02-09 3:30 ` Dan Williams
2022-02-09 3:30 ` [Nouveau] " Dan Williams
2022-02-09 6:23 ` Christoph Hellwig
2022-02-09 6:23 ` Christoph Hellwig
2022-02-09 6:23 ` [Nouveau] " Christoph Hellwig
2022-02-09 12:29 ` Jason Gunthorpe
2022-02-09 12:29 ` [Nouveau] " Jason Gunthorpe
2022-02-09 12:29 ` Jason Gunthorpe
2022-02-09 13:53 ` Christoph Hellwig [this message]
2022-02-09 13:53 ` Christoph Hellwig
2022-02-09 13:53 ` [Nouveau] " Christoph Hellwig
2022-02-09 14:14 ` Jason Gunthorpe
2022-02-09 14:14 ` Jason Gunthorpe
2022-02-09 14:14 ` [Nouveau] " Jason Gunthorpe
2022-02-07 6:32 ` [PATCH 8/8] fsdax: depend on ZONE_DEVICE || FS_DAX_LIMITED Christoph Hellwig
2022-02-07 6:32 ` Christoph Hellwig
2022-02-07 6:32 ` [Nouveau] " Christoph Hellwig
2022-02-07 19:36 ` Jason Gunthorpe
2022-02-07 19:36 ` Jason Gunthorpe
2022-02-07 19:36 ` [Nouveau] " Jason Gunthorpe
2022-02-07 23:51 ` start sorting out the ZONE_DEVICE refcount mess Logan Gunthorpe
2022-02-07 23:51 ` Logan Gunthorpe
2022-02-07 23:51 ` [Nouveau] " Logan Gunthorpe
2022-02-08 3:03 ` Miaohe Lin
2022-02-08 3:03 ` [Nouveau] " Miaohe Lin
2022-02-08 3:03 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209135351.GA20631@lst.de \
--to=hch@lst.de \
--cc=Felix.Kuehling@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.