From: Jan Kara <jack@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Wu Fengguang <fengguang.wu@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, ceph-devel@vger.kernel.org,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"
Date: Thu, 10 Feb 2022 11:02:22 +0100 [thread overview]
Message-ID: <20220210100222.f2nmwwb5pcfmejvw@quack3.lan> (raw)
In-Reply-To: <164447147264.23354.2763356897218946255.stgit@noble.brown>
On Thu 10-02-22 16:37:52, NeilBrown wrote:
> bfq_get_queue() expects a "bool" for the third arg, so pass "false"
> rather than "BLK_RW_ASYNC" which will soon be removed.
>
> Acked-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: NeilBrown <neilb@suse.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 0c612a911696..4e645ae1e066 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5448,7 +5448,7 @@ static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
> bfqq = bic_to_bfqq(bic, false);
> if (bfqq) {
> bfq_release_process_ref(bfqd, bfqq);
> - bfqq = bfq_get_queue(bfqd, bio, BLK_RW_ASYNC, bic, true);
> + bfqq = bfq_get_queue(bfqd, bio, false, bic, true);
> bic_set_bfqq(bic, bfqq, false);
> }
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: Jan Kara <jack@suse.cz>,
linux-doc@vger.kernel.org, "Darrick J. Wong" <djwong@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
drbd-dev@lists.linbit.com,
Paolo Valente <paolo.valente@linaro.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
linux-nilfs@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
linux-nfs@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Layton <jlayton@kernel.org>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [f2fs-dev] [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"
Date: Thu, 10 Feb 2022 11:02:22 +0100 [thread overview]
Message-ID: <20220210100222.f2nmwwb5pcfmejvw@quack3.lan> (raw)
In-Reply-To: <164447147264.23354.2763356897218946255.stgit@noble.brown>
On Thu 10-02-22 16:37:52, NeilBrown wrote:
> bfq_get_queue() expects a "bool" for the third arg, so pass "false"
> rather than "BLK_RW_ASYNC" which will soon be removed.
>
> Acked-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: NeilBrown <neilb@suse.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 0c612a911696..4e645ae1e066 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5448,7 +5448,7 @@ static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
> bfqq = bic_to_bfqq(bic, false);
> if (bfqq) {
> bfq_release_process_ref(bfqd, bfqq);
> - bfqq = bfq_get_queue(bfqd, bio, BLK_RW_ASYNC, bic, true);
> + bfqq = bfq_get_queue(bfqd, bio, false, bic, true);
> bic_set_bfqq(bic, bfqq, false);
> }
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Wu Fengguang <fengguang.wu@intel.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lis
Subject: Re: [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"
Date: Thu, 10 Feb 2022 11:02:22 +0100 [thread overview]
Message-ID: <20220210100222.f2nmwwb5pcfmejvw@quack3.lan> (raw)
In-Reply-To: <164447147264.23354.2763356897218946255.stgit@noble.brown>
On Thu 10-02-22 16:37:52, NeilBrown wrote:
> bfq_get_queue() expects a "bool" for the third arg, so pass "false"
> rather than "BLK_RW_ASYNC" which will soon be removed.
>
> Acked-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: NeilBrown <neilb@suse.de>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 0c612a911696..4e645ae1e066 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5448,7 +5448,7 @@ static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
> bfqq = bic_to_bfqq(bic, false);
> if (bfqq) {
> bfq_release_process_ref(bfqd, bfqq);
> - bfqq = bfq_get_queue(bfqd, bio, BLK_RW_ASYNC, bic, true);
> + bfqq = bfq_get_queue(bfqd, bio, false, bic, true);
> bic_set_bfqq(bic, bfqq, false);
> }
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2022-02-10 10:02 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 5:37 [PATCH 00/11] Remove remaining parts of congestion tracking code NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 07/11] Remove inode_congested() NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC" NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 10:02 ` Jan Kara [this message]
2022-02-10 10:02 ` Jan Kara
2022-02-10 10:02 ` [f2fs-dev] " Jan Kara
2022-02-10 5:37 ` [PATCH 02/11] MM: document and polish read-ahead code NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 12:24 ` Jan Kara
2022-02-10 12:24 ` Jan Kara
2022-02-10 12:24 ` [f2fs-dev] " Jan Kara
2022-02-10 23:35 ` NeilBrown
2022-02-10 23:35 ` NeilBrown
2022-02-10 23:35 ` [f2fs-dev] " NeilBrown
2022-02-24 18:26 ` Jan Kara
2022-02-24 18:26 ` Jan Kara
2022-02-24 18:26 ` [f2fs-dev] " Jan Kara
2022-02-28 4:28 ` NeilBrown
2022-02-28 4:28 ` NeilBrown
2022-02-28 4:28 ` [f2fs-dev] " NeilBrown
2022-02-28 4:47 ` Andrew Morton
2022-02-28 4:47 ` Andrew Morton
2022-02-28 4:47 ` [f2fs-dev] " Andrew Morton
2022-02-28 5:19 ` NeilBrown
2022-02-28 5:19 ` NeilBrown
2022-02-28 5:19 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 05/11] nfs: remove reliance on bdi congestion NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 08/11] Remove bdi_congested() and wb_congested() and related functions NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-24 18:10 ` Ryusuke Konishi
2022-02-24 18:10 ` Ryusuke Konishi
2022-02-24 18:10 ` [f2fs-dev] " Ryusuke Konishi
2022-02-10 5:37 ` [PATCH 04/11] fuse: remove reliance on bdi congestion NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 06/11] ceph: " NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 03/11] MM: improve cleanup when ->readpages doesn't process all pages NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 09/11] f2fs: replace congestion_wait() calls with io_schedule_timeout() NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 01/11] DOC: convert 'subsection' to 'section' in gfp.h NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-10 5:37 ` [PATCH 11/11] Remove congestion tracking framework NeilBrown
2022-02-10 5:37 ` NeilBrown
2022-02-10 5:37 ` [f2fs-dev] " NeilBrown
2022-02-22 3:17 [PATCH 00/11] Remove remaining parts of congestion tracking code NeilBrown
2022-02-22 3:17 ` [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC" NeilBrown
2022-02-22 3:17 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210100222.f2nmwwb5pcfmejvw@quack3.lan \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=drbd-dev@lists.linbit.com \
--cc=fengguang.wu@intel.com \
--cc=idryomov@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=paolo.valente@linaro.org \
--cc=philipp.reisner@linbit.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.