From: Kees Cook <keescook@chromium.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Andrew Morton <akpm@linux-foundation.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 01/13] powerpc: Fix 'sparse' checking on PPC64le
Date: Tue, 15 Feb 2022 08:06:59 -0800 [thread overview]
Message-ID: <202202150806.66CC906@keescook> (raw)
In-Reply-To: <ac1312f2451aa558bb2a8806b4d0aa2020f0c176.1644928018.git.christophe.leroy@csgroup.eu>
On Tue, Feb 15, 2022 at 01:40:56PM +0100, Christophe Leroy wrote:
> 'sparse' is architecture agnostic and knows nothing about ELF ABI
> version.
>
> Just like it gets arch and powerpc type and endian from Makefile,
> it also need to get _CALL_ELF from there, otherwise it won't set
> PPC64_ELF_ABI_v2 macro for PPC64le and won't check the correct code.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-arch@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-parisc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Helge Deller <deller@gmx.de>,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-mm@kvack.org, Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 01/13] powerpc: Fix 'sparse' checking on PPC64le
Date: Tue, 15 Feb 2022 08:06:59 -0800 [thread overview]
Message-ID: <202202150806.66CC906@keescook> (raw)
In-Reply-To: <ac1312f2451aa558bb2a8806b4d0aa2020f0c176.1644928018.git.christophe.leroy@csgroup.eu>
On Tue, Feb 15, 2022 at 01:40:56PM +0100, Christophe Leroy wrote:
> 'sparse' is architecture agnostic and knows nothing about ELF ABI
> version.
>
> Just like it gets arch and powerpc type and endian from Makefile,
> it also need to get _CALL_ELF from there, otherwise it won't set
> PPC64_ELF_ABI_v2 macro for PPC64le and won't check the correct code.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Andrew Morton <akpm@linux-foundation.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 01/13] powerpc: Fix 'sparse' checking on PPC64le
Date: Tue, 15 Feb 2022 16:06:59 +0000 [thread overview]
Message-ID: <202202150806.66CC906@keescook> (raw)
In-Reply-To: <ac1312f2451aa558bb2a8806b4d0aa2020f0c176.1644928018.git.christophe.leroy@csgroup.eu>
On Tue, Feb 15, 2022 at 01:40:56PM +0100, Christophe Leroy wrote:
> 'sparse' is architecture agnostic and knows nothing about ELF ABI
> version.
>
> Just like it gets arch and powerpc type and endian from Makefile,
> it also need to get _CALL_ELF from there, otherwise it won't set
> PPC64_ELF_ABI_v2 macro for PPC64le and won't check the correct code.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-02-15 16:07 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 12:40 [PATCH v4 00/13] Fix LKDTM for PPC64/IA64/PARISC v4 Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` [PATCH v4 01/13] powerpc: Fix 'sparse' checking on PPC64le Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 16:06 ` Kees Cook [this message]
2022-02-15 16:06 ` Kees Cook
2022-02-15 16:06 ` Kees Cook
2022-02-15 12:40 ` [PATCH v4 02/13] powerpc: Move and rename func_descr_t Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` [PATCH v4 03/13] powerpc: Use 'struct func_desc' instead of 'struct ppc64_opd_entry' Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` [PATCH v4 04/13] powerpc: Remove " Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:40 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 05/13] powerpc: Prepare func_desc_t for refactorisation Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 06/13] ia64: Rename 'ip' to 'addr' in 'struct fdesc' Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 07/13] asm-generic: Define CONFIG_HAVE_FUNCTION_DESCRIPTORS Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 08/13] asm-generic: Define 'func_desc_t' to commonly describe function descriptors Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 09/13] asm-generic: Refactor dereference_[kernel]_function_descriptor() Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 10/13] lkdtm: Force do_nothing() out of line Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 11/13] lkdtm: Really write into kernel text in WRITE_KERN Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 12/13] lkdtm: Fix execute_[user]_location() Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` [PATCH v4 13/13] lkdtm: Add a test for function descriptors protection Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 12:41 ` Christophe Leroy
2022-02-15 16:07 ` [PATCH v4 00/13] Fix LKDTM for PPC64/IA64/PARISC v4 Kees Cook
2022-02-15 16:07 ` Kees Cook
2022-02-15 16:07 ` Kees Cook
2022-02-16 12:22 ` Michael Ellerman
2022-02-16 12:22 ` Michael Ellerman
2022-02-16 12:22 ` Michael Ellerman
2022-02-16 16:20 ` Kees Cook
2022-02-16 16:20 ` Kees Cook
2022-02-16 16:20 ` Kees Cook
2022-02-16 13:26 ` Helge Deller
2022-02-16 13:26 ` Helge Deller
2022-02-16 13:26 ` Helge Deller
2022-02-16 12:25 ` John Paul Adrian Glaubitz
2022-02-16 12:25 ` John Paul Adrian Glaubitz
2022-02-16 12:25 ` John Paul Adrian Glaubitz
2022-02-21 20:06 ` John Paul Adrian Glaubitz
2022-02-21 20:06 ` John Paul Adrian Glaubitz
2022-02-21 20:06 ` John Paul Adrian Glaubitz
2022-03-08 12:07 ` Michael Ellerman
2022-03-08 12:07 ` Michael Ellerman
2022-03-08 12:07 ` Michael Ellerman
2022-03-09 1:37 ` Michael Ellerman
2022-03-09 1:37 ` Michael Ellerman
2022-03-09 1:37 ` Michael Ellerman
2022-03-09 16:30 ` Kees Cook
2022-03-09 16:30 ` Kees Cook
2022-03-09 16:30 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202150806.66CC906@keescook \
--to=keescook@chromium.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.