From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Oleksij Rempel <linux@rempel-privat.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Petr Beneš" <petr.benes@ysoft.com>,
"Dominique Martinet" <dominique.martinet@atmark-techno.com>
Subject: [PATCH] thermal/drivers/imx: add missing pm_runtime_put on error path
Date: Thu, 17 Feb 2022 13:41:32 +0900 [thread overview]
Message-ID: <20220217044132.1980370-1-dominique.martinet@atmark-techno.com> (raw)
In-Reply-To: <20211117103426.81813-1-o.rempel@pengutronix.de>
We took a reference so need to put it back when imx_get_temp() returns
EAGAIN.
Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support")
Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
stumbled upon this merging our stable tree, but I don't actually use
imx-thermal so haven't tested it.
drivers/thermal/imx_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 16663373b682..641f90f9c750 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -265,6 +265,7 @@ static int imx_get_temp(struct thermal_zone_device *tz, int *temp)
if ((val & soc_data->temp_valid_mask) == 0) {
dev_dbg(&tz->device, "temp measurement never finished\n");
+ pm_runtime_put(data->dev);
return -EAGAIN;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: Oleksij Rempel <linux@rempel-privat.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Petr Beneš" <petr.benes@ysoft.com>,
"Dominique Martinet" <dominique.martinet@atmark-techno.com>
Subject: [PATCH] thermal/drivers/imx: add missing pm_runtime_put on error path
Date: Thu, 17 Feb 2022 13:41:32 +0900 [thread overview]
Message-ID: <20220217044132.1980370-1-dominique.martinet@atmark-techno.com> (raw)
In-Reply-To: <20211117103426.81813-1-o.rempel@pengutronix.de>
We took a reference so need to put it back when imx_get_temp() returns
EAGAIN.
Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support")
Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
stumbled upon this merging our stable tree, but I don't actually use
imx-thermal so haven't tested it.
drivers/thermal/imx_thermal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 16663373b682..641f90f9c750 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -265,6 +265,7 @@ static int imx_get_temp(struct thermal_zone_device *tz, int *temp)
if ((val & soc_data->temp_valid_mask) == 0) {
dev_dbg(&tz->device, "temp measurement never finished\n");
+ pm_runtime_put(data->dev);
return -EAGAIN;
}
--
2.34.1
next prev parent reply other threads:[~2022-02-17 4:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 10:34 [PATCH v3] thermal: imx: implement runtime PM support Oleksij Rempel
2021-11-17 10:34 ` Oleksij Rempel
2021-11-17 10:37 ` Oleksij Rempel
2021-11-17 10:37 ` Oleksij Rempel
2021-11-18 10:05 ` Petr Benes
2021-11-18 10:05 ` Petr Benes
2021-11-19 9:18 ` Petr Benes
2021-11-19 9:18 ` Petr Benes
2021-11-19 9:28 ` Daniel Lezcano
2021-11-19 9:28 ` Daniel Lezcano
2021-12-12 11:20 ` [thermal: thermal/next] thermal/drivers/imx: Implement " thermal-bot for Oleksij Rempel
2022-02-17 4:41 ` Dominique Martinet [this message]
2022-02-17 4:41 ` [PATCH] thermal/drivers/imx: add missing pm_runtime_put on error path Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217044132.1980370-1-dominique.martinet@atmark-techno.com \
--to=dominique.martinet@atmark-techno.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=petr.benes@ysoft.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.