All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk
Cc: ming.lei@redhat.com, hch@lst.de, dm-devel@redhat.com,
	linux-block@vger.kernel.org
Subject: [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset
Date: Wed, 23 Mar 2022 15:45:20 -0400	[thread overview]
Message-ID: <20220323194524.5900-1-snitzer@kernel.org> (raw)

Hi Jens,

I ran with your suggestion and DM now sees a ~7% improvement in hipri
bio polling with io_uring (using dm-linear on null_blk, IOPS went from
900K to 966K).

Christoph,

I tried to address your review of the previous set. Patch 1 and 2 can
obviously be folded but I left them split out for review purposes.
Feel free to see if these changes are meaningful for nvme's use.
Happy for either you to take on iterating on these block changes
further or you letting me know what changes you'd like made.

Thanks,
Mike

v2: add REQ_ALLOC_CACHE and move use of bio_alloc_percpu_cache to
    bio_alloc_bioset

Mike Snitzer (4):
  block: allow BIOSET_PERCPU_CACHE use from bio_alloc_clone
  block: allow BIOSET_PERCPU_CACHE use from bio_alloc_bioset
  dm: enable BIOSET_PERCPU_CACHE for dm_io bioset
  dm: conditionally enable BIOSET_PERCPU_CACHE for bio-based dm_io bioset

 block/bio.c               | 67 +++++++++++++++++++++++++++++++----------------
 block/blk.h               |  7 -----
 drivers/md/dm-table.c     | 11 +++++---
 drivers/md/dm.c           | 10 +++----
 drivers/md/dm.h           |  4 +--
 include/linux/bio.h       |  9 +++++++
 include/linux/blk_types.h |  4 ++-
 7 files changed, 71 insertions(+), 41 deletions(-)

-- 
2.15.0


WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, hch@lst.de,
	ming.lei@redhat.com
Subject: [dm-devel] [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset
Date: Wed, 23 Mar 2022 15:45:20 -0400	[thread overview]
Message-ID: <20220323194524.5900-1-snitzer@kernel.org> (raw)

Hi Jens,

I ran with your suggestion and DM now sees a ~7% improvement in hipri
bio polling with io_uring (using dm-linear on null_blk, IOPS went from
900K to 966K).

Christoph,

I tried to address your review of the previous set. Patch 1 and 2 can
obviously be folded but I left them split out for review purposes.
Feel free to see if these changes are meaningful for nvme's use.
Happy for either you to take on iterating on these block changes
further or you letting me know what changes you'd like made.

Thanks,
Mike

v2: add REQ_ALLOC_CACHE and move use of bio_alloc_percpu_cache to
    bio_alloc_bioset

Mike Snitzer (4):
  block: allow BIOSET_PERCPU_CACHE use from bio_alloc_clone
  block: allow BIOSET_PERCPU_CACHE use from bio_alloc_bioset
  dm: enable BIOSET_PERCPU_CACHE for dm_io bioset
  dm: conditionally enable BIOSET_PERCPU_CACHE for bio-based dm_io bioset

 block/bio.c               | 67 +++++++++++++++++++++++++++++++----------------
 block/blk.h               |  7 -----
 drivers/md/dm-table.c     | 11 +++++---
 drivers/md/dm.c           | 10 +++----
 drivers/md/dm.h           |  4 +--
 include/linux/bio.h       |  9 +++++++
 include/linux/blk_types.h |  4 ++-
 7 files changed, 71 insertions(+), 41 deletions(-)

-- 
2.15.0

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


             reply	other threads:[~2022-03-23 19:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 19:45 Mike Snitzer [this message]
2022-03-23 19:45 ` [dm-devel] [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset Mike Snitzer
2022-03-23 19:45 ` [PATCH v2 1/4] block: allow BIOSET_PERCPU_CACHE use from bio_alloc_clone Mike Snitzer
2022-03-23 19:45   ` [dm-devel] " Mike Snitzer
2022-03-23 19:45 ` [PATCH v2 2/4] block: allow BIOSET_PERCPU_CACHE use from bio_alloc_bioset Mike Snitzer
2022-03-23 19:45   ` [dm-devel] " Mike Snitzer
2022-03-23 19:45 ` [PATCH v2 3/4] dm: enable BIOSET_PERCPU_CACHE for dm_io bioset Mike Snitzer
2022-03-23 19:45   ` [dm-devel] " Mike Snitzer
2022-03-23 19:45 ` [PATCH v2 4/4] dm: conditionally enable BIOSET_PERCPU_CACHE for bio-based " Mike Snitzer
2022-03-23 19:45   ` [dm-devel] " Mike Snitzer
2022-03-24  0:25 ` [PATCH v2 0/4] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset Jens Axboe
2022-03-24  0:25   ` [dm-devel] " Jens Axboe
2022-03-24  7:39 ` Christoph Hellwig
2022-03-24  7:39   ` [dm-devel] " Christoph Hellwig
2022-03-24 14:41   ` Mike Snitzer
2022-03-24 14:41     ` [dm-devel] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323194524.5900-1-snitzer@kernel.org \
    --to=snitzer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.