From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@kernel.org>
Cc: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de,
dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers
Date: Fri, 25 Mar 2022 06:35:10 +0100 [thread overview]
Message-ID: <20220325053510.GA5327@lst.de> (raw)
In-Reply-To: <20220324203526.62306-3-snitzer@kernel.org>
On Thu, Mar 24, 2022 at 04:35:25PM -0400, Mike Snitzer wrote:
> Refine per-cpu bio alloc cache interfaces so that DM and other block
> drivers can properly create and use the cache:
>
> DM uses bioset_init_from_src() to do its final bioset initialization,
> so must update bioset_init_from_src() to set BIOSET_PERCPU_CACHE if
> %src bioset has a cache.
>
> Also move bio_clear_polled() to include/linux/bio.h to allow users
> outside of block core.
>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@kernel.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
dm-devel@redhat.com, hch@lst.de, ming.lei@redhat.com
Subject: Re: [dm-devel] [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers
Date: Fri, 25 Mar 2022 06:35:10 +0100 [thread overview]
Message-ID: <20220325053510.GA5327@lst.de> (raw)
In-Reply-To: <20220324203526.62306-3-snitzer@kernel.org>
On Thu, Mar 24, 2022 at 04:35:25PM -0400, Mike Snitzer wrote:
> Refine per-cpu bio alloc cache interfaces so that DM and other block
> drivers can properly create and use the cache:
>
> DM uses bioset_init_from_src() to do its final bioset initialization,
> so must update bioset_init_from_src() to set BIOSET_PERCPU_CACHE if
> %src bioset has a cache.
>
> Also move bio_clear_polled() to include/linux/bio.h to allow users
> outside of block core.
>
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-03-25 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 20:35 [PATCH v3 0/3] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset Mike Snitzer
2022-03-24 20:35 ` [dm-devel] " Mike Snitzer
2022-03-24 20:35 ` [PATCH v3 1/3] block: allow using the per-cpu bio cache " Mike Snitzer
2022-03-24 20:35 ` [dm-devel] " Mike Snitzer
2022-03-24 20:35 ` [PATCH v3 2/3] block: allow use of per-cpu bio alloc cache by block drivers Mike Snitzer
2022-03-24 20:35 ` [dm-devel] " Mike Snitzer
2022-03-25 5:35 ` Christoph Hellwig [this message]
2022-03-25 5:35 ` Christoph Hellwig
2022-03-24 20:35 ` [PATCH v3 3/3] dm: conditionally enable BIOSET_PERCPU_CACHE for dm_io bioset Mike Snitzer
2022-03-24 20:35 ` [dm-devel] " Mike Snitzer
2022-03-30 18:51 ` (subset) [PATCH v3 0/3] block/dm: use BIOSET_PERCPU_CACHE from bio_alloc_bioset Jens Axboe
2022-03-30 18:51 ` [dm-devel] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325053510.GA5327@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.