From: Dan Carpenter <dan.carpenter@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe
Date: Tue, 12 Apr 2022 07:19:36 +0300 [thread overview]
Message-ID: <20220412041936.GK12805@kadam> (raw)
In-Reply-To: <c7606920-b5c9-f8e3-3026-631a796c195a@samsung.com>
On Tue, Apr 12, 2022 at 10:01:20AM +0900, Inki Dae wrote:
> Hi Dan Carpenter.
>
> Same patch[1] was posted so I will pick it up.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg967488.html
>
It's not the same. That one returns -EINVAL and mine returns
-EPROBE_DEFER. I obvoiously thought that -EPROBE_DEFER was the correct
return but I wasn't positive. -EPROBE_DEFER is kind of a special
return so I think it matters to get this correct.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe
Date: Tue, 12 Apr 2022 07:19:36 +0300 [thread overview]
Message-ID: <20220412041936.GK12805@kadam> (raw)
In-Reply-To: <c7606920-b5c9-f8e3-3026-631a796c195a@samsung.com>
On Tue, Apr 12, 2022 at 10:01:20AM +0900, Inki Dae wrote:
> Hi Dan Carpenter.
>
> Same patch[1] was posted so I will pick it up.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg967488.html
>
It's not the same. That one returns -EINVAL and mine returns
-EPROBE_DEFER. I obvoiously thought that -EPROBE_DEFER was the correct
return but I wasn't positive. -EPROBE_DEFER is kind of a special
return so I think it matters to get this correct.
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-12 4:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220408102327epcas1p409b13bf2da7e19b0a24571ce50e3ea92@epcas1p4.samsung.com>
2022-04-08 10:21 ` [PATCH] drm/exynos: fix IS_ERR() vs NULL check in probe Dan Carpenter
2022-04-08 10:21 ` Dan Carpenter
2022-04-12 1:01 ` Inki Dae
2022-04-12 1:01 ` Inki Dae
2022-04-12 4:19 ` Dan Carpenter [this message]
2022-04-12 4:19 ` Dan Carpenter
2022-04-20 8:08 ` Inki Dae
2022-04-20 8:08 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412041936.GK12805@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=alim.akhtar@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jy0922.shim@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robert.foss@linaro.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.