From: Serge Semin <fancer.lancer@gmail.com> To: Brad Larson <brad@pensando.io> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Date: Tue, 12 Apr 2022 14:37:39 +0300 [thread overview] Message-ID: <20220412113739.xczqscungojcitrm@mobilestation> (raw) In-Reply-To: <20220406233648.21644-5-brad@pensando.io> > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC I think you need to be more specific in the patch title to what bindings you are adding the new compatible string. Something like this "dt-bindings: spi: cdns: ..." The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding". Otherwise it isn't clear to what schema you are adding the Elba SoC support to. -Sergey On Wed, Apr 06, 2022 at 04:36:41PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0a537fa3a641..bc298e413842 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -30,6 +30,7 @@ properties: > - intel,lgm-qspi > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -48,7 +49,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <fancer.lancer@gmail.com> To: Brad Larson <brad@pensando.io> Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, dac2@pensando.io, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Date: Tue, 12 Apr 2022 14:37:39 +0300 [thread overview] Message-ID: <20220412113739.xczqscungojcitrm@mobilestation> (raw) In-Reply-To: <20220406233648.21644-5-brad@pensando.io> > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC I think you need to be more specific in the patch title to what bindings you are adding the new compatible string. Something like this "dt-bindings: spi: cdns: ..." The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding". Otherwise it isn't clear to what schema you are adding the Elba SoC support to. -Sergey On Wed, Apr 06, 2022 at 04:36:41PM -0700, Brad Larson wrote: > Document the cadence qspi controller compatible for Pensando Elba SoC > boards. The Elba qspi fifo size is 1024. > > Signed-off-by: Brad Larson <brad@pensando.io> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 0a537fa3a641..bc298e413842 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -30,6 +30,7 @@ properties: > - intel,lgm-qspi > - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - pensando,elba-qspi > - const: cdns,qspi-nor > - const: cdns,qspi-nor > > @@ -48,7 +49,7 @@ properties: > description: > Size of the data FIFO in words. > $ref: "/schemas/types.yaml#/definitions/uint32" > - enum: [ 128, 256 ] > + enum: [ 128, 256, 1024 ] > default: 128 > > cdns,fifo-width: > -- > 2.17.1 >
next prev parent reply other threads:[~2022-04-12 11:48 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-06 23:36 [PATCH 00/11] Support Pensando Elba SoC Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-06 23:36 ` [PATCH 01/11] dt-bindings: arm: add Pensando boards Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 18:45 ` Krzysztof Kozlowski 2022-04-07 18:45 ` Krzysztof Kozlowski 2022-04-09 2:19 ` Brad Larson 2022-04-09 2:19 ` Brad Larson 2022-04-09 10:39 ` Krzysztof Kozlowski 2022-04-09 10:39 ` Krzysztof Kozlowski 2022-04-11 21:24 ` Serge Semin 2022-04-11 21:24 ` Serge Semin 2022-05-25 16:31 ` Brad Larson 2022-05-25 16:31 ` Brad Larson 2022-04-07 18:54 ` Krzysztof Kozlowski 2022-04-07 18:54 ` Krzysztof Kozlowski 2022-04-09 2:04 ` Brad Larson 2022-04-09 2:04 ` Brad Larson 2022-04-06 23:36 ` [PATCH 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 18:43 ` Krzysztof Kozlowski 2022-04-07 18:43 ` Krzysztof Kozlowski 2022-04-09 2:00 ` Brad Larson 2022-04-09 2:00 ` Brad Larson 2022-04-06 23:36 ` [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 6:30 ` Arnd Bergmann 2022-04-07 6:30 ` Arnd Bergmann 2022-05-25 15:46 ` Brad Larson 2022-05-25 15:46 ` Brad Larson 2022-04-07 18:57 ` Krzysztof Kozlowski 2022-04-07 18:57 ` Krzysztof Kozlowski 2022-05-25 15:49 ` Brad Larson 2022-05-25 15:49 ` Brad Larson 2022-04-06 23:36 ` [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 18:59 ` Krzysztof Kozlowski 2022-04-07 18:59 ` Krzysztof Kozlowski 2022-05-25 16:58 ` Brad Larson 2022-05-25 16:58 ` Brad Larson 2022-04-12 11:37 ` Serge Semin [this message] 2022-04-12 11:37 ` Serge Semin 2022-05-25 17:03 ` Brad Larson 2022-05-25 17:03 ` Brad Larson 2022-04-06 23:36 ` [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 18:52 ` Krzysztof Kozlowski 2022-04-07 18:52 ` Krzysztof Kozlowski 2022-04-11 21:17 ` Serge Semin 2022-04-11 21:17 ` Serge Semin 2022-05-26 0:27 ` Brad Larson 2022-05-26 0:27 ` Brad Larson 2022-04-12 11:29 ` Serge Semin 2022-04-12 11:29 ` Serge Semin 2022-04-06 23:36 ` [PATCH 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-06 23:36 ` [PATCH 07/11] arm64: Add config for Pensando SoC platforms Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-06 23:36 ` [PATCH 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-06 23:36 ` [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 6:45 ` Arnd Bergmann 2022-04-07 6:45 ` Arnd Bergmann 2022-04-07 7:13 ` Adrian Hunter 2022-04-07 7:13 ` Adrian Hunter 2022-04-07 17:06 ` Brad Larson 2022-04-07 17:06 ` Brad Larson 2022-04-07 20:38 ` Arnd Bergmann 2022-04-07 20:38 ` Arnd Bergmann 2022-05-25 16:10 ` Brad Larson 2022-05-25 16:10 ` Brad Larson 2022-04-06 23:36 ` [PATCH 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-12 11:06 ` Serge Semin 2022-04-12 11:06 ` Serge Semin 2022-05-25 21:54 ` Brad Larson 2022-05-25 21:54 ` Brad Larson 2022-04-06 23:36 ` [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson 2022-04-06 23:36 ` Brad Larson 2022-04-07 7:57 ` Marc Zyngier 2022-04-07 7:57 ` Marc Zyngier 2022-04-09 2:38 ` Brad Larson 2022-04-09 2:38 ` Brad Larson 2022-04-09 9:18 ` Marc Zyngier 2022-04-09 9:18 ` Marc Zyngier 2022-05-25 17:28 ` Brad Larson 2022-05-25 17:28 ` Brad Larson 2022-04-07 19:06 ` Krzysztof Kozlowski 2022-04-07 19:06 ` Krzysztof Kozlowski 2022-05-26 0:19 ` Brad Larson 2022-05-26 0:19 ` Brad Larson 2022-05-26 6:53 ` Krzysztof Kozlowski 2022-05-26 6:53 ` Krzysztof Kozlowski 2022-04-07 20:58 ` Krzysztof Kozlowski 2022-04-07 20:58 ` Krzysztof Kozlowski 2022-04-12 11:22 ` Serge Semin 2022-04-12 11:22 ` Serge Semin 2022-05-25 20:06 ` Brad Larson 2022-05-25 20:06 ` Brad Larson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220412113739.xczqscungojcitrm@mobilestation \ --to=fancer.lancer@gmail.com \ --cc=Sergey.Semin@baikalelectronics.ru \ --cc=adrian.hunter@intel.com \ --cc=arnd@arndb.de \ --cc=bgolaszewski@baylibre.com \ --cc=brad@pensando.io \ --cc=broonie@kernel.org \ --cc=dac2@pensando.io \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=olof@lixom.net \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.