From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Eric Biggers <ebiggers@google.com>
Cc: Mike Snitzer <snitzer@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ritesh Harjani <riteshh@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: fix blk_crypto_profile liftetime
Date: Wed, 20 Apr 2022 08:47:43 +0200 [thread overview]
Message-ID: <20220420064745.1119823-1-hch@lst.de> (raw)
Hi all,
the newly added blk-crypto sysfs support does not seem to keep the
blk_crypto_profile lifetimes aligned to what sysfs expects.
This was found by code inspection only and is completely untested.
Diffstat:
b/Documentation/block/inline-encryption.rst | 10 -
b/block/Makefile | 3
b/block/blk-crypto-fallback.c | 20 +-
b/block/blk-crypto-profile.c | 263 ++++++++++++++++++++++------
b/drivers/md/dm-table.c | 28 --
b/drivers/mmc/core/crypto.c | 4
b/drivers/mmc/host/cqhci-crypto.c | 16 -
b/drivers/scsi/ufs/ufshcd-crypto.c | 31 +--
b/drivers/scsi/ufs/ufshcd.h | 2
b/include/linux/blk-crypto-profile.h | 19 +-
b/include/linux/blkdev.h | 1
b/include/linux/mmc/host.h | 2
block/blk-crypto-sysfs.c | 172 ------------------
13 files changed, 265 insertions(+), 306 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>, Eric Biggers <ebiggers@google.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
Mike Snitzer <snitzer@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ritesh Harjani <riteshh@codeaurora.org>,
linux-block@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
dm-devel@redhat.com, Alim Akhtar <alim.akhtar@samsung.com>,
Asutosh Das <asutoshd@codeaurora.org>
Subject: [dm-devel] fix blk_crypto_profile liftetime
Date: Wed, 20 Apr 2022 08:47:43 +0200 [thread overview]
Message-ID: <20220420064745.1119823-1-hch@lst.de> (raw)
Hi all,
the newly added blk-crypto sysfs support does not seem to keep the
blk_crypto_profile lifetimes aligned to what sysfs expects.
This was found by code inspection only and is completely untested.
Diffstat:
b/Documentation/block/inline-encryption.rst | 10 -
b/block/Makefile | 3
b/block/blk-crypto-fallback.c | 20 +-
b/block/blk-crypto-profile.c | 263 ++++++++++++++++++++++------
b/drivers/md/dm-table.c | 28 --
b/drivers/mmc/core/crypto.c | 4
b/drivers/mmc/host/cqhci-crypto.c | 16 -
b/drivers/scsi/ufs/ufshcd-crypto.c | 31 +--
b/drivers/scsi/ufs/ufshcd.h | 2
b/include/linux/blk-crypto-profile.h | 19 +-
b/include/linux/blkdev.h | 1
b/include/linux/mmc/host.h | 2
block/blk-crypto-sysfs.c | 172 ------------------
13 files changed, 265 insertions(+), 306 deletions(-)
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next reply other threads:[~2022-04-20 6:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 6:47 Christoph Hellwig [this message]
2022-04-20 6:47 ` [dm-devel] fix blk_crypto_profile liftetime Christoph Hellwig
2022-04-20 6:47 ` [PATCH 1/2] blk-crypto: merge blk-crypto-sysfs.c into blk-crypto-profile.c Christoph Hellwig
2022-04-20 6:47 ` [dm-devel] " Christoph Hellwig
2022-04-20 6:47 ` [PATCH 2/2] blk-crypto: fix the blk_crypto_profile liftime Christoph Hellwig
2022-04-20 6:47 ` [dm-devel] " Christoph Hellwig
2022-04-20 9:49 ` Ulf Hansson
2022-04-20 9:49 ` [dm-devel] " Ulf Hansson
2022-04-20 19:41 ` Eric Biggers
2022-04-20 19:41 ` [dm-devel] " Eric Biggers
2022-04-21 14:25 ` Christoph Hellwig
2022-04-21 14:25 ` [dm-devel] " Christoph Hellwig
2022-04-22 6:27 ` Eric Biggers
2022-04-22 6:27 ` [dm-devel] " Eric Biggers
2022-04-21 14:40 ` Greg Kroah-Hartman
2022-04-21 14:40 ` [dm-devel] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420064745.1119823-1-hch@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=ebiggers@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=riteshh@codeaurora.org \
--cc=snitzer@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.