From: Nava kishore Manne <nava.manne@xilinx.com> To: <mdf@kernel.org>, <hao.wu@intel.com>, <yilun.xu@intel.com>, <trix@redhat.com>, <michal.simek@xilinx.com>, <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <git@xilinx.com> Cc: Nava kishore Manne <nava.manne@xilinx.com> Subject: [PATCH v5 1/5] fpga: zynq: Fix incorrect variable type Date: Thu, 21 Apr 2022 10:17:40 +0530 [thread overview] Message-ID: <20220421044744.3777983-2-nava.manne@xilinx.com> (raw) In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. Changes for v5: - Dropped the irrelevant doc update changes. drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..6beaba9dfe97 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) * the correct byte order, and be dword aligned. The input is a Xilinx .bin * file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Nava kishore Manne <nava.manne@xilinx.com> To: <mdf@kernel.org>, <hao.wu@intel.com>, <yilun.xu@intel.com>, <trix@redhat.com>, <michal.simek@xilinx.com>, <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <git@xilinx.com> Cc: Nava kishore Manne <nava.manne@xilinx.com> Subject: [PATCH v5 1/5] fpga: zynq: Fix incorrect variable type Date: Thu, 21 Apr 2022 10:17:40 +0530 [thread overview] Message-ID: <20220421044744.3777983-2-nava.manne@xilinx.com> (raw) In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. Changes for v5: - Dropped the irrelevant doc update changes. drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..6beaba9dfe97 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) * the correct byte order, and be dword aligned. The input is a Xilinx .bin * file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-21 4:48 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 4:47 [PATCH v5 0/5]fpga: fix for coding style and kernel-doc issues Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne [this message] 2022-04-21 4:47 ` [PATCH v5 1/5] fpga: zynq: Fix incorrect variable type Nava kishore Manne 2022-04-21 15:52 ` Xu Yilun 2022-04-21 15:52 ` Xu Yilun 2022-04-23 10:21 ` kernel test robot 2022-04-21 4:47 ` [PATCH v5 2/5] fpga: fix for coding style issues Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne 2022-04-21 15:34 ` Xu Yilun 2022-04-21 15:34 ` Xu Yilun 2022-04-22 3:38 ` Nava kishore Manne 2022-04-22 3:38 ` Nava kishore Manne 2022-04-21 4:47 ` [PATCH v5 3/5] fpga: fpga-mgr: fix kernel-doc warnings Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne 2022-04-21 4:47 ` [PATCH v5 4/5] fpga: Use tab instead of space indentation Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne 2022-04-21 4:47 ` [PATCH v5 5/5] fpga: fpga-region: fix kernel-doc formatting issues Nava kishore Manne 2022-04-21 4:47 ` Nava kishore Manne 2022-04-21 14:25 ` [PATCH v5 0/5]fpga: fix for coding style and kernel-doc issues Moritz Fischer 2022-04-21 14:25 ` Moritz Fischer 2022-04-21 15:55 ` Xu Yilun 2022-04-21 15:55 ` Xu Yilun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220421044744.3777983-2-nava.manne@xilinx.com \ --to=nava.manne@xilinx.com \ --cc=git@xilinx.com \ --cc=hao.wu@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=trix@redhat.com \ --cc=yilun.xu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.