All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anjelique Melendez <quic_amelende@quicinc.com>
To: <dmitry.torokhov@gmail.com>, <corbet@lwn.net>, <sre@kernel.org>,
	<robh+dt@kernel.org>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <bjorn.andersson@linaro.org>,
	<swboyd@chromium.org>, <linux-doc@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	David Collins <collinsd@codeaurora.org>,
	Anjelique Melendez <quic_amelende@quicinc.com>
Subject: [PATCH v6 5/5] input: misc: pm8941-pwrkey: simulate missed key press events
Date: Fri, 22 Apr 2022 12:12:43 -0700	[thread overview]
Message-ID: <20220422191239.6271-6-quic_amelende@quicinc.com> (raw)
In-Reply-To: <20220422191239.6271-1-quic_amelende@quicinc.com>

From: David Collins <collinsd@codeaurora.org>

The status of the keys connected to the KPDPWR_N and RESIN_N pins
is identified by reading corresponding bits in the interrupt real
time status register.  If the status has changed by the time that
the interrupt is handled then a press event will be missed.

Maintain a last known status variable to find unbalanced release
events and simulate press events for each accordingly.

Signed-off-by: David Collins <collinsd@codeaurora.org>
Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
---
 drivers/input/misc/pm8941-pwrkey.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/input/misc/pm8941-pwrkey.c b/drivers/input/misc/pm8941-pwrkey.c
index 881943ab4d55..3519152759dd 100644
--- a/drivers/input/misc/pm8941-pwrkey.c
+++ b/drivers/input/misc/pm8941-pwrkey.c
@@ -76,6 +76,7 @@ struct pm8941_pwrkey {
 	u32 code;
 	u32 sw_debounce_time_us;
 	ktime_t sw_debounce_end_time;
+	bool last_status;
 	const struct pm8941_data *data;
 };
 
@@ -162,6 +163,16 @@ static irqreturn_t pm8941_pwrkey_irq(int irq, void *_data)
 		pwrkey->sw_debounce_end_time = ktime_add_us(ktime_get(),
 						pwrkey->sw_debounce_time_us);
 
+	/*
+	 * Simulate a press event in case a release event occurred without a
+	 * corresponding press event.
+	 */
+	if (!pwrkey->last_status && !sts) {
+		input_report_key(pwrkey->input, pwrkey->code, 1);
+		input_sync(pwrkey->input);
+	}
+	pwrkey->last_status = sts;
+
 	input_report_key(pwrkey->input, pwrkey->code, sts);
 	input_sync(pwrkey->input);
 
-- 
2.35.1


  parent reply	other threads:[~2022-04-22 22:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 19:12 [PATCH v6 0/5] Extend pm8941-pwrkey driver Anjelique Melendez
2022-04-22 19:12 ` [PATCH v6] dt-bindings: power: reset: qcom-pon: update "reg" property details Anjelique Melendez
2022-04-25 21:45   ` Rob Herring
2022-05-19 22:30     ` Anjelique Melendez
2022-04-22 19:12 ` [PATCH v6 2/5] input: misc: pm8941-pwrkey: fix error message Anjelique Melendez
2022-04-25  4:07   ` Dmitry Torokhov
2022-04-22 19:12 ` [PATCH v6 3/5] input: misc: pm8941-pwrkey: add support for PON GEN3 base addresses Anjelique Melendez
2022-04-25  4:07   ` Dmitry Torokhov
2022-04-22 19:12 ` [PATCH v6 4/5] input: misc: pm8941-pwrkey: add software key press debouncing support Anjelique Melendez
2022-04-25  4:07   ` Dmitry Torokhov
2022-04-22 19:12 ` Anjelique Melendez [this message]
2022-04-25  4:07   ` [PATCH v6 5/5] input: misc: pm8941-pwrkey: simulate missed key press events Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422191239.6271-6-quic_amelende@quicinc.com \
    --to=quic_amelende@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.