Re: [PATCH v6] dt-bindings: power: reset: qcom-pon: update "reg" property details

From: Rob Herring <robh@kernel.org>
To: Anjelique Melendez <quic_amelende@quicinc.com>
Cc: dmitry.torokhov@gmail.com, corbet@lwn.net, sre@kernel.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
	swboyd@chromium.org, linux-doc@vger.kernel.org,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	David Collins <collinsd@quicinc.com>,
	David Collins <quic_collinsd@quicinc.com>
Subject: Re: [PATCH v6] dt-bindings: power: reset: qcom-pon: update "reg" property details
Date: Mon, 25 Apr 2022 16:45:08 -0500	[thread overview]
Message-ID: <YmcWZLp2X8UYOVas@robh.at.kernel.org> (raw)
In-Reply-To: <20220422191239.6271-2-quic_amelende@quicinc.com>

On Fri, Apr 22, 2022 at 12:12:38PM -0700, Anjelique Melendez wrote:
> From: David Collins <collinsd@quicinc.com>
> 
> Update the description of "reg" property to add the PON_PBS base
> address along with PON_HLOS base address.  Also add "reg-names"
> property description.
> 
> Signed-off-by: David Collins <quic_collinsd@quicinc.com>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
> ---
>  .../bindings/power/reset/qcom,pon.yaml | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 353f155d..65ec8197 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -26,7 +26,24 @@ properties:
>        - qcom,pm8998-pon
>  
>    reg:
> -    maxItems: 1
> +    description: |
> +      Specifies the SPMI base address for the PON (power-on) peripheral.  For
> +      PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS
> +      (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS
> +      peripherals.  In that case, the PON_PBS address needs to be specified to
> +      facilitate software debouncing on some PMICs.
> +    minItems: 1
> +    maxItems: 2
> +
> +  reg-names:
> +    description: |
> +      For PON GEN1 and GEN2, it should be "pon".  For PON GEN3 it should include
> +      "pon_hlos" and optionally "pon_pbs".
> +    minItems: 1
> +    items:
> +      - const: pon_hlos
> +      - const: pon_pbs
> +      - const: pon

Did you test that 'reg-names = "pon";' works? It doesn't. The schema 
says 'pon' is the 3rd entry in reg-names.

As 'reg-names' is new I thin this should be:

items:
  - const: hlos
  - const: pbs

And if there's 1 entry, then 'reg-names' should not be there.

Rob