From: Vladimir Oltean <olteanv@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}
Date: Wed, 4 May 2022 18:21:02 +0300 [thread overview]
Message-ID: <20220504152102.cj3fwae5anahthku@skbuf> (raw)
In-Reply-To: <20220430130347.15190-2-linux@fw-web.de>
On Sat, Apr 30, 2022 at 03:03:44PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Rework vlan_add/vlan_del functions in preparation for dynamic cpu port.
>
> Currently BIT(MT7530_CPU_PORT) is added to new_members, even though
> mt7530_port_vlan_add() will be called on the CPU port too.
>
> Let DSA core decide when to call port_vlan_add for the CPU port, rather
> than doing it implicitly.
>
> We can do autonomous forwarding in a certain VLAN, but not add br0 to that
> VLAN and avoid flooding the CPU with those packets, if software knows it
> doesn't need to process them.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}
Date: Wed, 4 May 2022 18:21:02 +0300 [thread overview]
Message-ID: <20220504152102.cj3fwae5anahthku@skbuf> (raw)
In-Reply-To: <20220430130347.15190-2-linux@fw-web.de>
On Sat, Apr 30, 2022 at 03:03:44PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Rework vlan_add/vlan_del functions in preparation for dynamic cpu port.
>
> Currently BIT(MT7530_CPU_PORT) is added to new_members, even though
> mt7530_port_vlan_add() will be called on the CPU port too.
>
> Let DSA core decide when to call port_vlan_add for the CPU port, rather
> than doing it implicitly.
>
> We can do autonomous forwarding in a certain VLAN, but not add br0 to that
> VLAN and avoid flooding the CPU with those packets, if software knows it
> doesn't need to process them.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
Landen Chao <Landen.Chao@mediatek.com>,
Florian Fainelli <f.fainelli@gmail.com>,
DENG Qingfang <dqfext@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}
Date: Wed, 4 May 2022 18:21:02 +0300 [thread overview]
Message-ID: <20220504152102.cj3fwae5anahthku@skbuf> (raw)
In-Reply-To: <20220430130347.15190-2-linux@fw-web.de>
On Sat, Apr 30, 2022 at 03:03:44PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Rework vlan_add/vlan_del functions in preparation for dynamic cpu port.
>
> Currently BIT(MT7530_CPU_PORT) is added to new_members, even though
> mt7530_port_vlan_add() will be called on the CPU port too.
>
> Let DSA core decide when to call port_vlan_add for the CPU port, rather
> than doing it implicitly.
>
> We can do autonomous forwarding in a certain VLAN, but not add br0 to that
> VLAN and avoid flooding the CPU with those packets, if software knows it
> doesn't need to process them.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Frank Wunderlich <frank-w@public-files.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del}
Date: Wed, 4 May 2022 18:21:02 +0300 [thread overview]
Message-ID: <20220504152102.cj3fwae5anahthku@skbuf> (raw)
In-Reply-To: <20220430130347.15190-2-linux@fw-web.de>
On Sat, Apr 30, 2022 at 03:03:44PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Rework vlan_add/vlan_del functions in preparation for dynamic cpu port.
>
> Currently BIT(MT7530_CPU_PORT) is added to new_members, even though
> mt7530_port_vlan_add() will be called on the CPU port too.
>
> Let DSA core decide when to call port_vlan_add for the CPU port, rather
> than doing it implicitly.
>
> We can do autonomous forwarding in a certain VLAN, but not add br0 to that
> VLAN and avoid flooding the CPU with those packets, if software knows it
> doesn't need to process them.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-04 15:21 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 13:03 [RFC v2 0/4] Support mt7531 on BPI-R2 Pro Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` [RFC v2 1/4] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-05-04 15:21 ` Vladimir Oltean [this message]
2022-05-04 15:21 ` Vladimir Oltean
2022-05-04 15:21 ` Vladimir Oltean
2022-05-04 15:21 ` Vladimir Oltean
2022-04-30 13:03 ` [RFC v2 2/4] net: dsa: mt7530: rework mt753[01]_setup Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-05-04 15:21 ` Vladimir Oltean
2022-05-04 15:21 ` Vladimir Oltean
2022-05-04 15:21 ` Vladimir Oltean
2022-05-04 15:21 ` Vladimir Oltean
2022-04-30 13:03 ` [RFC v2 3/4] net: dsa: mt7530: get cpu-port via dp->cpu_dp instead of constant Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-05-04 15:22 ` Vladimir Oltean
2022-05-04 15:22 ` Vladimir Oltean
2022-05-04 15:22 ` Vladimir Oltean
2022-05-04 15:22 ` Vladimir Oltean
2022-04-30 13:03 ` [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 13:03 ` Frank Wunderlich
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:17 ` Frank Wunderlich
2022-04-30 14:17 ` Frank Wunderlich
2022-04-30 14:17 ` Frank Wunderlich
2022-04-30 14:17 ` Frank Wunderlich
2022-05-04 15:24 ` Vladimir Oltean
2022-05-04 15:24 ` Vladimir Oltean
2022-05-04 15:24 ` Vladimir Oltean
2022-05-04 15:24 ` Vladimir Oltean
2022-05-04 15:33 ` Aw: " Frank Wunderlich
2022-05-04 15:33 ` Frank Wunderlich
2022-05-04 15:33 ` Frank Wunderlich
2022-05-04 15:33 ` Frank Wunderlich
2022-05-04 15:47 ` Vladimir Oltean
2022-05-04 15:47 ` Vladimir Oltean
2022-05-04 15:47 ` Vladimir Oltean
2022-05-04 15:47 ` Vladimir Oltean
2022-05-05 8:46 ` Krzysztof Kozlowski
2022-05-05 8:46 ` Krzysztof Kozlowski
2022-05-05 8:46 ` Krzysztof Kozlowski
2022-05-05 8:46 ` Krzysztof Kozlowski
2022-05-05 9:06 ` Frank Wunderlich
2022-05-05 9:06 ` Frank Wunderlich
2022-05-05 9:06 ` Frank Wunderlich
2022-05-05 9:06 ` Frank Wunderlich
2022-05-05 9:22 ` Krzysztof Kozlowski
2022-05-05 9:22 ` Krzysztof Kozlowski
2022-05-05 9:22 ` Krzysztof Kozlowski
2022-05-05 9:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504152102.cj3fwae5anahthku@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.