From: Andrew Morton <akpm@linux-foundation.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: mike.kravetz@oracle.com, catalin.marinas@arm.com,
will@kernel.org, songmuchun@bytedance.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.osdn.me, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating
Date: Mon, 9 May 2022 21:04:04 -0700 [thread overview]
Message-ID: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org> (raw)
In-Reply-To: <cover.1652147571.git.baolin.wang@linux.alibaba.com>
On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
> Hi,
>
> Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll
> use ptep_clear_flush() and set_pte_at() to nuke the page table entry
> and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb
> page,
It would be helpful to describe why it's wrong. Something like "should
use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this
purpose"?
> which will cause potential data consistent issue. This patch set
> will change to use hugetlb related APIs to fix this issue, please find
> details in each patch. Thanks.
Is a cc:stable needed here? And are we able to identify a target for a
Fixes: tag?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: dalias@libc.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, linux-mips@vger.kernel.org,
James.Bottomley@HansenPartnership.com, linux-mm@kvack.org,
paulus@samba.org, sparclinux@vger.kernel.org,
agordeev@linux.ibm.com, will@kernel.org,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
gor@linux.ibm.com, deller@gmx.de, ysato@users.osdn.me,
catalin.marinas@arm.com, borntraeger@linux.ibm.com,
arnd@arndb.de, hca@linux.ibm.com, songmuchun@bytedance.com,
linux-arm-kernel@lists.infradead.org, tsbogend@alpha.franken.de,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
svens@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net, mike.kravetz@oracle.com
Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating
Date: Mon, 9 May 2022 21:04:04 -0700 [thread overview]
Message-ID: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org> (raw)
In-Reply-To: <cover.1652147571.git.baolin.wang@linux.alibaba.com>
On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
> Hi,
>
> Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll
> use ptep_clear_flush() and set_pte_at() to nuke the page table entry
> and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb
> page,
It would be helpful to describe why it's wrong. Something like "should
use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this
purpose"?
> which will cause potential data consistent issue. This patch set
> will change to use hugetlb related APIs to fix this issue, please find
> details in each patch. Thanks.
Is a cc:stable needed here? And are we able to identify a target for a
Fixes: tag?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: mike.kravetz@oracle.com, catalin.marinas@arm.com,
will@kernel.org, songmuchun@bytedance.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.osdn.me, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating
Date: Mon, 9 May 2022 21:04:04 -0700 [thread overview]
Message-ID: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org> (raw)
In-Reply-To: <cover.1652147571.git.baolin.wang@linux.alibaba.com>
On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
> Hi,
>
> Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll
> use ptep_clear_flush() and set_pte_at() to nuke the page table entry
> and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb
> page,
It would be helpful to describe why it's wrong. Something like "should
use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this
purpose"?
> which will cause potential data consistent issue. This patch set
> will change to use hugetlb related APIs to fix this issue, please find
> details in each patch. Thanks.
Is a cc:stable needed here? And are we able to identify a target for a
Fixes: tag?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: mike.kravetz@oracle.com, catalin.marinas@arm.com,
will@kernel.org, songmuchun@bytedance.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.osdn.me, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating
Date: Tue, 10 May 2022 04:04:04 +0000 [thread overview]
Message-ID: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org> (raw)
In-Reply-To: <cover.1652147571.git.baolin.wang@linux.alibaba.com>
On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
> Hi,
>
> Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll
> use ptep_clear_flush() and set_pte_at() to nuke the page table entry
> and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb
> page,
It would be helpful to describe why it's wrong. Something like "should
use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this
purpose"?
> which will cause potential data consistent issue. This patch set
> will change to use hugetlb related APIs to fix this issue, please find
> details in each patch. Thanks.
Is a cc:stable needed here? And are we able to identify a target for a
Fixes: tag?
next prev parent reply other threads:[~2022-05-10 4:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:45 [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` [PATCH v3 1/3] mm: change huge_ptep_clear_flush() to return the original pte Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` [PATCH v3 2/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when migration Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 3:45 ` Baolin Wang
2022-05-10 23:17 ` Andrew Morton
2022-05-10 23:17 ` Andrew Morton
2022-05-10 23:17 ` Andrew Morton
2022-05-10 23:17 ` Andrew Morton
2022-05-10 23:28 ` Andrew Morton
2022-05-10 23:28 ` Andrew Morton
2022-05-10 23:28 ` Andrew Morton
2022-05-11 3:59 ` Baolin Wang
2022-05-11 3:59 ` Baolin Wang
2022-05-11 3:59 ` Baolin Wang
2022-05-11 1:19 ` kernel test robot
2022-05-11 1:19 ` kernel test robot
2022-05-11 1:19 ` kernel test robot
2022-05-11 1:19 ` kernel test robot
2022-05-11 2:04 ` Andrew Morton
2022-05-11 2:04 ` Andrew Morton
2022-05-11 2:04 ` Andrew Morton
2022-05-11 2:04 ` Andrew Morton
2022-05-11 2:04 ` Andrew Morton
2022-05-10 3:46 ` [PATCH v3 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping Baolin Wang
2022-05-10 3:46 ` Baolin Wang
2022-05-10 3:46 ` Baolin Wang
2022-05-10 3:46 ` Baolin Wang
2022-05-10 4:04 ` Andrew Morton [this message]
2022-05-10 4:04 ` [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Andrew Morton
2022-05-10 4:04 ` Andrew Morton
2022-05-10 4:04 ` Andrew Morton
2022-05-10 4:26 ` Baolin Wang
2022-05-10 4:26 ` Baolin Wang
2022-05-10 4:26 ` Baolin Wang
2022-05-10 4:26 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=songmuchun@bytedance.com \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=ysato@users.osdn.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.