From: David Vernet <void@manifault.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org,
hannes@cmpxchg.org, kernel-team@fb.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com,
tj@kernel.org, Richard Palethorpe <rpalethorpe@suse.de>
Subject: Re: [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling
Date: Fri, 13 May 2022 10:42:11 -0700 [thread overview]
Message-ID: <20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <20220513171811.730-3-mkoutny@suse.com>
On Fri, May 13, 2022 at 07:18:09PM +0200, Michal Koutný wrote:
> This is effectively a revert of commit cdc69458a5f3 ("cgroup: account
> for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low
> will fail with memory_recursiveprot until resolved in reclaim
> code.
> However, this patch preserves the existing helpers and variables for
> later uses.
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
> ---
> tools/testing/selftests/cgroup/test_memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
> index 4958b42201a9..eba252fa64ac 100644
> --- a/tools/testing/selftests/cgroup/test_memcontrol.c
> +++ b/tools/testing/selftests/cgroup/test_memcontrol.c
> @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root)
> }
>
> for (i = 0; i < ARRAY_SIZE(children); i++) {
> - int no_low_events_index = has_recursiveprot ? 2 : 1;
> + int no_low_events_index = 1;
>
> oom = cg_read_key_long(children[i], "memory.events", "oom ");
> low = cg_read_key_long(children[i], "memory.events", "low ");
> --
> 2.35.3
>
Reviewed-by: David Vernet <void@manifault.com>
WARNING: multiple messages have this Message-ID (diff)
From: David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
To: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Richard Palethorpe <rpalethorpe-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling
Date: Fri, 13 May 2022 10:42:11 -0700 [thread overview]
Message-ID: <20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <20220513171811.730-3-mkoutny-IBi9RG/b67k@public.gmane.org>
On Fri, May 13, 2022 at 07:18:09PM +0200, Michal Koutný wrote:
> This is effectively a revert of commit cdc69458a5f3 ("cgroup: account
> for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low
> will fail with memory_recursiveprot until resolved in reclaim
> code.
> However, this patch preserves the existing helpers and variables for
> later uses.
>
> Signed-off-by: Michal Koutný <mkoutny-IBi9RG/b67k@public.gmane.org>
> ---
> tools/testing/selftests/cgroup/test_memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c
> index 4958b42201a9..eba252fa64ac 100644
> --- a/tools/testing/selftests/cgroup/test_memcontrol.c
> +++ b/tools/testing/selftests/cgroup/test_memcontrol.c
> @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root)
> }
>
> for (i = 0; i < ARRAY_SIZE(children); i++) {
> - int no_low_events_index = has_recursiveprot ? 2 : 1;
> + int no_low_events_index = 1;
>
> oom = cg_read_key_long(children[i], "memory.events", "oom ");
> low = cg_read_key_long(children[i], "memory.events", "low ");
> --
> 2.35.3
>
Reviewed-by: David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org>
next prev parent reply other threads:[~2022-05-13 17:42 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 15:56 [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests David Vernet
2022-04-23 15:56 ` David Vernet
2022-04-23 15:56 ` [PATCH v2 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
2022-04-26 1:56 ` Roman Gushchin
2022-04-26 1:56 ` Roman Gushchin
2022-04-23 15:56 ` [PATCH v2 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
2022-04-23 15:56 ` David Vernet
2022-04-27 14:09 ` Michal Koutný
2022-04-27 14:09 ` Michal Koutný
2022-04-29 1:03 ` David Vernet
2022-04-29 1:03 ` David Vernet
2022-04-29 9:26 ` Michal Koutný
2022-04-29 9:26 ` Michal Koutný
2022-05-06 16:40 ` David Vernet
2022-05-06 16:40 ` David Vernet
2022-05-09 15:09 ` Johannes Weiner
2022-05-09 15:09 ` Johannes Weiner
2022-05-10 0:44 ` Andrew Morton
2022-05-10 0:44 ` Andrew Morton
2022-05-10 17:43 ` Michal Koutný
2022-05-10 17:43 ` Michal Koutný
2022-05-11 17:53 ` Johannes Weiner
2022-05-11 17:53 ` Johannes Weiner
2022-05-12 17:27 ` Michal Koutný
2022-05-12 17:27 ` Michal Koutný
2022-04-23 15:56 ` [PATCH v2 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
2022-04-23 15:56 ` David Vernet
2022-04-23 15:56 ` [PATCH v2 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
2022-04-23 15:56 ` David Vernet
2022-04-23 15:56 ` [PATCH v2 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
2022-04-23 15:56 ` David Vernet
2022-05-12 17:04 ` [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Michal Koutný
2022-05-12 17:04 ` Michal Koutný
2022-05-12 17:30 ` David Vernet
2022-05-12 17:30 ` David Vernet
2022-05-12 17:44 ` David Vernet
2022-05-12 17:44 ` David Vernet
2022-05-13 17:18 ` [PATCH 0/4] memcontrol selftests fixups Michal Koutný
2022-05-13 17:18 ` Michal Koutný
2022-05-13 17:18 ` [PATCH 1/4] selftests: memcg: Fix compilation Michal Koutný
2022-05-13 17:18 ` Michal Koutný
2022-05-13 17:40 ` David Vernet
2022-05-13 17:40 ` David Vernet
2022-05-13 18:53 ` Roman Gushchin
2022-05-13 18:53 ` Roman Gushchin
2022-05-13 19:09 ` Roman Gushchin
2022-05-13 19:09 ` Roman Gushchin
2022-05-13 17:18 ` [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
2022-05-13 17:18 ` Michal Koutný
2022-05-13 17:42 ` David Vernet [this message]
2022-05-13 17:42 ` David Vernet
2022-05-13 18:54 ` Roman Gushchin
2022-05-18 15:54 ` Michal Koutný
2022-05-18 15:54 ` Michal Koutný
2022-05-13 17:18 ` [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný
2022-05-13 17:18 ` Michal Koutný
2022-05-13 18:52 ` Roman Gushchin
2022-05-13 18:52 ` Roman Gushchin
2022-05-13 17:18 ` [PATCH 4/4] selftests: memcg: Remove protection from top level memcg Michal Koutný
2022-05-13 17:18 ` Michal Koutný
2022-05-13 18:59 ` Roman Gushchin
2022-05-13 18:59 ` Roman Gushchin
2022-05-18 0:24 ` Andrew Morton
2022-05-18 0:24 ` Andrew Morton
2022-05-18 0:52 ` Roman Gushchin
2022-05-18 0:52 ` Roman Gushchin
2022-05-18 15:44 ` Michal Koutný
2022-05-18 15:44 ` Michal Koutný
2022-05-13 19:14 ` David Vernet
2022-05-13 19:14 ` David Vernet
2022-05-18 15:40 [PATCH 0/4] memcontrol selftests fixups Michal Koutný
2022-05-18 15:40 ` [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
2022-05-18 15:40 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com \
--to=void@manifault.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=rpalethorpe@suse.de \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.