From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: Jason Gunthorpe <jgg@nvidia.com> Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>, dmaengine@vger.kernel.org, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Lu Baolu <baolu.lu@linux.intel.com>, Christoph Hellwig <hch@infradead.org>, vkoul@kernel.org, robin.murphy@arm.com, will@kernel.org, Yi Liu <yi.l.liu@intel.com>, Dave Jiang <dave.jiang@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Eric Auger <eric.auger@redhat.com>, jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v4 1/6] iommu: Add a per domain PASID for DMA API Date: Tue, 24 May 2022 08:17:27 -0700 [thread overview] Message-ID: <20220524081727.19c2dd6d@jacob-builder> (raw) In-Reply-To: <20220524135034.GU1343366@nvidia.com> Hi Jason, On Tue, 24 May 2022 10:50:34 -0300, Jason Gunthorpe <jgg@nvidia.com> wrote: > On Wed, May 18, 2022 at 11:21:15AM -0700, Jacob Pan wrote: > > DMA requests tagged with PASID can target individual IOMMU domains. > > Introduce a domain-wide PASID for DMA API, it will be used on the same > > mapping as legacy DMA without PASID. Let it be IOVA or PA in case of > > identity domain. > > Huh? I can't understand what this is trying to say or why this patch > makes sense. > > We really should not have pasid's like this attached to the domains.. > This is the same "DMA API global PASID" you reviewed in v3, I just singled it out as a standalone patch and renamed it. Here is your previous review comment. > +++ b/include/linux/iommu.h > @@ -105,6 +105,8 @@ struct iommu_domain { > enum iommu_page_response_code (*iopf_handler)(struct iommu_fault *fault, > void *data); > void *fault_data; > + ioasid_t pasid; /* Used for DMA requests with PASID */ > + atomic_t pasid_users; These are poorly named, this is really the DMA API global PASID and shouldn't be used for other things. Perhaps I misunderstood, do you mind explaining more? Thanks, Jacob
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: Jason Gunthorpe <jgg@nvidia.com> Cc: vkoul@kernel.org, "Tian, Kevin" <kevin.tian@intel.com>, Dave Jiang <dave.jiang@intel.com>, Raj Ashok <ashok.raj@intel.com>, will@kernel.org, David Woodhouse <dwmw2@infradead.org>, LKML <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>, iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, robin.murphy@arm.com, Jean-Philippe Brucker <jean-philippe@linaro.com> Subject: Re: [PATCH v4 1/6] iommu: Add a per domain PASID for DMA API Date: Tue, 24 May 2022 08:17:27 -0700 [thread overview] Message-ID: <20220524081727.19c2dd6d@jacob-builder> (raw) In-Reply-To: <20220524135034.GU1343366@nvidia.com> Hi Jason, On Tue, 24 May 2022 10:50:34 -0300, Jason Gunthorpe <jgg@nvidia.com> wrote: > On Wed, May 18, 2022 at 11:21:15AM -0700, Jacob Pan wrote: > > DMA requests tagged with PASID can target individual IOMMU domains. > > Introduce a domain-wide PASID for DMA API, it will be used on the same > > mapping as legacy DMA without PASID. Let it be IOVA or PA in case of > > identity domain. > > Huh? I can't understand what this is trying to say or why this patch > makes sense. > > We really should not have pasid's like this attached to the domains.. > This is the same "DMA API global PASID" you reviewed in v3, I just singled it out as a standalone patch and renamed it. Here is your previous review comment. > +++ b/include/linux/iommu.h > @@ -105,6 +105,8 @@ struct iommu_domain { > enum iommu_page_response_code (*iopf_handler)(struct iommu_fault *fault, > void *data); > void *fault_data; > + ioasid_t pasid; /* Used for DMA requests with PASID */ > + atomic_t pasid_users; These are poorly named, this is really the DMA API global PASID and shouldn't be used for other things. Perhaps I misunderstood, do you mind explaining more? Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-24 15:13 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 18:21 [PATCH v4 0/6] Enable PASID for DMA API users Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-18 18:21 ` [PATCH v4 1/6] iommu: Add a per domain PASID for DMA API Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-19 6:50 ` Baolu Lu 2022-05-19 6:50 ` Baolu Lu 2022-05-24 13:50 ` Jason Gunthorpe 2022-05-24 13:50 ` Jason Gunthorpe via iommu 2022-05-24 15:17 ` Jacob Pan [this message] 2022-05-24 15:17 ` Jacob Pan 2022-05-30 12:22 ` Jason Gunthorpe 2022-05-30 12:22 ` Jason Gunthorpe via iommu 2022-05-31 10:12 ` Tian, Kevin 2022-05-31 10:12 ` Tian, Kevin 2022-05-31 12:45 ` Baolu Lu 2022-05-31 12:45 ` Baolu Lu 2022-05-31 16:03 ` Jason Gunthorpe 2022-05-31 16:03 ` Jason Gunthorpe via iommu 2022-05-31 17:29 ` Jacob Pan 2022-05-31 17:29 ` Jacob Pan 2022-05-31 19:05 ` Jason Gunthorpe 2022-05-31 19:05 ` Jason Gunthorpe via iommu 2022-05-31 20:44 ` Jacob Pan 2022-05-31 20:44 ` Jacob Pan 2022-06-01 1:50 ` Tian, Kevin 2022-06-01 1:50 ` Tian, Kevin 2022-06-01 1:43 ` Tian, Kevin 2022-06-01 1:43 ` Tian, Kevin 2022-06-01 9:37 ` Baolu Lu 2022-06-01 9:37 ` Baolu Lu 2022-06-01 10:05 ` Tian, Kevin 2022-06-01 10:05 ` Tian, Kevin 2022-05-18 18:21 ` [PATCH v4 2/6] iommu: Add a helper to do PASID lookup from domain Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-19 6:41 ` Baolu Lu 2022-05-19 6:41 ` Baolu Lu 2022-05-19 20:10 ` Jacob Pan 2022-05-19 20:10 ` Jacob Pan 2022-05-19 6:48 ` Christoph Hellwig 2022-05-19 6:48 ` Christoph Hellwig 2022-05-20 15:18 ` Jacob Pan 2022-05-20 15:18 ` Jacob Pan 2022-05-23 7:55 ` Tian, Kevin 2022-05-23 7:55 ` Tian, Kevin 2022-05-23 9:14 ` Tian, Kevin 2022-05-23 9:14 ` Tian, Kevin 2022-05-23 18:01 ` Jacob Pan 2022-05-23 18:01 ` Jacob Pan 2022-05-18 18:21 ` [PATCH v4 3/6] iommu/vt-d: Implement domain ops for attach_dev_pasid Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-24 13:51 ` Jason Gunthorpe 2022-05-24 13:51 ` Jason Gunthorpe via iommu 2022-05-24 16:12 ` Jacob Pan 2022-05-24 16:12 ` Jacob Pan 2022-05-24 18:02 ` Jason Gunthorpe 2022-05-24 18:02 ` Jason Gunthorpe via iommu 2022-05-24 20:45 ` Jacob Pan 2022-05-24 20:45 ` Jacob Pan 2022-05-24 21:10 ` Jason Gunthorpe 2022-05-24 21:10 ` Jason Gunthorpe via iommu 2022-05-18 18:21 ` [PATCH v4 4/6] iommu: Add PASID support for DMA mapping API users Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-23 8:25 ` Tian, Kevin 2022-05-23 8:25 ` Tian, Kevin 2022-05-23 15:23 ` Jacob Pan 2022-05-23 15:23 ` Jacob Pan 2022-05-18 18:21 ` [PATCH v4 5/6] dmaengine: idxd: Use DMA API for in-kernel DMA with PASID Jacob Pan 2022-05-18 18:21 ` Jacob Pan 2022-05-18 18:21 ` [PATCH v4 6/6] iommu/vt-d: Delete unused SVM flag Jacob Pan 2022-05-18 18:21 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220524081727.19c2dd6d@jacob-builder \ --to=jacob.jun.pan@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dave.jiang@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jean-philippe@linaro.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.