From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Ankit Kumar <ankit.kumar@samsung.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>,
"krish.reddy@samsung.com" <krish.reddy@samsung.com>,
"joshi.k@samsung.com" <joshi.k@samsung.com>,
"anuj20.g@samsung.com" <anuj20.g@samsung.com>
Subject: Re: [PATCH v3 7/9] zbd: Check for direct flag only if its block device
Date: Thu, 2 Jun 2022 00:55:22 +0000 [thread overview]
Message-ID: <20220602005521.p4q3x34ba7dekrfl@shindev> (raw)
In-Reply-To: <20220531133155.17493-8-ankit.kumar@samsung.com>
On May 31, 2022 / 19:01, Ankit Kumar wrote:
> nvme-ns generic character devices currently do not support O_DIRECT flag.
> Check for fio option for direct flag only if filetype is a block device.
>
> t/zbd skip test case #1 for character devices as they don't require
> direct I/O.
>
> Tested-by: Vincent Fu <vincent.fu@samsung.com>
> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Thank you for fixing up. Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
--
Shin'ichiro Kawasaki
next prev parent reply other threads:[~2022-06-02 0:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220531133739epcas5p31aa9479d49d5ae82a85b493bd0bb4e47@epcas5p3.samsung.com>
2022-05-31 13:31 ` [PATCH v3 0/9] Add support for uring passthrough commands Ankit Kumar
[not found] ` <CGME20220531133740epcas5p1e7c1049ef44fc7d25b78f239f035a29d@epcas5p1.samsung.com>
2022-05-31 13:31 ` [PATCH v3 1/9] io_uring.h: add IORING_SETUP_SQE128 and IORING_SETUP_CQE32 Ankit Kumar
[not found] ` <CGME20220531133741epcas5p16383da97824ffedd50f5e3231d09430e@epcas5p1.samsung.com>
2022-05-31 13:31 ` [PATCH v3 2/9] configure: check nvme uring command support Ankit Kumar
[not found] ` <CGME20220531133743epcas5p4d400c341f29489c51e3ee5590415420c@epcas5p4.samsung.com>
2022-05-31 13:31 ` [PATCH v3 3/9] init: return error incase an invalid value is passed as option Ankit Kumar
[not found] ` <CGME20220531133745epcas5p3546b36e799931251c4020e4fe13fa14d@epcas5p3.samsung.com>
2022-05-31 13:31 ` [PATCH v3 4/9] nvme: add nvme opcodes, structures and helper functions Ankit Kumar
[not found] ` <CGME20220531133746epcas5p36ec535b219f3e2008b14d2adc59e30f2@epcas5p3.samsung.com>
2022-05-31 13:31 ` [PATCH v3 5/9] engines/io_uring: add new I/O engine for uring passthrough support Ankit Kumar
2022-06-02 4:19 ` Jens Axboe
[not found] ` <CGME20220531133747epcas5p4a9a89962301b8853ca13ba017546ae38@epcas5p4.samsung.com>
2022-05-31 13:31 ` [PATCH v3 6/9] docs: document options for io_uring_cmd I/O engine Ankit Kumar
[not found] ` <CGME20220531133748epcas5p1e2d8f913398d3ea8c165e1044e6914d8@epcas5p1.samsung.com>
2022-05-31 13:31 ` [PATCH v3 7/9] zbd: Check for direct flag only if its block device Ankit Kumar
2022-06-01 20:32 ` Vincent Fu
2022-06-02 1:53 ` Shinichiro Kawasaki
2022-06-02 0:55 ` Shinichiro Kawasaki [this message]
[not found] ` <CGME20220531133750epcas5p1602001843ff6971719f2435faf631cf4@epcas5p1.samsung.com>
2022-05-31 13:31 ` [PATCH v3 8/9] engines/io_uring: Enable zone device support for io_uring_cmd I/O engine Ankit Kumar
[not found] ` <CGME20220531133751epcas5p3819dec97a26ac12bf81d03d947a7272d@epcas5p3.samsung.com>
2022-05-31 13:31 ` [PATCH v3 9/9] examples: add 2 example job file for io_uring_cmd engine Ankit Kumar
2022-06-02 8:24 ` [PATCH v3 0/9] Add support for uring passthrough commands Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602005521.p4q3x34ba7dekrfl@shindev \
--to=shinichiro.kawasaki@wdc.com \
--cc=ankit.kumar@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=krish.reddy@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.