RE: [PATCH v3 7/9] zbd: Check for direct flag only if its block device

From: Vincent Fu <vincent.fu@samsung.com>
To: Ankit Kumar <ankit.kumar@samsung.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
	"krish.reddy@samsung.com" <krish.reddy@samsung.com>,
	"joshi.k@samsung.com" <joshi.k@samsung.com>,
	"anuj20.g@samsung.com" <anuj20.g@samsung.com>
Subject: RE: [PATCH v3 7/9] zbd: Check for direct flag only if its block device
Date: Wed, 1 Jun 2022 20:32:56 +0000	[thread overview]
Message-ID: <547f643d9ae54ee5a5f173115808b6da@samsung.com> (raw)
In-Reply-To: <20220531133155.17493-8-ankit.kumar@samsung.com>

> -----Original Message-----
> From: Ankit Kumar [mailto:ankit.kumar@samsung.com]
> Sent: Tuesday, May 31, 2022 9:32 AM
> To: axboe@kernel.dk
> Cc: fio@vger.kernel.org; krish.reddy@samsung.com;
> joshi.k@samsung.com; anuj20.g@samsung.com; Ankit Kumar
> <ankit.kumar@samsung.com>./test-zbd-support -l /dev/sg2
> Subject: [PATCH v3 7/9] zbd: Check for direct flag only if its block device
> 
> nvme-ns generic character devices currently do not support O_DIRECT
> flag.
> Check for fio option for direct flag only if filetype is a block device.
> 
> t/zbd skip test case #1 for character devices as they don't require
> direct I/O.
> 
> Tested-by: Vincent Fu <vincent.fu@samsung.com>
> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>

I ran

t/zbd/run-tests-against-nullb

and Test 1 ran for all sections. There were no test failures.

I also created a zoned device with:

modprobe scsi_debug zbc=2 zone_nr_conv=0

and then ran:

t/zbd/test-zbd-support -l /dev/sg2

and all tests except Test 13 passed. The failure seems unrelated to this patch. The failure appears to be related to libzbc reporting max open zones incorrectly.