All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, hch@lst.de, axboe@kernel.dk,
	martin.petersen@oracle.com,
	james.bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 04/11] block: Add PR callouts for read keys and reservation
Date: Fri,  3 Jun 2022 01:55:29 -0500	[thread overview]
Message-ID: <20220603065536.5641-5-michael.christie@oracle.com> (raw)
In-Reply-To: <20220603065536.5641-1-michael.christie@oracle.com>

Add callouts for reading keys and reservations.

Note: This only initially adds the struct definitions in the kernel as I'm
not sure if we wanted to export the interface to userspace yet. We may
want to refine internally for LIO and when we can enable it for NVMe then
add the finished interface to userspace.

The latter is not done, because NVMe's report reservation command is
similar to SCSI's read full status where they return a remote and local
ID as well as the key/reservation info. However, a lot of SCSI devices
don't do remote/local ID parts correctly. It seems that read full status
might not be used very often so does not get a lot of testing.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/pr.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/linux/pr.h b/include/linux/pr.h
index 94ceec713afe..21a8eb8b34b5 100644
--- a/include/linux/pr.h
+++ b/include/linux/pr.h
@@ -4,6 +4,18 @@
 
 #include <uapi/linux/pr.h>
 
+struct pr_keys {
+	u32	generation;
+	u32	num_keys;
+	u64	keys[];
+};
+
+struct pr_held_reservation {
+	u64	key;
+	u32	type;
+	u32	generation;
+};
+
 struct pr_ops {
 	int (*pr_register)(struct block_device *bdev, u64 old_key, u64 new_key,
 			u32 flags);
@@ -14,6 +26,10 @@ struct pr_ops {
 	int (*pr_preempt)(struct block_device *bdev, u64 old_key, u64 new_key,
 			enum pr_type type, bool abort);
 	int (*pr_clear)(struct block_device *bdev, u64 key);
+	int (*pr_read_keys)(struct block_device *bdev,
+			    struct pr_keys *keys_info, int keys_info_len);
+	int (*pr_read_reservation)(struct block_device *bdev,
+				   struct pr_held_reservation *rsv);
 };
 
 #endif /* LINUX_PR_H */
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com>
To: linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, hch@lst.de, axboe@kernel.dk,
	martin.petersen@oracle.com,
	james.bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [dm-devel] [PATCH 04/11] block: Add PR callouts for read keys and reservation
Date: Fri,  3 Jun 2022 01:55:29 -0500	[thread overview]
Message-ID: <20220603065536.5641-5-michael.christie@oracle.com> (raw)
In-Reply-To: <20220603065536.5641-1-michael.christie@oracle.com>

Add callouts for reading keys and reservations.

Note: This only initially adds the struct definitions in the kernel as I'm
not sure if we wanted to export the interface to userspace yet. We may
want to refine internally for LIO and when we can enable it for NVMe then
add the finished interface to userspace.

The latter is not done, because NVMe's report reservation command is
similar to SCSI's read full status where they return a remote and local
ID as well as the key/reservation info. However, a lot of SCSI devices
don't do remote/local ID parts correctly. It seems that read full status
might not be used very often so does not get a lot of testing.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 include/linux/pr.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/include/linux/pr.h b/include/linux/pr.h
index 94ceec713afe..21a8eb8b34b5 100644
--- a/include/linux/pr.h
+++ b/include/linux/pr.h
@@ -4,6 +4,18 @@
 
 #include <uapi/linux/pr.h>
 
+struct pr_keys {
+	u32	generation;
+	u32	num_keys;
+	u64	keys[];
+};
+
+struct pr_held_reservation {
+	u64	key;
+	u32	type;
+	u32	generation;
+};
+
 struct pr_ops {
 	int (*pr_register)(struct block_device *bdev, u64 old_key, u64 new_key,
 			u32 flags);
@@ -14,6 +26,10 @@ struct pr_ops {
 	int (*pr_preempt)(struct block_device *bdev, u64 old_key, u64 new_key,
 			enum pr_type type, bool abort);
 	int (*pr_clear)(struct block_device *bdev, u64 key);
+	int (*pr_read_keys)(struct block_device *bdev,
+			    struct pr_keys *keys_info, int keys_info_len);
+	int (*pr_read_reservation)(struct block_device *bdev,
+				   struct pr_held_reservation *rsv);
 };
 
 #endif /* LINUX_PR_H */
-- 
2.25.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2022-06-03  6:56 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  6:55 [PATCH 0/8] Use block pr_ops in LIO Mike Christie
2022-06-03  6:55 ` [dm-devel] " Mike Christie
2022-06-03  6:55 ` [PATCH 01/11] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-20  7:12   ` Christoph Hellwig
2022-06-20  7:12     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` [PATCH 02/11] scsi: Rename sd_pr_command Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-20  7:13   ` Christoph Hellwig
2022-06-20  7:13     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` [PATCH 03/11] scsi: Move sd_pr_type to header to share Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-05  3:58   ` Bart Van Assche
2022-06-05  3:58     ` [dm-devel] " Bart Van Assche
2022-06-20  7:13   ` Christoph Hellwig
2022-06-20  7:13     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` Mike Christie [this message]
2022-06-03  6:55   ` [dm-devel] [PATCH 04/11] block: Add PR callouts for read keys and reservation Mike Christie
2022-06-20  7:14   ` Christoph Hellwig
2022-06-20  7:14     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` [PATCH 05/11] scsi: Add support for block PR read keys/reservation Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-03  6:55 ` [PATCH 06/11] dm: " Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-03  6:55 ` [PATCH 07/11] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-20  7:15   ` Christoph Hellwig
2022-06-20  7:15     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` [PATCH 08/11] scsi: target: Add block PR support to iblock Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-20  7:18   ` Christoph Hellwig
2022-06-20  7:18     ` [dm-devel] " Christoph Hellwig
2022-06-03  6:55 ` [PATCH 09/11] block, nvme: Add error for reservation conflicts Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-03 19:45   ` Keith Busch
2022-06-03 19:45     ` [dm-devel] " Keith Busch
2022-06-03 23:08     ` Mike Christie
2022-06-03 23:08       ` [dm-devel] " Mike Christie
2022-06-04  7:38     ` Hannes Reinecke
2022-06-04  7:38       ` [dm-devel] " Hannes Reinecke
2022-06-04 17:13       ` michael.christie
2022-06-04 17:13         ` [dm-devel] " michael.christie
2022-06-05  9:42         ` Hannes Reinecke
2022-06-05  9:42           ` [dm-devel] " Hannes Reinecke
2022-06-20  7:23           ` Christoph Hellwig
2022-06-20  7:23             ` [dm-devel] " Christoph Hellwig
2022-06-05  4:00   ` Bart Van Assche
2022-06-05  4:00     ` Bart Van Assche
2022-06-03  6:55 ` [PATCH 10/11] scsi: Use BLK_STS_RSV_CONFLICT " Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-03  6:55 ` [PATCH 11/11] scsi: target: Handle BLK_STS_RSV_CONFLICT Mike Christie
2022-06-03  6:55   ` [dm-devel] " Mike Christie
2022-06-03 11:46 ` [PATCH 0/8] Use block pr_ops in LIO Christoph Hellwig
2022-06-03 11:46   ` [dm-devel] " Christoph Hellwig
2022-06-03 17:55   ` Mike Christie
2022-06-03 17:55     ` [dm-devel] " Mike Christie
2022-06-20  7:12     ` Christoph Hellwig
2022-06-20  7:12       ` [dm-devel] " Christoph Hellwig
2022-06-05  4:01 ` Bart Van Assche
2022-06-05  4:01   ` Bart Van Assche
2022-06-05 16:55   ` Mike Christie
2022-06-05 16:55     ` Mike Christie
2022-06-05 18:15     ` Bart Van Assche
2022-06-05 18:15       ` Bart Van Assche
2022-06-06 16:38       ` Mike Christie
2022-06-06 16:38         ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220603065536.5641-5-michael.christie@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.