From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
Randy Dunlap <rdunlap@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Fernando Ramos <greenfoo@u92.eu>
Subject: [Nouveau] [RESEND RFC 12/18] drm/nouveau/kms: Pull mst state in for all modesets
Date: Tue, 7 Jun 2022 15:29:27 -0400 [thread overview]
Message-ID: <20220607192933.1333228-13-lyude@redhat.com> (raw)
In-Reply-To: <20220607192933.1333228-1-lyude@redhat.com>
Since we're going to be relying on atomic locking for payloads now (and the
MST mgr needs to track CRTCs), pull in the topology state for all modesets
in nv50_msto_atomic_check().
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 461e5e3345f8..834a5c5b77d5 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1054,7 +1054,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,
if (ret)
return ret;
- if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
+ if (!drm_atomic_crtc_needs_modeset(crtc_state))
return 0;
/*
--
2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@linux.ie>,
Randy Dunlap <rdunlap@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Ben Skeggs <bskeggs@redhat.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Fernando Ramos <greenfoo@u92.eu>
Subject: [RESEND RFC 12/18] drm/nouveau/kms: Pull mst state in for all modesets
Date: Tue, 7 Jun 2022 15:29:27 -0400 [thread overview]
Message-ID: <20220607192933.1333228-13-lyude@redhat.com> (raw)
In-Reply-To: <20220607192933.1333228-1-lyude@redhat.com>
Since we're going to be relying on atomic locking for payloads now (and the
MST mgr needs to track CRTCs), pull in the topology state for all modesets
in nv50_msto_atomic_check().
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 461e5e3345f8..834a5c5b77d5 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1054,7 +1054,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,
if (ret)
return ret;
- if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
+ if (!drm_atomic_crtc_needs_modeset(crtc_state))
return 0;
/*
--
2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@linux.ie>,
Randy Dunlap <rdunlap@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Fernando Ramos <greenfoo@u92.eu>
Subject: [RESEND RFC 12/18] drm/nouveau/kms: Pull mst state in for all modesets
Date: Tue, 7 Jun 2022 15:29:27 -0400 [thread overview]
Message-ID: <20220607192933.1333228-13-lyude@redhat.com> (raw)
In-Reply-To: <20220607192933.1333228-1-lyude@redhat.com>
Since we're going to be relying on atomic locking for payloads now (and the
MST mgr needs to track CRTCs), pull in the topology state for all modesets
in nv50_msto_atomic_check().
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 461e5e3345f8..834a5c5b77d5 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1054,7 +1054,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,
if (ret)
return ret;
- if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
+ if (!drm_atomic_crtc_needs_modeset(crtc_state))
return 0;
/*
--
2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Randy Dunlap <rdunlap@infradead.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Fernando Ramos <greenfoo@u92.eu>,
linux-kernel@vger.kernel.org (open list)
Subject: [RESEND RFC 12/18] drm/nouveau/kms: Pull mst state in for all modesets
Date: Tue, 7 Jun 2022 15:29:27 -0400 [thread overview]
Message-ID: <20220607192933.1333228-13-lyude@redhat.com> (raw)
In-Reply-To: <20220607192933.1333228-1-lyude@redhat.com>
Since we're going to be relying on atomic locking for payloads now (and the
MST mgr needs to track CRTCs), pull in the topology state for all modesets
in nv50_msto_atomic_check().
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 461e5e3345f8..834a5c5b77d5 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1054,7 +1054,7 @@ nv50_msto_atomic_check(struct drm_encoder *encoder,
if (ret)
return ret;
- if (!crtc_state->mode_changed && !crtc_state->connectors_changed)
+ if (!drm_atomic_crtc_needs_modeset(crtc_state))
return 0;
/*
--
2.35.3
next prev parent reply other threads:[~2022-06-07 19:36 UTC|newest]
Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 19:29 [Nouveau] [RESEND RFC 00/18] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 01/18] drm/amdgpu/dc/mst: Rename dp_mst_stream_allocation(_table) Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 02/18] drm/amdgpu/dm/mst: Rename get_payload_table() Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 03/18] drm/display/dp_mst: Rename drm_dp_mst_vcpi_allocation Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [RESEND RFC 04/18] drm/display/dp_mst: Call them time slots, not VCPI slots Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] " Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Intel-gfx] " Lyude Paul
2022-06-15 4:28 ` Lin, Wayne
2022-06-15 4:28 ` [Nouveau] " Lin, Wayne
2022-06-15 4:28 ` Lin, Wayne
2022-06-15 4:28 ` Lin, Wayne
2022-08-02 21:29 ` Lyude Paul
2022-08-02 21:29 ` [Nouveau] " Lyude Paul
2022-08-02 21:29 ` [Intel-gfx] " Lyude Paul
2022-08-02 21:29 ` Lyude Paul
2022-08-02 21:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 05/18] drm/display/dp_mst: Fix confusing docs for drm_dp_atomic_release_time_slots() Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 06/18] drm/display/dp_mst: Add some missing kdocs for atomic MST structs Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-15 4:43 ` Lin, Wayne
2022-06-15 4:43 ` [Nouveau] " Lin, Wayne
2022-06-15 4:43 ` Lin, Wayne
2022-06-15 4:43 ` Lin, Wayne
2022-08-08 23:07 ` Lyude Paul
2022-08-08 23:07 ` Lyude Paul
2022-08-08 23:07 ` Lyude Paul
2022-08-08 23:07 ` [Nouveau] " Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 07/18] drm/display/dp_mst: Add helper for finding payloads in atomic MST state Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-29 13:22 ` Jani Nikula
2022-06-29 13:22 ` Jani Nikula
2022-06-29 13:22 ` Jani Nikula
2022-06-29 13:22 ` [Nouveau] " Jani Nikula
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 08/18] drm/display/dp_mst: Add nonblocking helpers for DP MST Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Intel-gfx] " Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-29 13:30 ` Jani Nikula
2022-06-29 13:30 ` Jani Nikula
2022-06-29 13:30 ` [Intel-gfx] " Jani Nikula
2022-06-29 13:30 ` Jani Nikula
2022-06-29 13:30 ` [Nouveau] " Jani Nikula
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 09/18] drm/display/dp_mst: Don't open code modeset checks for releasing time slots Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Intel-gfx] " Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 10/18] drm/display/dp_mst: Fix modeset tracking in drm_dp_atomic_release_vcpi_slots() Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 11/18] drm/nouveau/kms: Cache DP encoders in nouveau_connector Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul [this message]
2022-06-07 19:29 ` [RESEND RFC 12/18] drm/nouveau/kms: Pull mst state in for all modesets Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [RESEND RFC 13/18] drm/display/dp_mst: Add helpers for serializing SST <-> MST transitions Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] " Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Intel-gfx] " Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 14/18] drm/display/dp_mst: Drop all ports from topology on CSNs before queueing link address work Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 15/18] drm/display/dp_mst: Skip releasing payloads if last connected port isn't connected Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-07-05 8:45 ` Lin, Wayne
2022-07-05 8:45 ` [Nouveau] " Lin, Wayne
2022-07-05 8:45 ` Lin, Wayne
2022-07-05 8:45 ` Lin, Wayne
2022-08-02 22:12 ` [Nouveau] " Lyude Paul
2022-08-02 22:12 ` Lyude Paul
2022-08-02 22:12 ` Lyude Paul
2022-08-02 22:12 ` Lyude Paul
2022-08-10 3:28 ` Lin, Wayne
2022-08-10 3:28 ` Lin, Wayne
2022-08-10 3:28 ` Lin, Wayne
2022-08-10 3:28 ` [Nouveau] " Lin, Wayne
2022-08-10 22:13 ` Lyude Paul
2022-08-10 22:13 ` Lyude Paul
2022-08-10 22:13 ` Lyude Paul
2022-08-10 22:13 ` [Nouveau] " Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 16/18] drm/display/dp_mst: Maintain time slot allocations when deleting payloads Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] [RESEND RFC 17/18] drm/radeon: Drop legacy MST support Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 20:48 ` [Nouveau] " Alex Deucher
2022-06-07 20:48 ` Alex Deucher
2022-06-07 20:48 ` Alex Deucher
2022-06-07 19:29 ` [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info into the atomic state Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Nouveau] " Lyude Paul
2022-06-07 19:29 ` Lyude Paul
2022-06-07 19:29 ` [Intel-gfx] " Lyude Paul
2022-07-05 9:10 ` Lin, Wayne
2022-07-05 9:10 ` [Nouveau] " Lin, Wayne
2022-07-05 9:10 ` Lin, Wayne
2022-07-05 9:10 ` Lin, Wayne
2022-07-06 21:57 ` Lyude Paul
2022-07-06 21:57 ` [Nouveau] " Lyude Paul
2022-07-06 21:57 ` Lyude Paul
2022-07-06 21:57 ` [Intel-gfx] " Lyude Paul
2022-07-06 21:57 ` Lyude Paul
2022-08-03 20:27 ` Lyude Paul
2022-08-03 20:27 ` [Nouveau] " Lyude Paul
2022-08-03 20:27 ` Lyude Paul
2022-08-03 20:27 ` [Intel-gfx] " Lyude Paul
2022-08-03 20:27 ` Lyude Paul
2022-08-08 10:02 ` Lin, Wayne
2022-08-08 10:02 ` [Nouveau] " Lin, Wayne
2022-08-08 10:02 ` [Intel-gfx] " Lin, Wayne
2022-08-08 10:02 ` Lin, Wayne
2022-08-08 10:02 ` Lin, Wayne
2022-08-08 22:53 ` Lyude Paul
2022-08-08 22:53 ` [Nouveau] " Lyude Paul
2022-08-08 22:53 ` Lyude Paul
2022-08-08 22:53 ` [Intel-gfx] " Lyude Paul
2022-08-08 22:53 ` Lyude Paul
2022-06-29 13:33 ` [Nouveau] [RESEND RFC 00/18] drm/display/dp_mst: Drop Radeon MST support, make MST atomic-only Jani Nikula
2022-06-29 13:33 ` Jani Nikula
2022-06-29 13:33 ` Jani Nikula
2022-07-28 22:21 ` [Nouveau] " Lyude Paul
2022-07-28 22:21 ` Lyude Paul
2022-07-28 22:21 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607192933.1333228-13-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=greenfoo@u92.eu \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rdunlap@infradead.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.