From: Bjorn Helgaas <helgaas@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org,
linux-pci@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 1/2] video: fbdev: cirrusfb: Remove useless reference to PCI power management
Date: Tue, 7 Jun 2022 18:11:11 -0500 [thread overview]
Message-ID: <20220607231112.354165-2-helgaas@kernel.org> (raw)
In-Reply-To: <20220607231112.354165-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
deprecated. The cirrusfb driver has never implemented power management at
all, but if it ever does, it should use the generic power management
framework, not the PCI-specific hooks.
Remove the commented-out references to the PCI-specific power management
hooks.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/video/fbdev/cirrusfb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
index 3d47c347b897..51e072c03e1c 100644
--- a/drivers/video/fbdev/cirrusfb.c
+++ b/drivers/video/fbdev/cirrusfb.c
@@ -2184,12 +2184,6 @@ static struct pci_driver cirrusfb_pci_driver = {
.id_table = cirrusfb_pci_table,
.probe = cirrusfb_pci_register,
.remove = cirrusfb_pci_unregister,
-#ifdef CONFIG_PM
-#if 0
- .suspend = cirrusfb_pci_suspend,
- .resume = cirrusfb_pci_resume,
-#endif
-#endif
};
#endif /* CONFIG_PCI */
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 1/2] video: fbdev: cirrusfb: Remove useless reference to PCI power management
Date: Tue, 7 Jun 2022 18:11:11 -0500 [thread overview]
Message-ID: <20220607231112.354165-2-helgaas@kernel.org> (raw)
In-Reply-To: <20220607231112.354165-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
deprecated. The cirrusfb driver has never implemented power management at
all, but if it ever does, it should use the generic power management
framework, not the PCI-specific hooks.
Remove the commented-out references to the PCI-specific power management
hooks.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/video/fbdev/cirrusfb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
index 3d47c347b897..51e072c03e1c 100644
--- a/drivers/video/fbdev/cirrusfb.c
+++ b/drivers/video/fbdev/cirrusfb.c
@@ -2184,12 +2184,6 @@ static struct pci_driver cirrusfb_pci_driver = {
.id_table = cirrusfb_pci_table,
.probe = cirrusfb_pci_register,
.remove = cirrusfb_pci_unregister,
-#ifdef CONFIG_PM
-#if 0
- .suspend = cirrusfb_pci_suspend,
- .resume = cirrusfb_pci_resume,
-#endif
-#endif
};
#endif /* CONFIG_PCI */
--
2.25.1
next prev parent reply other threads:[~2022-06-07 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 23:11 [PATCH 0/2] video: fbdev: Convert from PCI to generic power management Bjorn Helgaas
2022-06-07 23:11 ` Bjorn Helgaas
2022-06-07 23:11 ` Bjorn Helgaas [this message]
2022-06-07 23:11 ` [PATCH 1/2] video: fbdev: cirrusfb: Remove useless reference to PCI " Bjorn Helgaas
2022-06-07 23:11 ` [PATCH 2/2] video: fbdev: skeletonfb: Convert to generic " Bjorn Helgaas
2022-06-07 23:11 ` Bjorn Helgaas
2022-06-08 16:26 ` [PATCH 0/2] video: fbdev: Convert from PCI " Daniel Vetter
2022-06-08 16:26 ` Daniel Vetter
2022-06-08 18:09 ` Bjorn Helgaas
2022-06-20 12:40 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607231112.354165-2-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.