All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: abel.vesa@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Peng Fan <peng.fan@nxp.com>, Jacky Bai <ping.bai@nxp.com>
Subject: [PATCH 4/7] clk: imx: clk-fracn-gppll: fix mfd value
Date: Thu,  9 Jun 2022 21:28:59 +0800	[thread overview]
Message-ID: <20220609132902.3504651-5-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220609132902.3504651-1-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

According to spec:
A value of 0 is disallowed and should not be programmed in this register

Fix to 1.

Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll")
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clk/imx/clk-fracn-gppll.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c
index 71c102d950ab..36a53c60e71f 100644
--- a/drivers/clk/imx/clk-fracn-gppll.c
+++ b/drivers/clk/imx/clk-fracn-gppll.c
@@ -64,10 +64,10 @@ struct clk_fracn_gppll {
  * Fout = Fvco / (rdiv * odiv)
  */
 static const struct imx_fracn_gppll_rate_table fracn_tbl[] = {
-	PLL_FRACN_GP(650000000U, 81, 0, 0, 0, 3),
-	PLL_FRACN_GP(594000000U, 198, 0, 0, 0, 8),
-	PLL_FRACN_GP(560000000U, 70, 0, 0, 0, 3),
-	PLL_FRACN_GP(400000000U, 50, 0, 0, 0, 3),
+	PLL_FRACN_GP(650000000U, 81, 0, 1, 0, 3),
+	PLL_FRACN_GP(594000000U, 198, 0, 1, 0, 8),
+	PLL_FRACN_GP(560000000U, 70, 0, 1, 0, 3),
+	PLL_FRACN_GP(400000000U, 50, 0, 1, 0, 3),
 	PLL_FRACN_GP(393216000U, 81, 92, 100, 0, 5)
 };
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: abel.vesa@nxp.com, mturquette@baylibre.com, sboyd@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Peng Fan <peng.fan@nxp.com>, Jacky Bai <ping.bai@nxp.com>
Subject: [PATCH 4/7] clk: imx: clk-fracn-gppll: fix mfd value
Date: Thu,  9 Jun 2022 21:28:59 +0800	[thread overview]
Message-ID: <20220609132902.3504651-5-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220609132902.3504651-1-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

According to spec:
A value of 0 is disallowed and should not be programmed in this register

Fix to 1.

Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll")
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clk/imx/clk-fracn-gppll.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c
index 71c102d950ab..36a53c60e71f 100644
--- a/drivers/clk/imx/clk-fracn-gppll.c
+++ b/drivers/clk/imx/clk-fracn-gppll.c
@@ -64,10 +64,10 @@ struct clk_fracn_gppll {
  * Fout = Fvco / (rdiv * odiv)
  */
 static const struct imx_fracn_gppll_rate_table fracn_tbl[] = {
-	PLL_FRACN_GP(650000000U, 81, 0, 0, 0, 3),
-	PLL_FRACN_GP(594000000U, 198, 0, 0, 0, 8),
-	PLL_FRACN_GP(560000000U, 70, 0, 0, 0, 3),
-	PLL_FRACN_GP(400000000U, 50, 0, 0, 0, 3),
+	PLL_FRACN_GP(650000000U, 81, 0, 1, 0, 3),
+	PLL_FRACN_GP(594000000U, 198, 0, 1, 0, 8),
+	PLL_FRACN_GP(560000000U, 70, 0, 1, 0, 3),
+	PLL_FRACN_GP(400000000U, 50, 0, 1, 0, 3),
 	PLL_FRACN_GP(393216000U, 81, 92, 100, 0, 5)
 };
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-06-09 13:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 13:28 [PATCH 0/7] clk: imx93: pll/imx93 fixes and update Peng Fan (OSS)
2022-06-09 13:28 ` Peng Fan (OSS)
2022-06-09 13:28 ` [PATCH 1/7] clk: imx93: use adc_root as the parent clock of adc1 Peng Fan (OSS)
2022-06-09 13:28   ` Peng Fan (OSS)
2022-06-15 21:31   ` Abel Vesa
2022-06-15 21:31     ` Abel Vesa
2022-06-09 13:28 ` [PATCH 2/7] clk: imx93: correct nic_media parent Peng Fan (OSS)
2022-06-09 13:28   ` Peng Fan (OSS)
2022-06-15 21:33   ` Abel Vesa
2022-06-15 21:33     ` Abel Vesa
2022-06-09 13:28 ` [PATCH 3/7] clk: imx93: Correct the edma1's parent clock Peng Fan (OSS)
2022-06-09 13:28   ` Peng Fan (OSS)
2022-06-15 21:39   ` Abel Vesa
2022-06-15 21:39     ` Abel Vesa
2022-06-16  0:16     ` Stephen Boyd
2022-06-16  0:16       ` Stephen Boyd
2022-06-16  3:58       ` Peng Fan
2022-06-16  3:58         ` Peng Fan
2022-06-16 14:18         ` Abel Vesa
2022-06-16 14:18           ` Abel Vesa
2022-06-09 13:28 ` Peng Fan (OSS) [this message]
2022-06-09 13:28   ` [PATCH 4/7] clk: imx: clk-fracn-gppll: fix mfd value Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 5/7] clk: imx: clk-fracn-gppll: Return rate in rate table properly in ->recalc_rate() Peng Fan (OSS)
2022-06-09 13:29   ` Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 6/7] clk: imx: clk-fracn-gppll: correct rdiv Peng Fan (OSS)
2022-06-09 13:29   ` Peng Fan (OSS)
2022-06-09 13:29 ` [PATCH 7/7] clk: imx: clk-fracn-gppll: Add more freq config for video pll Peng Fan (OSS)
2022-06-09 13:29   ` Peng Fan (OSS)
2022-06-16 16:01 ` [PATCH 0/7] clk: imx93: pll/imx93 fixes and update Abel Vesa
2022-06-16 16:01   ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609132902.3504651-5-peng.fan@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.