From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Richard Zhu <hongxing.zhu@nxp.com>,
l.stach@pengutronix.de, bhelgaas@google.com, robh@kernel.org
Cc: broonie@kernel.org, lorenzo.pieralisi@arm.com,
festevam@gmail.com, francesco.dolcini@toradex.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v10 5/7] PCI: imx6: Turn off regulator when the system is in suspend mode
Date: Mon, 13 Jun 2022 12:17:12 +0200 [thread overview]
Message-ID: <20220613101712.GA20538@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <1655110538-10914-6-git-send-email-hongxing.zhu@nxp.com>
On Mon, Jun 13, 2022 at 04:55:36PM +0800, Richard Zhu wrote:
> The driver should undo any enables it did itself. The regulator disable
> shouldn't be basing decisions on regulator_is_enabled().
>
> Move the regulator_disable to the suspend function, turn off regulator
> when the system is in suspend mode.
According to the documentation:
vpcie-supply:
description: Should specify the regulator in charge of PCIe port power.
The regulator will be enabled when initializing the PCIe host and
disabled either as part of the init process or when shutting down
the host (optional required).
Is this really what we want to do (remove power in suspend, enable
it on resume)? On our boards this powers a PCIe device connected to the host
port, that sound fair according to the binding documentation for it.
Am I wrong?
We do have issues with PCIe not working anymore after suspend/resume,
wondering (I did not have time to properly dig into it) if this is the
root cause.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Richard Zhu <hongxing.zhu@nxp.com>,
l.stach@pengutronix.de, bhelgaas@google.com, robh@kernel.org
Cc: broonie@kernel.org, lorenzo.pieralisi@arm.com,
festevam@gmail.com, francesco.dolcini@toradex.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v10 5/7] PCI: imx6: Turn off regulator when the system is in suspend mode
Date: Mon, 13 Jun 2022 12:17:12 +0200 [thread overview]
Message-ID: <20220613101712.GA20538@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <1655110538-10914-6-git-send-email-hongxing.zhu@nxp.com>
On Mon, Jun 13, 2022 at 04:55:36PM +0800, Richard Zhu wrote:
> The driver should undo any enables it did itself. The regulator disable
> shouldn't be basing decisions on regulator_is_enabled().
>
> Move the regulator_disable to the suspend function, turn off regulator
> when the system is in suspend mode.
According to the documentation:
vpcie-supply:
description: Should specify the regulator in charge of PCIe port power.
The regulator will be enabled when initializing the PCIe host and
disabled either as part of the init process or when shutting down
the host (optional required).
Is this really what we want to do (remove power in suspend, enable
it on resume)? On our boards this powers a PCIe device connected to the host
port, that sound fair according to the binding documentation for it.
Am I wrong?
We do have issues with PCIe not working anymore after suspend/resume,
wondering (I did not have time to properly dig into it) if this is the
root cause.
Francesco
next prev parent reply other threads:[~2022-06-13 10:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 8:55 [PATCH v10 0/7] PCI: imx6: refine codes and add the error propagation Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 8:55 ` [PATCH v10 1/7] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 8:55 ` [PATCH v10 2/7] PCI: imx6: Add the error propagation from host_init Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 8:55 ` [PATCH v10 3/7] PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 8:55 ` [PATCH v10 4/7] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 8:55 ` [PATCH v10 5/7] PCI: imx6: Turn off regulator when the system is in suspend mode Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 10:17 ` Francesco Dolcini [this message]
2022-06-13 10:17 ` Francesco Dolcini
2022-06-14 0:58 ` Hongxing Zhu
2022-06-14 0:58 ` Hongxing Zhu
2022-06-13 8:55 ` [PATCH v10 6/7] PCI: imx6: Mark the link down as none fatal error Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 22:21 ` Bjorn Helgaas
2022-06-13 22:21 ` Bjorn Helgaas
2022-06-14 1:02 ` Hongxing Zhu
2022-06-14 1:02 ` Hongxing Zhu
2022-06-13 8:55 ` [PATCH v10 7/7] PCI: imx6: Do not hide phy driver callbacks and refine the error handling Richard Zhu
2022-06-13 8:55 ` Richard Zhu
2022-06-13 20:41 ` [PATCH v10 0/7] PCI: imx6: refine codes and add the error propagation Bjorn Helgaas
2022-06-13 20:41 ` Bjorn Helgaas
2022-06-14 1:00 ` Hongxing Zhu
2022-06-14 1:00 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613101712.GA20538@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.