From: Pankaj Raghav <p.raghav@samsung.com> To: hch@lst.de, snitzer@redhat.com, damien.lemoal@opensource.wdc.com, axboe@kernel.dk Cc: Pankaj Raghav <p.raghav@samsung.com>, bvanassche@acm.org, pankydev8@gmail.com, gost.dev@samsung.com, jiangbo.365@bytedance.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, jonathan.derrick@linux.dev, Johannes.Thumshirn@wdc.com, dsterba@suse.com, jaegeuk@kernel.org, Luis Chamberlain <mcgrof@kernel.org> Subject: [dm-devel] [PATCH v7 09/13] dm-zone: use generic helpers to calculate offset from zone start Date: Wed, 15 Jun 2022 12:19:16 +0200 [thread overview] Message-ID: <20220615101920.329421-10-p.raghav@samsung.com> (raw) In-Reply-To: <20220615101920.329421-1-p.raghav@samsung.com> Use the blk_queue_offset_from_zone_start() helper function to calculate the offset from zone start instead of using power of 2 based calculation. Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/md/dm-zone.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c index 3e7b1fe15..af36d33f9 100644 --- a/drivers/md/dm-zone.c +++ b/drivers/md/dm-zone.c @@ -395,7 +395,8 @@ static bool dm_zone_map_bio_begin(struct mapped_device *md, case REQ_OP_WRITE_ZEROES: case REQ_OP_WRITE: /* Writes must be aligned to the zone write pointer */ - if ((clone->bi_iter.bi_sector & (zsectors - 1)) != zwp_offset) + if ((blk_queue_offset_from_zone_start(md->queue, + clone->bi_iter.bi_sector)) != zwp_offset) return false; break; case REQ_OP_ZONE_APPEND: @@ -608,10 +609,8 @@ void dm_zone_endio(struct dm_io *io, struct bio *clone) */ if (clone->bi_status == BLK_STS_OK && bio_op(clone) == REQ_OP_ZONE_APPEND) { - sector_t mask = (sector_t)blk_queue_zone_sectors(q) - 1; - orig_bio->bi_iter.bi_sector += - clone->bi_iter.bi_sector & mask; + blk_queue_offset_from_zone_start(q, clone->bi_iter.bi_sector); } return; -- 2.25.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Raghav <p.raghav@samsung.com> To: hch@lst.de, snitzer@redhat.com, damien.lemoal@opensource.wdc.com, axboe@kernel.dk Cc: bvanassche@acm.org, linux-kernel@vger.kernel.org, jiangbo.365@bytedance.com, hare@suse.de, pankydev8@gmail.com, dm-devel@redhat.com, jonathan.derrick@linux.dev, gost.dev@samsung.com, dsterba@suse.com, jaegeuk@kernel.org, linux-nvme@lists.infradead.org, Johannes.Thumshirn@wdc.com, linux-block@vger.kernel.org, Pankaj Raghav <p.raghav@samsung.com>, Luis Chamberlain <mcgrof@kernel.org> Subject: [PATCH v7 09/13] dm-zone: use generic helpers to calculate offset from zone start Date: Wed, 15 Jun 2022 12:19:16 +0200 [thread overview] Message-ID: <20220615101920.329421-10-p.raghav@samsung.com> (raw) In-Reply-To: <20220615101920.329421-1-p.raghav@samsung.com> Use the blk_queue_offset_from_zone_start() helper function to calculate the offset from zone start instead of using power of 2 based calculation. Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> --- drivers/md/dm-zone.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c index 3e7b1fe15..af36d33f9 100644 --- a/drivers/md/dm-zone.c +++ b/drivers/md/dm-zone.c @@ -395,7 +395,8 @@ static bool dm_zone_map_bio_begin(struct mapped_device *md, case REQ_OP_WRITE_ZEROES: case REQ_OP_WRITE: /* Writes must be aligned to the zone write pointer */ - if ((clone->bi_iter.bi_sector & (zsectors - 1)) != zwp_offset) + if ((blk_queue_offset_from_zone_start(md->queue, + clone->bi_iter.bi_sector)) != zwp_offset) return false; break; case REQ_OP_ZONE_APPEND: @@ -608,10 +609,8 @@ void dm_zone_endio(struct dm_io *io, struct bio *clone) */ if (clone->bi_status == BLK_STS_OK && bio_op(clone) == REQ_OP_ZONE_APPEND) { - sector_t mask = (sector_t)blk_queue_zone_sectors(q) - 1; - orig_bio->bi_iter.bi_sector += - clone->bi_iter.bi_sector & mask; + blk_queue_offset_from_zone_start(q, clone->bi_iter.bi_sector); } return; -- 2.25.1
next prev parent reply other threads:[~2022-06-15 10:20 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20220615101924eucas1p27fbce623c0e1b3097169bf23dd6266d8@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 00/13] support non power of 2 zoned device Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101927eucas1p17220c7a36f69f59ff8ddd560b42967ec@eucas1p1.samsung.com> 2022-06-15 10:19 ` [PATCH v7 01/13] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav 2022-06-15 20:18 ` Bart Van Assche 2022-06-15 20:18 ` Bart Van Assche [not found] ` <CGME20220615101931eucas1p15ed09ae433a2c378b599e9086130d8eb@eucas1p1.samsung.com> 2022-06-15 10:19 ` [PATCH v7 02/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav 2022-06-15 20:28 ` Bart Van Assche 2022-06-15 20:28 ` Bart Van Assche 2022-06-16 10:09 ` Pankaj Raghav 2022-06-16 10:09 ` Pankaj Raghav 2022-06-16 16:04 ` Luis Chamberlain 2022-06-16 16:04 ` Luis Chamberlain 2022-06-16 23:30 ` Damien Le Moal 2022-06-16 23:30 ` Damien Le Moal [not found] ` <CGME20220615101935eucas1p26a7bc245d88a89312158d7a265f64aef@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 03/13] nvme: zns: Allow ZNS drives that have non-power_of_2 " Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101938eucas1p26ab159a1ffd0fa5a16d7f202ba7206e7@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101941eucas1p25e1c27b363e6b288b848521298e31705@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 05/13] null_blk: allow non power of 2 zoned devices Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101945eucas1p16fa264e81d9b6027ff131dd311ed91e2@eucas1p1.samsung.com> 2022-06-15 10:19 ` [PATCH v7 06/13] null_blk: use zone_size_sects_shift for " Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav 2022-06-15 11:56 ` Damien Le Moal 2022-06-15 11:56 ` [dm-devel] " Damien Le Moal [not found] ` <CGME20220615101948eucas1p2d8d801735c39b25256a019134adb0c6f@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 07/13] zonefs: allow non " Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101951eucas1p238eb45e563bd9645af81bf16c56d98ec@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav [not found] ` <CGME20220615101955eucas1p19b9d42ead7331f69f7dad1ec100312c2@eucas1p1.samsung.com> 2022-06-15 10:19 ` Pankaj Raghav [this message] 2022-06-15 10:19 ` [PATCH v7 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav [not found] ` <CGME20220615102000eucas1p27720aaa3c309327b2b9a33c5f840f498@eucas1p2.samsung.com> 2022-06-15 10:19 ` [dm-devel] [PATCH v7 10/13] dm-table: use bdev_is_zone_start helper in device_area_is_invalid() Pankaj Raghav 2022-06-15 10:19 ` Pankaj Raghav 2022-06-15 11:53 ` Damien Le Moal 2022-06-15 11:53 ` [dm-devel] " Damien Le Moal 2022-06-16 9:55 ` Pankaj Raghav 2022-06-16 9:55 ` [dm-devel] " Pankaj Raghav 2022-06-16 23:29 ` Damien Le Moal 2022-06-16 23:29 ` [dm-devel] " Damien Le Moal [not found] ` <CGME20220615102004eucas1p1e458ea097d381058b16fc6daa3eec998@eucas1p1.samsung.com> 2022-06-15 10:19 ` [dm-devel] [PATCH v7 11/13] dm-table: allow non po2 zoned devices Pankaj Raghav 2022-06-15 10:19 ` Pankaj Raghav [not found] ` <CGME20220615102007eucas1p1106f9520e2a86beb3792107dffd8071b@eucas1p1.samsung.com> 2022-06-15 10:19 ` [dm-devel] [PATCH v7 12/13] dm: call dm_zone_endio after the target endio callback for " Pankaj Raghav 2022-06-15 10:19 ` Pankaj Raghav 2022-06-15 11:01 ` [dm-devel] " Damien Le Moal 2022-06-15 11:01 ` Damien Le Moal 2022-06-16 12:24 ` Pankaj Raghav 2022-06-16 12:24 ` Pankaj Raghav 2022-06-16 23:33 ` Damien Le Moal 2022-06-16 23:33 ` Damien Le Moal [not found] ` <CGME20220615102011eucas1p220368db4a186181b1927dea50a79e5d4@eucas1p2.samsung.com> 2022-06-15 10:19 ` [PATCH v7 13/13] dm: add non power of 2 zoned target Pankaj Raghav 2022-06-15 10:19 ` [dm-devel] " Pankaj Raghav 2022-06-15 11:49 ` Damien Le Moal 2022-06-15 11:49 ` [dm-devel] " Damien Le Moal 2022-06-16 16:12 ` Pankaj Raghav 2022-06-16 16:12 ` [dm-devel] " Pankaj Raghav 2022-06-16 23:49 ` Damien Le Moal 2022-06-16 23:49 ` [dm-devel] " Damien Le Moal 2022-06-17 5:45 ` Pankaj Raghav 2022-06-17 5:45 ` [dm-devel] " Pankaj Raghav 2022-06-17 6:12 ` Damien Le Moal 2022-06-17 6:12 ` [dm-devel] " Damien Le Moal 2022-06-17 6:40 ` Pankaj Raghav 2022-06-17 6:40 ` [dm-devel] " Pankaj Raghav 2022-06-17 6:56 ` Damien Le Moal 2022-06-17 6:56 ` [dm-devel] " Damien Le Moal 2022-06-17 8:03 ` Pankaj Raghav 2022-06-17 8:03 ` [dm-devel] " Pankaj Raghav 2022-06-15 14:19 ` kernel test robot 2022-06-15 14:19 ` [dm-devel] " kernel test robot 2022-06-15 19:54 ` Randy Dunlap 2022-06-15 19:54 ` [dm-devel] " Randy Dunlap 2022-06-16 10:28 ` Pankaj Raghav 2022-06-16 10:28 ` [dm-devel] " Pankaj Raghav
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220615101920.329421-10-p.raghav@samsung.com \ --to=p.raghav@samsung.com \ --cc=Johannes.Thumshirn@wdc.com \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=damien.lemoal@opensource.wdc.com \ --cc=dm-devel@redhat.com \ --cc=dsterba@suse.com \ --cc=gost.dev@samsung.com \ --cc=hch@lst.de \ --cc=jaegeuk@kernel.org \ --cc=jiangbo.365@bytedance.com \ --cc=jonathan.derrick@linux.dev \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=mcgrof@kernel.org \ --cc=pankydev8@gmail.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.