From: Kuniyuki Iwashima <kuniyu@amazon.com> To: <lkp@intel.com> Cc: <aams@amazon.com>, <davem@davemloft.net>, <edumazet@google.com>, <kbuild-all@lists.01.org>, <kuba@kernel.org>, <kuniyu@amazon.com>, <llvm@lists.linux.dev>, <netdev@vger.kernel.org>, <pabeni@redhat.com> Subject: Re: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table. Date: Fri, 17 Jun 2022 13:44:56 -0700 [thread overview] Message-ID: <20220617204456.33187-1-kuniyu@amazon.com> (raw) In-Reply-To: <202206180244.SIWZxbAo-lkp@intel.com> From: kernel test robot <lkp@intel.com> Date: Sat, 18 Jun 2022 02:17:44 +0800 > Hi Kuniyuki, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5dcb50c009c9f8ec1cfca6a81a05c0060a5bbf68 > config: hexagon-randconfig-r045-20220617 (https://download.01.org/0day-ci/archive/20220618/202206180244.SIWZxbAo-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d764aa7fc6b9cc3fbe960019018f5f9e941eb0a6) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/d0da436e1c42550dbd332f48fd11992d5f4af487 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046 > git checkout d0da436e1c42550dbd332f48fd11992d5f4af487 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/unix/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> net/unix/af_unix.c:3590:1: warning: unused label 'err_sysctl' [-Wunused-label] > err_sysctl: > ^~~~~~~~~~~ > 1 warning generated. > > > vim +/err_sysctl +3590 net/unix/af_unix.c > > 3573 > 3574 net->unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE, > 3575 GFP_KERNEL); > 3576 if (!net->unx.hash) > 3577 goto err_proc; > 3578 > 3579 for (i = 0; i < UNIX_HASH_SIZE; i++) { > 3580 INIT_HLIST_HEAD(&net->unx.hash[i].head); > 3581 spin_lock_init(&net->unx.hash[i].lock); > 3582 } > 3583 > 3584 return 0; > 3585 > 3586 err_proc: > 3587 #ifdef CONFIG_PROC_FS > 3588 remove_proc_entry("unix", net->proc_net); > 3589 #endif > > 3590 err_sysctl: I will move this label into the #ifdef CONFIG_PROC_FS block above. Thanks! > 3591 unix_sysctl_unregister(net); > 3592 out: > 3593 return -ENOMEM; > 3594 } > 3595 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: Kuniyuki Iwashima <kuniyu@amazon.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table. Date: Fri, 17 Jun 2022 13:44:56 -0700 [thread overview] Message-ID: <20220617204456.33187-1-kuniyu@amazon.com> (raw) In-Reply-To: <202206180244.SIWZxbAo-lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2671 bytes --] From: kernel test robot <lkp@intel.com> Date: Sat, 18 Jun 2022 02:17:44 +0800 > Hi Kuniyuki, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5dcb50c009c9f8ec1cfca6a81a05c0060a5bbf68 > config: hexagon-randconfig-r045-20220617 (https://download.01.org/0day-ci/archive/20220618/202206180244.SIWZxbAo-lkp(a)intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d764aa7fc6b9cc3fbe960019018f5f9e941eb0a6) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/d0da436e1c42550dbd332f48fd11992d5f4af487 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Kuniyuki-Iwashima/af_unix-Introduce-per-netns-socket-hash-table/20220617-075046 > git checkout d0da436e1c42550dbd332f48fd11992d5f4af487 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/unix/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> net/unix/af_unix.c:3590:1: warning: unused label 'err_sysctl' [-Wunused-label] > err_sysctl: > ^~~~~~~~~~~ > 1 warning generated. > > > vim +/err_sysctl +3590 net/unix/af_unix.c > > 3573 > 3574 net->unx.hash = kmalloc(sizeof(struct unix_hashbucket) * UNIX_HASH_SIZE, > 3575 GFP_KERNEL); > 3576 if (!net->unx.hash) > 3577 goto err_proc; > 3578 > 3579 for (i = 0; i < UNIX_HASH_SIZE; i++) { > 3580 INIT_HLIST_HEAD(&net->unx.hash[i].head); > 3581 spin_lock_init(&net->unx.hash[i].lock); > 3582 } > 3583 > 3584 return 0; > 3585 > 3586 err_proc: > 3587 #ifdef CONFIG_PROC_FS > 3588 remove_proc_entry("unix", net->proc_net); > 3589 #endif > > 3590 err_sysctl: I will move this label into the #ifdef CONFIG_PROC_FS block above. Thanks! > 3591 unix_sysctl_unregister(net); > 3592 out: > 3593 return -ENOMEM; > 3594 } > 3595 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp
next prev parent reply other threads:[~2022-06-17 20:45 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 23:47 [PATCH v1 net-next 0/6] af_unix: Introduce per-netns socket hash table Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 1/6] af_unix: Clean up some sock_net() uses Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 2/6] af_unix: Include the whole hash table size in UNIX_HASH_SIZE Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 3/6] af_unix: Define a per-netns hash table Kuniyuki Iwashima 2022-06-17 4:23 ` Eric Dumazet 2022-06-17 5:33 ` Kuniyuki Iwashima 2022-06-17 6:08 ` Eric Dumazet 2022-06-17 6:57 ` Kuniyuki Iwashima 2022-06-17 8:00 ` Eric Dumazet 2022-06-17 17:52 ` Kuniyuki Iwashima 2022-06-17 18:17 ` kernel test robot 2022-06-17 20:44 ` Kuniyuki Iwashima [this message] 2022-06-17 20:44 ` Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 4/6] af_unix: Acquire/Release per-netns hash table's locks Kuniyuki Iwashima 2022-06-20 6:10 ` [af_unix] b4813d5914: WARNING:possible_recursive_locking_detected kernel test robot 2022-06-20 6:10 ` kernel test robot 2022-06-20 16:47 ` Kuniyuki Iwashima 2022-06-20 16:47 ` Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 5/6] af_unix: Put a socket into a per-netns hash table Kuniyuki Iwashima 2022-06-16 23:47 ` [PATCH v1 net-next 6/6] af_unix: Remove unix_table_locks Kuniyuki Iwashima
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220617204456.33187-1-kuniyu@amazon.com \ --to=kuniyu@amazon.com \ --cc=aams@amazon.com \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=lkp@intel.com \ --cc=llvm@lists.linux.dev \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.