From: kernel test robot <lkp@intel.com> To: David Gow <davidgow@google.com>, Brendan Higgins <brendanhiggins@google.com>, Luis Chamberlain <mcgrof@kernel.org>, Jeremy Kerr <jk@codeconstruct.com.au>, Daniel Latypov <dlatypov@google.com>, Shuah Khan <skhan@linuxfoundation.org>, Andrew Jeffery <andrew@aj.id.au>, Mika Westerberg <mika.westerberg@linux.intel.com>, Andra Paraschiv <andraprs@amazon.com>, Longpeng <longpeng2@huawei.com> Cc: kbuild-all@lists.01.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, "Maíra Canal" <maira.canal@usp.br>, linux-mmc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-modules@vger.kernel.org, "Matt Johnston" <matt@codeconstruct.com.au>, "David Gow" <davidgow@google.com> Subject: Re: [PATCH 2/5] kunit: flatten kunit_suite*** to kunit_suite** in .kunit_test_suites Date: Sat, 18 Jun 2022 22:49:16 +0800 [thread overview] Message-ID: <202206182258.EahbTrAv-lkp@intel.com> (raw) In-Reply-To: <20220618090310.1174932-3-davidgow@google.com> Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.19-rc2 next-20220617] [cannot apply to mcgrof/modules-next joel-aspeed/for-next ulf-hansson-mmc-mirror/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4b35035bcf80ddb47c0112c4fbd84a63a2836a18 config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220618/202206182258.EahbTrAv-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c2386c54cc9fd471e5353f375ff71734214ed3c6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 git checkout c2386c54cc9fd471e5353f375ff71734214ed3c6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> Note: the linux-review/David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 HEAD fddb3ea0ed5627098eabc542fdba5a8b4b769066 builds fine. It only hurts bisectability. All errors (new ones prefixed by >>): drivers/thunderbolt/test.c: In function 'tb_test_init': >> drivers/thunderbolt/test.c:2824:16: error: too few arguments to function '__kunit_test_suites_init' 2824 | return __kunit_test_suites_init(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/thunderbolt/test.c:9: include/kunit/test.h:240:5: note: declared here 240 | int __kunit_test_suites_init(struct kunit_suite * const * const suites, int num_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c: In function 'tb_test_exit': >> drivers/thunderbolt/test.c:2829:16: error: too few arguments to function '__kunit_test_suites_exit' 2829 | return __kunit_test_suites_exit(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/thunderbolt/test.c:9: include/kunit/test.h:242:6: note: declared here 242 | void __kunit_test_suites_exit(struct kunit_suite **suites, int num_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c:2829:16: error: 'return' with a value, in function returning void [-Werror=return-type] 2829 | return __kunit_test_suites_exit(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c:2827:6: note: declared here 2827 | void tb_test_exit(void) | ^~~~~~~~~~~~ drivers/thunderbolt/test.c: In function 'tb_test_init': drivers/thunderbolt/test.c:2825:1: error: control reaches end of non-void function [-Werror=return-type] 2825 | } | ^ cc1: some warnings being treated as errors vim +/__kunit_test_suites_init +2824 drivers/thunderbolt/test.c 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2821 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2822 int tb_test_init(void) 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2823 { 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 @2824 return __kunit_test_suites_init(tb_test_suites); 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2825 } 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2826 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2827 void tb_test_exit(void) 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2828 { 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 @2829 return __kunit_test_suites_exit(tb_test_suites); -- 0-DAY CI Kernel Test Service https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: David Gow <davidgow@google.com>, Brendan Higgins <brendanhiggins@google.com>, Luis Chamberlain <mcgrof@kernel.org>, Jeremy Kerr <jk@codeconstruct.com.au>, Daniel Latypov <dlatypov@google.com>, Shuah Khan <skhan@linuxfoundation.org>, Andrew Jeffery <andrew@aj.id.au>, Mika Westerberg <mika.westerberg@linux.intel.com>, Andra Paraschiv <andraprs@amazon.com>, Longpeng <longpeng2@huawei.com> Cc: kbuild-all@lists.01.org, "David Gow" <davidgow@google.com>, linux-aspeed@lists.ozlabs.org, "Maíra Canal" <maira.canal@usp.br>, openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "Matt Johnston" <matt@codeconstruct.com.au>, linux-modules@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH 2/5] kunit: flatten kunit_suite*** to kunit_suite** in .kunit_test_suites Date: Sat, 18 Jun 2022 22:49:16 +0800 [thread overview] Message-ID: <202206182258.EahbTrAv-lkp@intel.com> (raw) In-Reply-To: <20220618090310.1174932-3-davidgow@google.com> Hi David, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.19-rc2 next-20220617] [cannot apply to mcgrof/modules-next joel-aspeed/for-next ulf-hansson-mmc-mirror/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4b35035bcf80ddb47c0112c4fbd84a63a2836a18 config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220618/202206182258.EahbTrAv-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c2386c54cc9fd471e5353f375ff71734214ed3c6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 git checkout c2386c54cc9fd471e5353f375ff71734214ed3c6 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=xtensa SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> Note: the linux-review/David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 HEAD fddb3ea0ed5627098eabc542fdba5a8b4b769066 builds fine. It only hurts bisectability. All errors (new ones prefixed by >>): drivers/thunderbolt/test.c: In function 'tb_test_init': >> drivers/thunderbolt/test.c:2824:16: error: too few arguments to function '__kunit_test_suites_init' 2824 | return __kunit_test_suites_init(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/thunderbolt/test.c:9: include/kunit/test.h:240:5: note: declared here 240 | int __kunit_test_suites_init(struct kunit_suite * const * const suites, int num_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c: In function 'tb_test_exit': >> drivers/thunderbolt/test.c:2829:16: error: too few arguments to function '__kunit_test_suites_exit' 2829 | return __kunit_test_suites_exit(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/thunderbolt/test.c:9: include/kunit/test.h:242:6: note: declared here 242 | void __kunit_test_suites_exit(struct kunit_suite **suites, int num_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c:2829:16: error: 'return' with a value, in function returning void [-Werror=return-type] 2829 | return __kunit_test_suites_exit(tb_test_suites); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/test.c:2827:6: note: declared here 2827 | void tb_test_exit(void) | ^~~~~~~~~~~~ drivers/thunderbolt/test.c: In function 'tb_test_init': drivers/thunderbolt/test.c:2825:1: error: control reaches end of non-void function [-Werror=return-type] 2825 | } | ^ cc1: some warnings being treated as errors vim +/__kunit_test_suites_init +2824 drivers/thunderbolt/test.c 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2821 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2822 int tb_test_init(void) 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2823 { 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 @2824 return __kunit_test_suites_init(tb_test_suites); 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2825 } 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2826 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2827 void tb_test_exit(void) 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 2828 { 2c6ea4e2cefe2e Mika Westerberg 2020-08-24 @2829 return __kunit_test_suites_exit(tb_test_suites); -- 0-DAY CI Kernel Test Service https://01.org/lkp
next prev parent reply other threads:[~2022-06-18 14:49 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-18 9:03 [PATCH 0/5] Rework KUnit test execution in modules David Gow 2022-06-18 9:03 ` David Gow 2022-06-18 9:03 ` [PATCH 1/5] kunit: unify module and builtin suite definitions David Gow 2022-06-18 9:03 ` David Gow 2022-06-18 11:36 ` kernel test robot 2022-06-18 11:36 ` kernel test robot 2022-06-18 12:47 ` kernel test robot 2022-06-18 12:47 ` kernel test robot 2022-06-18 9:03 ` [PATCH 2/5] kunit: flatten kunit_suite*** to kunit_suite** in .kunit_test_suites David Gow 2022-06-18 9:03 ` David Gow 2022-06-18 13:58 ` kernel test robot 2022-06-18 13:58 ` kernel test robot 2022-06-18 14:49 ` kernel test robot [this message] 2022-06-18 14:49 ` kernel test robot 2022-06-18 9:03 ` [PATCH 3/5] thunderbolt: test: Use kunit_test_suite() macro David Gow 2022-06-18 9:03 ` David Gow 2022-06-20 5:05 ` Mika Westerberg 2022-06-18 9:03 ` [PATCH 4/5] nitro_enclaves: " David Gow 2022-06-18 9:03 ` David Gow 2022-06-20 9:26 ` Paraschiv, Andra-Irina 2022-06-20 9:26 ` Paraschiv, Andra-Irina 2022-06-18 9:03 ` [PATCH 5/5] mmc: sdhci-of-aspeed: " David Gow 2022-06-18 9:03 ` David Gow 2022-06-18 17:11 ` [PATCH 0/5] Rework KUnit test execution in modules Maíra Canal 2022-06-18 17:11 ` Maíra Canal 2022-06-18 17:41 ` Christophe Leroy 2022-06-18 17:41 ` Christophe Leroy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202206182258.EahbTrAv-lkp@intel.com \ --to=lkp@intel.com \ --cc=andraprs@amazon.com \ --cc=andrew@aj.id.au \ --cc=brendanhiggins@google.com \ --cc=davidgow@google.com \ --cc=dlatypov@google.com \ --cc=jk@codeconstruct.com.au \ --cc=kbuild-all@lists.01.org \ --cc=kunit-dev@googlegroups.com \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-modules@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=longpeng2@huawei.com \ --cc=maira.canal@usp.br \ --cc=matt@codeconstruct.com.au \ --cc=mcgrof@kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=openbmc@lists.ozlabs.org \ --cc=skhan@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.