Re: [PATCH v2 16/17] iio: cdc: ad7746: Move driver out of staging.

From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Peter Rosin <peda@axentia.se>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Vincent Whitchurch <vincent.whitchurch@axis.com>
Subject: Re: [PATCH v2 16/17] iio: cdc: ad7746: Move driver out of staging.
Date: Mon, 20 Jun 2022 19:30:30 +0100	[thread overview]
Message-ID: <20220620193030.4b4b1764@jic23-huawei> (raw)
In-Reply-To: <20220620174044.000061af@Huawei.com>

On Mon, 20 Jun 2022 17:40:44 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Mon, 20 Jun 2022 01:11:36 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 
> > On Sun, Jun 19, 2022 at 8:59 PM Jonathan Cameron <jic23@kernel.org> wrote:  
> > >
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > >
> > > All known major issues with this driver resolved so time to move
> > > it out of staging.
> > >
> > > Note this cleanup work was done using the roadtest framework.
> > > https://lore.kernel.org/all/20220311162445.346685-1-vincent.whitchurch@axis.com/
> > >
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > ---
> > >  drivers/iio/cdc/Kconfig          |  10 +
> > >  drivers/iio/cdc/Makefile         |   1 +
> > >  drivers/iio/cdc/ad7746.c         | 818 +++++++++++++++++++++++++++++++
> > >  drivers/staging/iio/cdc/ad7746.c | 818 -------------------------------    
> > 
> > It's a bit hard to review, perhaps you forgot to add -M -C when
> > generating this patch?  
> 
> Specifically passed --no-renames because this is a direct file move -
> I should have stated that though.
> 
> The intent is to allow review of the full driver as being proposed for
> move out of staging.  Including the bits that otherwise aren't
> visible anywhere in the driver.  I only do this (and ask for it from others)
> for staging graduation patches.
> 
> However, I've just noticed the diff doesn't include removing the entries
> from drivers/staging/iio/cdc/Kconfig + drivers/staging/iio/cdc/Makefile
> which is weird.  Will check that for v3.

Follow through from using the roadtest specific Makefile which wasn't building
staging drivers.  A normal build indeed through up that there was a clash
due to the leftover files.  Wow, I wasn't on good form whilst doing this!

Jonathan

> 
> Thanks,
> 
> Jonathan
>  
> > 
> > (Also note that `git am` able to parse renamings, the only thing which
> > should be in full in patches is when one deletes the file, although it
> > may be already supported by newest versions of Git, dunno)
> >   
> 