From: Gabriel Krisman Bertazi <krisman@collabora.com> To: viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org Cc: ebiggers@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Gabriel Krisman Bertazi <krisman@collabora.com>, kernel@collabora.com Subject: [PATCH 4/7] libfs: Support revalidation of encrypted case-insensitive dentries Date: Wed, 22 Jun 2022 15:46:00 -0400 [thread overview] Message-ID: <20220622194603.102655-5-krisman@collabora.com> (raw) In-Reply-To: <20220622194603.102655-1-krisman@collabora.com> Preserve the existing behavior for encrypted directories, by rejecting negative dentries of encrypted+casefolded directories. This allows generic_ci_d_revalidate to be used by filesystems with both features enabled, as long as the directory is either casefolded or encrypted, but not both at the same time. Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> --- fs/libfs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/libfs.c b/fs/libfs.c index de43f3f585f1..e4da68ebd618 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -1461,6 +1461,9 @@ static inline int generic_ci_d_revalidate(struct dentry *dentry, const struct inode *dir = READ_ONCE(parent->d_inode); if (dir && needs_casefold(dir)) { + if (IS_ENCRYPTED(dir)) + return 0; + if (!d_is_casefold_lookup(dentry)) return 0; @@ -1470,7 +1473,8 @@ static inline int generic_ci_d_revalidate(struct dentry *dentry, return 0; } } - return 1; + + return fscrypt_d_revalidate(dentry, flags); } static const struct dentry_operations generic_ci_dentry_ops = { @@ -1490,7 +1494,7 @@ static const struct dentry_operations generic_encrypted_dentry_ops = { static const struct dentry_operations generic_encrypted_ci_dentry_ops = { .d_hash = generic_ci_d_hash, .d_compare = generic_ci_d_compare, - .d_revalidate = fscrypt_d_revalidate, + .d_revalidate_name = generic_ci_d_revalidate, }; #endif -- 2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@collabora.com> To: viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org Cc: kernel@collabora.com, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Gabriel Krisman Bertazi <krisman@collabora.com> Subject: [f2fs-dev] [PATCH 4/7] libfs: Support revalidation of encrypted case-insensitive dentries Date: Wed, 22 Jun 2022 15:46:00 -0400 [thread overview] Message-ID: <20220622194603.102655-5-krisman@collabora.com> (raw) In-Reply-To: <20220622194603.102655-1-krisman@collabora.com> Preserve the existing behavior for encrypted directories, by rejecting negative dentries of encrypted+casefolded directories. This allows generic_ci_d_revalidate to be used by filesystems with both features enabled, as long as the directory is either casefolded or encrypted, but not both at the same time. Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> --- fs/libfs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/libfs.c b/fs/libfs.c index de43f3f585f1..e4da68ebd618 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -1461,6 +1461,9 @@ static inline int generic_ci_d_revalidate(struct dentry *dentry, const struct inode *dir = READ_ONCE(parent->d_inode); if (dir && needs_casefold(dir)) { + if (IS_ENCRYPTED(dir)) + return 0; + if (!d_is_casefold_lookup(dentry)) return 0; @@ -1470,7 +1473,8 @@ static inline int generic_ci_d_revalidate(struct dentry *dentry, return 0; } } - return 1; + + return fscrypt_d_revalidate(dentry, flags); } static const struct dentry_operations generic_ci_dentry_ops = { @@ -1490,7 +1494,7 @@ static const struct dentry_operations generic_encrypted_dentry_ops = { static const struct dentry_operations generic_encrypted_ci_dentry_ops = { .d_hash = generic_ci_d_hash, .d_compare = generic_ci_d_compare, - .d_revalidate = fscrypt_d_revalidate, + .d_revalidate_name = generic_ci_d_revalidate, }; #endif -- 2.36.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-06-22 19:47 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-22 19:45 [PATCH 0/7] Support negative dentries on case-insensitive directories Gabriel Krisman Bertazi 2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-06-22 19:45 ` [PATCH 1/7] fs: Expose name under lookup to d_revalidate hook Gabriel Krisman Bertazi 2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi 2023-03-23 14:33 ` Theodore Ts'o 2023-03-23 14:33 ` [f2fs-dev] " Theodore Ts'o 2023-03-25 13:33 ` Theodore Ts'o 2023-03-25 13:33 ` [f2fs-dev] " Theodore Ts'o 2023-03-26 5:03 ` Al Viro 2023-03-26 5:03 ` [f2fs-dev] " Al Viro 2022-06-22 19:45 ` [PATCH 2/7] fs: Add DCACHE_CASEFOLD_LOOKUP flag Gabriel Krisman Bertazi 2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi 2023-03-23 14:33 ` Theodore Ts'o 2023-03-23 14:33 ` [f2fs-dev] " Theodore Ts'o 2022-06-22 19:45 ` [PATCH 3/7] libfs: Validate negative dentries in case-insensitive directories Gabriel Krisman Bertazi 2022-06-22 19:45 ` [f2fs-dev] " Gabriel Krisman Bertazi 2023-03-23 14:36 ` Theodore Ts'o 2023-03-23 14:36 ` [f2fs-dev] " Theodore Ts'o 2023-03-26 4:46 ` Al Viro 2023-03-26 4:46 ` [f2fs-dev] " Al Viro 2023-03-31 15:31 ` Gabriel Krisman Bertazi 2023-03-31 15:31 ` Gabriel Krisman Bertazi 2022-06-22 19:46 ` Gabriel Krisman Bertazi [this message] 2022-06-22 19:46 ` [f2fs-dev] [PATCH 4/7] libfs: Support revalidation of encrypted case-insensitive dentries Gabriel Krisman Bertazi 2023-03-23 14:37 ` Theodore Ts'o 2023-03-23 14:37 ` [f2fs-dev] " Theodore Ts'o 2022-06-22 19:46 ` [PATCH 5/7] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi 2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi 2023-03-23 14:39 ` Theodore Ts'o 2023-03-23 14:39 ` [f2fs-dev] " Theodore Ts'o 2022-06-22 19:46 ` [PATCH 6/7] ext4: Enable negative dentries on case-insensitive lookup Gabriel Krisman Bertazi 2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-06-23 7:29 ` kernel test robot 2022-06-23 7:29 ` [f2fs-dev] " kernel test robot 2022-06-23 16:36 ` Gabriel Krisman Bertazi 2022-06-23 16:36 ` Gabriel Krisman Bertazi 2022-06-23 16:36 ` [f2fs-dev] " Gabriel Krisman Bertazi 2023-03-23 14:39 ` Theodore Ts'o 2023-03-23 14:39 ` [f2fs-dev] " Theodore Ts'o 2022-06-22 19:46 ` [PATCH 7/7] f2fs: " Gabriel Krisman Bertazi 2022-06-22 19:46 ` [f2fs-dev] " Gabriel Krisman Bertazi 2022-06-23 12:44 ` kernel test robot 2022-06-23 12:44 ` [f2fs-dev] " kernel test robot 2023-02-24 22:36 ` [PATCH 0/7] Support negative dentries on case-insensitive directories Daniel Rosenberg 2023-02-24 22:36 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220622194603.102655-5-krisman@collabora.com \ --to=krisman@collabora.com \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=kernel@collabora.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.