From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: joro@8bytes.org, will@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com,
baolu.lu@linux.intel.com, matthias.bgg@gmail.com,
orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, jean-philippe@linaro.org,
alex.williamson@redhat.com, kevin.tian@intel.com,
suravee.suthikulpanit@amd.com, alyssa@rosenzweig.io,
dwmw2@infradead.org, yong.wu@mediatek.com,
mjrosato@linux.ibm.com, gerald.schaefer@linux.ibm.com,
thierry.reding@gmail.com, vdumpa@nvidia.com,
jonathanh@nvidia.com, cohuck@redhat.com,
thunder.leizhen@huawei.com, tglx@linutronix.de,
chenxiang66@hisilicon.com, christophe.jaillet@wanadoo.fr,
john.garry@huawei.com, yangyingliang@huawei.com,
jordan@cosmicpenguin.net, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-s390@vger.kernel.org,
linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Fri, 24 Jun 2022 15:46:28 -0300 [thread overview]
Message-ID: <20220624184628.GY4147@nvidia.com> (raw)
In-Reply-To: <20220624182833.GW4147@nvidia.com>
On Fri, Jun 24, 2022 at 03:28:33PM -0300, Jason Gunthorpe wrote:
> On Thu, Jun 23, 2022 at 01:00:27PM -0700, Nicolin Chen wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems.
> >
> > Per Robin's remarks,
> > * While bus_set_iommu() still exists, the core code prevents multiple
> > drivers from registering, so we can't really run into a situation of
> > having a mixed-driver system:
> > https://lore.kernel.org/kvm/6e1280c5-4b22-ebb3-3912-6c72bc169982@arm.com/
> >
> > * And there's plenty more significant problems than this to fix; in future
> > when many can be permitted, we will rely on the IOMMU core code to check
> > the domain->ops:
> > https://lore.kernel.org/kvm/6575de6d-94ba-c427-5b1e-967750ddff23@arm.com/
> >
> > So remove the check in VFIO for simplicity.
>
> As discussed we can't remove this check, multiple iommus on different
> busses are allowed today and VFIO does not restrict its attempts to
> attach a pre-existing domain to a single group or bus.
>
> Please go back to the original version with the ops check in the core
> code.
Robin convinced me, so never mind :)
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: linux-s390@vger.kernel.org, cohuck@redhat.com,
jordan@cosmicpenguin.net, linux-tegra@vger.kernel.org,
thierry.reding@gmail.com, will@kernel.org, alyssa@rosenzweig.io,
jean-philippe@linaro.org, kvm@vger.kernel.org,
zhang.lyra@gmail.com, iommu@lists.linux-foundation.org,
jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org,
yangyingliang@huawei.com, orsonzhai@gmail.com,
gerald.schaefer@linux.ibm.com, kevin.tian@intel.com,
linux-arm-msm@vger.kernel.org, alex.williamson@redhat.com,
christophe.jaillet@wanadoo.fr, matthias.bgg@gmail.com,
tglx@linutronix.de, virtualization@lists.linux-foundation.org,
dwmw2@infradead.org, marcan@marcan.st,
linux-kernel@vger.kernel.org, baolin.wang7@gmail.com,
linux-mediatek@lists.infradead.org, robin.murphy@arm.com
Subject: Re: [PATCH v3 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Fri, 24 Jun 2022 15:46:28 -0300 [thread overview]
Message-ID: <20220624184628.GY4147@nvidia.com> (raw)
In-Reply-To: <20220624182833.GW4147@nvidia.com>
On Fri, Jun 24, 2022 at 03:28:33PM -0300, Jason Gunthorpe wrote:
> On Thu, Jun 23, 2022 at 01:00:27PM -0700, Nicolin Chen wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems.
> >
> > Per Robin's remarks,
> > * While bus_set_iommu() still exists, the core code prevents multiple
> > drivers from registering, so we can't really run into a situation of
> > having a mixed-driver system:
> > https://lore.kernel.org/kvm/6e1280c5-4b22-ebb3-3912-6c72bc169982@arm.com/
> >
> > * And there's plenty more significant problems than this to fix; in future
> > when many can be permitted, we will rely on the IOMMU core code to check
> > the domain->ops:
> > https://lore.kernel.org/kvm/6575de6d-94ba-c427-5b1e-967750ddff23@arm.com/
> >
> > So remove the check in VFIO for simplicity.
>
> As discussed we can't remove this check, multiple iommus on different
> busses are allowed today and VFIO does not restrict its attempts to
> attach a pre-existing domain to a single group or bus.
>
> Please go back to the original version with the ops check in the core
> code.
Robin convinced me, so never mind :)
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: linux-s390@vger.kernel.org, cohuck@redhat.com,
mjrosato@linux.ibm.com, jordan@cosmicpenguin.net,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
will@kernel.org, alyssa@rosenzweig.io, jean-philippe@linaro.org,
kvm@vger.kernel.org, zhang.lyra@gmail.com, joro@8bytes.org,
iommu@lists.linux-foundation.org, jonathanh@nvidia.com,
linux-arm-kernel@lists.infradead.org, yangyingliang@huawei.com,
orsonzhai@gmail.com, gerald.schaefer@linux.ibm.com,
kevin.tian@intel.com, sven@svenpeter.dev,
linux-arm-msm@vger.kernel.org, john.garry@huawei.com,
alex.williamson@redhat.com, christophe.jaillet@wanadoo.fr,
thunder.leizhen@huawei.com, matthias.bgg@gmail.com,
tglx@linutronix.de, virtualization@lists.linux-foundation.org,
yong.wu@mediatek.com, chenxiang66@hisilicon.com,
dwmw2@infradead.org, marcan@marcan.st,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
suravee.suthikulpanit@amd.com, baolin.wang7@gmail.com,
linux-mediatek@lists.infradead.org, robin.murphy@arm.com,
baolu.lu@linux.intel.com
Subject: Re: [PATCH v3 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Fri, 24 Jun 2022 15:46:28 -0300 [thread overview]
Message-ID: <20220624184628.GY4147@nvidia.com> (raw)
In-Reply-To: <20220624182833.GW4147@nvidia.com>
On Fri, Jun 24, 2022 at 03:28:33PM -0300, Jason Gunthorpe wrote:
> On Thu, Jun 23, 2022 at 01:00:27PM -0700, Nicolin Chen wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems.
> >
> > Per Robin's remarks,
> > * While bus_set_iommu() still exists, the core code prevents multiple
> > drivers from registering, so we can't really run into a situation of
> > having a mixed-driver system:
> > https://lore.kernel.org/kvm/6e1280c5-4b22-ebb3-3912-6c72bc169982@arm.com/
> >
> > * And there's plenty more significant problems than this to fix; in future
> > when many can be permitted, we will rely on the IOMMU core code to check
> > the domain->ops:
> > https://lore.kernel.org/kvm/6575de6d-94ba-c427-5b1e-967750ddff23@arm.com/
> >
> > So remove the check in VFIO for simplicity.
>
> As discussed we can't remove this check, multiple iommus on different
> busses are allowed today and VFIO does not restrict its attempts to
> attach a pre-existing domain to a single group or bus.
>
> Please go back to the original version with the ops check in the core
> code.
Robin convinced me, so never mind :)
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-24 18:46 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:00 [PATCH v3 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-23 20:00 ` [PATCH v3 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-24 1:35 ` Baolu Lu
2022-06-24 1:35 ` Baolu Lu
2022-06-24 1:35 ` Baolu Lu
2022-06-24 2:44 ` Nicolin Chen
2022-06-24 2:44 ` Nicolin Chen
2022-06-24 2:44 ` Nicolin Chen via iommu
2022-06-24 5:38 ` Yong Wu
2022-06-24 5:38 ` Yong Wu
2022-06-24 5:38 ` Yong Wu via iommu
2022-06-24 5:41 ` Nicolin Chen
2022-06-24 5:41 ` Nicolin Chen
2022-06-24 5:41 ` Nicolin Chen via iommu
2022-06-24 6:16 ` Tian, Kevin
2022-06-24 6:16 ` Tian, Kevin
2022-06-24 6:16 ` Tian, Kevin
2022-06-24 6:16 ` Tian, Kevin
2022-06-24 10:35 ` Yong Wu
2022-06-24 10:35 ` Yong Wu
2022-06-24 10:35 ` Yong Wu via iommu
2022-06-24 18:19 ` Jason Gunthorpe
2022-06-24 18:19 ` Jason Gunthorpe
2022-06-24 18:19 ` Jason Gunthorpe via iommu
2022-06-29 19:47 ` Nicolin Chen
2022-06-29 19:47 ` Nicolin Chen
2022-06-29 19:47 ` Nicolin Chen via iommu
2022-06-30 8:21 ` Robin Murphy
2022-06-30 8:21 ` Robin Murphy
2022-06-30 8:21 ` Robin Murphy
2022-06-30 8:21 ` Robin Murphy
2022-06-30 9:57 ` Tian, Kevin
2022-06-30 9:57 ` Tian, Kevin
2022-06-30 9:57 ` Tian, Kevin
2022-06-30 9:57 ` Tian, Kevin
2022-06-30 15:47 ` Nicolin Chen
2022-06-30 15:47 ` Nicolin Chen
2022-06-30 15:47 ` Nicolin Chen via iommu
2022-06-30 9:33 ` Yong Wu
2022-06-30 9:33 ` Yong Wu
2022-06-30 9:33 ` Yong Wu via iommu
2022-06-30 15:45 ` Nicolin Chen
2022-06-30 15:45 ` Nicolin Chen
2022-06-30 15:45 ` Nicolin Chen via iommu
2022-06-23 20:00 ` [PATCH v3 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-24 1:50 ` Baolu Lu
2022-06-24 1:50 ` Baolu Lu
2022-06-24 1:50 ` Baolu Lu
2022-06-23 20:00 ` [PATCH v3 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-24 18:28 ` Jason Gunthorpe
2022-06-24 18:28 ` Jason Gunthorpe
2022-06-24 18:28 ` Jason Gunthorpe via iommu
2022-06-24 18:46 ` Jason Gunthorpe [this message]
2022-06-24 18:46 ` Jason Gunthorpe
2022-06-24 18:46 ` Jason Gunthorpe via iommu
2022-06-23 20:00 ` [PATCH v3 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-23 20:00 ` [PATCH v3 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen
2022-06-23 20:00 ` Nicolin Chen via iommu
2022-06-27 6:57 ` Tian, Kevin
2022-06-27 6:57 ` Tian, Kevin
2022-06-27 6:57 ` Tian, Kevin
2022-06-27 6:57 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624184628.GY4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=jordan@cosmicpenguin.net \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.