From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, hsinyi@chromium.org, allen-kh.cheng@mediatek.com, gtk3@inbox.ru, luca@z3ntu.xyz, sam.shih@mediatek.com, sean.wang@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org Subject: Re: [PATCH 04/11] arm64: dts: mediatek: cherry: Add platform regulators layout and config Date: Fri, 1 Jul 2022 18:26:09 -0400 [thread overview] Message-ID: <20220701222609.w6nowe5ng4ndszol@notapiano> (raw) In-Reply-To: <20220630153316.308767-5-angelogioacchino.delregno@collabora.com> On Thu, Jun 30, 2022 at 05:33:09PM +0200, AngeloGioacchino Del Regno wrote: > Add the regulators layout for this platform, including the basic power > rails controlled by the EC (and/or always on). > Moreover, include the MT6359 PMIC devicetree and add some configuration > for its regulators, essential to keep the machine alive after booting. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../boot/dts/mediatek/mt8195-cherry.dtsi | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > index 14f8f30b1eb3..091338f7d5ff 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > @@ -5,6 +5,7 @@ > > #include <dt-bindings/gpio/gpio.h> > #include "mt8195.dtsi" > +#include "mt6359.dtsi" > > / { > aliases { > @@ -19,6 +20,107 @@ memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x80000000>; > }; > + > + /* system wide LDO 3.3V power rail */ > + pp3300_z5: regulator-3v3-pp3300-ldo-z5 { I wouldn't have both "3v3" and "pp3300" in the node name since they mean the same thing, but feel free to ignore this comment :). > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_ldo_z5"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&ppvar_sys>; > + }; > + > + /* separately switched 3.3V power rail */ > + pp3300_s3: regulator-3v3-pp3300-s3 { > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_s3"; > + /* automatically sequenced by PMIC EXT_PMIC_EN2 */ > + regulator-always-on; > + regulator-boot-on; Missing regulator-min/max-microvolt? > + vin-supply = <&pp3300_z2>; > + }; [..] > -- > 2.35.1 > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, hsinyi@chromium.org, allen-kh.cheng@mediatek.com, gtk3@inbox.ru, luca@z3ntu.xyz, sam.shih@mediatek.com, sean.wang@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org Subject: Re: [PATCH 04/11] arm64: dts: mediatek: cherry: Add platform regulators layout and config Date: Fri, 1 Jul 2022 18:26:09 -0400 [thread overview] Message-ID: <20220701222609.w6nowe5ng4ndszol@notapiano> (raw) In-Reply-To: <20220630153316.308767-5-angelogioacchino.delregno@collabora.com> On Thu, Jun 30, 2022 at 05:33:09PM +0200, AngeloGioacchino Del Regno wrote: > Add the regulators layout for this platform, including the basic power > rails controlled by the EC (and/or always on). > Moreover, include the MT6359 PMIC devicetree and add some configuration > for its regulators, essential to keep the machine alive after booting. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../boot/dts/mediatek/mt8195-cherry.dtsi | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > index 14f8f30b1eb3..091338f7d5ff 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > @@ -5,6 +5,7 @@ > > #include <dt-bindings/gpio/gpio.h> > #include "mt8195.dtsi" > +#include "mt6359.dtsi" > > / { > aliases { > @@ -19,6 +20,107 @@ memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x80000000>; > }; > + > + /* system wide LDO 3.3V power rail */ > + pp3300_z5: regulator-3v3-pp3300-ldo-z5 { I wouldn't have both "3v3" and "pp3300" in the node name since they mean the same thing, but feel free to ignore this comment :). > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_ldo_z5"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&ppvar_sys>; > + }; > + > + /* separately switched 3.3V power rail */ > + pp3300_s3: regulator-3v3-pp3300-s3 { > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_s3"; > + /* automatically sequenced by PMIC EXT_PMIC_EN2 */ > + regulator-always-on; > + regulator-boot-on; Missing regulator-min/max-microvolt? > + vin-supply = <&pp3300_z2>; > + }; [..] > -- > 2.35.1 > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-01 22:26 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-30 15:33 [PATCH 00/11] MT8195 Chromebooks devicetrees - Google Tomato AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-06-30 15:33 ` [PATCH 01/11] dt-bindings: arm: mediatek: Add MT8195 Cherry Tomato Chromebooks AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-06-30 18:26 ` Krzysztof Kozlowski 2022-06-30 18:26 ` Krzysztof Kozlowski 2022-07-01 15:31 ` Nícolas F. R. A. Prado 2022-07-01 15:31 ` Nícolas F. R. A. Prado 2022-07-04 8:51 ` AngeloGioacchino Del Regno 2022-07-04 8:51 ` AngeloGioacchino Del Regno 2022-07-01 22:04 ` Nícolas F. R. A. Prado 2022-07-01 22:04 ` Nícolas F. R. A. Prado 2022-07-04 8:56 ` AngeloGioacchino Del Regno 2022-07-04 8:56 ` AngeloGioacchino Del Regno 2022-06-30 15:33 ` [PATCH 02/11] arm64: dts: mediatek: Introduce MT8195 Cherry platform's Tomato AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:11 ` Nícolas F. R. A. Prado 2022-07-01 22:11 ` Nícolas F. R. A. Prado 2022-07-04 4:17 ` Chen-Yu Tsai 2022-07-04 4:17 ` Chen-Yu Tsai 2022-07-04 8:59 ` AngeloGioacchino Del Regno 2022-07-04 8:59 ` AngeloGioacchino Del Regno 2022-07-04 9:05 ` Chen-Yu Tsai 2022-07-04 9:05 ` Chen-Yu Tsai 2022-07-04 9:06 ` AngeloGioacchino Del Regno 2022-07-04 9:06 ` AngeloGioacchino Del Regno 2022-06-30 15:33 ` [PATCH 03/11] arm64: dts: mediatek: cherry: Assign interrupt line to MT6359 PMIC AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:20 ` Nícolas F. R. A. Prado 2022-07-01 22:20 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 04/11] arm64: dts: mediatek: cherry: Add platform regulators layout and config AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:26 ` Nícolas F. R. A. Prado [this message] 2022-07-01 22:26 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 05/11] arm64: dts: mediatek: cherry: Add support for internal eMMC storage AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:36 ` Nícolas F. R. A. Prado 2022-07-01 22:36 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 06/11] arm64: dts: mediatek: cherry: Document gpios and add default pin config AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:39 ` Nícolas F. R. A. Prado 2022-07-01 22:39 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 07/11] arm64: dts: mediatek: cherry: Enable I2C and SPI controllers AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:42 ` Nícolas F. R. A. Prado 2022-07-01 22:42 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 08/11] arm64: dts: mediatek: cherry: Enable T-PHYs and USB XHCI controllers AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:43 ` Nícolas F. R. A. Prado 2022-07-01 22:43 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 09/11] arm64: dts: mediatek: cherry: Enable MT6360 sub-pmic on I2C7 AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:45 ` Nícolas F. R. A. Prado 2022-07-01 22:45 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 10/11] arm64: dts: mediatek: cherry: Enable support for the SPI NOR flash AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:47 ` Nícolas F. R. A. Prado 2022-07-01 22:47 ` Nícolas F. R. A. Prado 2022-06-30 15:33 ` [PATCH 11/11] arm64: dts: mediatek: cherry: Add I2C-HID touchscreen on I2C4 AngeloGioacchino Del Regno 2022-06-30 15:33 ` AngeloGioacchino Del Regno 2022-07-01 22:49 ` Nícolas F. R. A. Prado 2022-07-01 22:49 ` Nícolas F. R. A. Prado
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220701222609.w6nowe5ng4ndszol@notapiano \ --to=nfraprado@collabora.com \ --cc=allen-kh.cheng@mediatek.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=gtk3@inbox.ru \ --cc=hsinyi@chromium.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=luca@z3ntu.xyz \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sam.shih@mediatek.com \ --cc=sean.wang@mediatek.com \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.