From: Bjorn Helgaas <helgaas@kernel.org> To: Richard Zhu <hongxing.zhu@nxp.com> Cc: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, festevam@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [RFC 1/2] PCI: imx6: Make sure the DBI register can be changed Date: Mon, 11 Jul 2022 17:17:01 -0500 [thread overview] Message-ID: <20220711221701.GA697090@bhelgaas> (raw) In-Reply-To: <1652866528-13220-1-git-send-email-hongxing.zhu@nxp.com> Hi Richard, On Wed, May 18, 2022 at 05:35:27PM +0800, Richard Zhu wrote: > The PCIE_DBI_RO_WR_EN bit should be set when write some DBI registers. > To make sure that the DBI registers are writable, set the > PCIE_DBI_RO_WR_EN properly when touch the DBI registers. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > drivers/pci/controller/dwc/pci-imx6.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 6619e3caffe2..30641d2dda14 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -797,10 +797,12 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > * started in Gen2 mode, there is a possibility the devices on the > * bus will not be detected at all. This happens with PCIe switches. > */ > + dw_pcie_dbi_ro_wr_en(pci); What's the status of this patch? I don't see this change included in your v14 series [1]. That series has a lot of imx6 updates, so I would have thought you'd include this change in it. Or maybe this change turned out not to be needed? What about the 2/2 patch? They're both marked "RFC" which is sometimes a hint that the author isn't really committed to the patch, so sometimes they don't get the attention they deserve. Bjorn [1] https://lore.kernel.org/r/1656645935-1370-1-git-send-email-hongxing.zhu@nxp.com > tmp = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP); > tmp &= ~PCI_EXP_LNKCAP_SLS; > tmp |= PCI_EXP_LNKCAP_SLS_2_5GB; > dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, tmp); > + dw_pcie_dbi_ro_wr_dis(pci); > > /* Start LTSSM. */ > imx6_pcie_ltssm_enable(dev); > @@ -809,6 +811,7 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > > if (pci->link_gen == 2) { > /* Allow Gen2 mode after the link is up. */ > + dw_pcie_dbi_ro_wr_en(pci); > tmp = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP); > tmp &= ~PCI_EXP_LNKCAP_SLS; > tmp |= PCI_EXP_LNKCAP_SLS_5_0GB; > @@ -821,6 +824,7 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > tmp = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); > tmp |= PORT_LOGIC_SPEED_CHANGE; > dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); > + dw_pcie_dbi_ro_wr_dis(pci); > > if (imx6_pcie->drvdata->flags & > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE) { > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: Richard Zhu <hongxing.zhu@nxp.com> Cc: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, festevam@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [RFC 1/2] PCI: imx6: Make sure the DBI register can be changed Date: Mon, 11 Jul 2022 17:17:01 -0500 [thread overview] Message-ID: <20220711221701.GA697090@bhelgaas> (raw) In-Reply-To: <1652866528-13220-1-git-send-email-hongxing.zhu@nxp.com> Hi Richard, On Wed, May 18, 2022 at 05:35:27PM +0800, Richard Zhu wrote: > The PCIE_DBI_RO_WR_EN bit should be set when write some DBI registers. > To make sure that the DBI registers are writable, set the > PCIE_DBI_RO_WR_EN properly when touch the DBI registers. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > drivers/pci/controller/dwc/pci-imx6.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 6619e3caffe2..30641d2dda14 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -797,10 +797,12 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > * started in Gen2 mode, there is a possibility the devices on the > * bus will not be detected at all. This happens with PCIe switches. > */ > + dw_pcie_dbi_ro_wr_en(pci); What's the status of this patch? I don't see this change included in your v14 series [1]. That series has a lot of imx6 updates, so I would have thought you'd include this change in it. Or maybe this change turned out not to be needed? What about the 2/2 patch? They're both marked "RFC" which is sometimes a hint that the author isn't really committed to the patch, so sometimes they don't get the attention they deserve. Bjorn [1] https://lore.kernel.org/r/1656645935-1370-1-git-send-email-hongxing.zhu@nxp.com > tmp = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP); > tmp &= ~PCI_EXP_LNKCAP_SLS; > tmp |= PCI_EXP_LNKCAP_SLS_2_5GB; > dw_pcie_writel_dbi(pci, offset + PCI_EXP_LNKCAP, tmp); > + dw_pcie_dbi_ro_wr_dis(pci); > > /* Start LTSSM. */ > imx6_pcie_ltssm_enable(dev); > @@ -809,6 +811,7 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > > if (pci->link_gen == 2) { > /* Allow Gen2 mode after the link is up. */ > + dw_pcie_dbi_ro_wr_en(pci); > tmp = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP); > tmp &= ~PCI_EXP_LNKCAP_SLS; > tmp |= PCI_EXP_LNKCAP_SLS_5_0GB; > @@ -821,6 +824,7 @@ static int imx6_pcie_start_link(struct dw_pcie *pci) > tmp = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); > tmp |= PORT_LOGIC_SPEED_CHANGE; > dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, tmp); > + dw_pcie_dbi_ro_wr_dis(pci); > > if (imx6_pcie->drvdata->flags & > IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE) { > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 22:17 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 9:35 [RFC 1/2] PCI: imx6: Make sure the DBI register can be changed Richard Zhu 2022-05-18 9:35 ` Richard Zhu 2022-05-18 9:35 ` [RFC 2/2] PCI: imx6: Support more than Gen2 speed link mode Richard Zhu 2022-05-18 9:35 ` Richard Zhu 2022-07-20 0:59 ` Tim Harvey 2022-07-20 0:59 ` Tim Harvey 2022-07-20 1:43 ` Hongxing Zhu 2022-07-20 1:43 ` Hongxing Zhu 2022-07-20 3:07 ` Hongxing Zhu 2022-07-20 3:07 ` Hongxing Zhu 2022-07-11 22:17 ` Bjorn Helgaas [this message] 2022-07-11 22:17 ` [RFC 1/2] PCI: imx6: Make sure the DBI register can be changed Bjorn Helgaas 2022-07-12 1:30 ` Hongxing Zhu 2022-07-12 1:30 ` Hongxing Zhu 2022-07-12 19:26 ` Bjorn Helgaas 2022-07-12 19:26 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220711221701.GA697090@bhelgaas \ --to=helgaas@kernel.org \ --cc=bhelgaas@google.com \ --cc=festevam@gmail.com \ --cc=hongxing.zhu@nxp.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.