From: Xu Yilun <yilun.xu@intel.com> To: "Manne, Nava kishore" <nava.kishore.manne@amd.com> Cc: Nava kishore Manne <nava.manne@xilinx.com>, "mdf@kernel.org" <mdf@kernel.org>, "hao.wu@intel.com" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "michal.simek@xilinx.com" <michal.simek@xilinx.com>, "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "git@xilinx.com" <git@xilinx.com>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v2 2/3] fpga: region: Add fpga-region 'power-domains' property Date: Thu, 21 Jul 2022 14:54:54 +0800 [thread overview] Message-ID: <20220721065454.GA1689481@yilunxu-OptiPlex-7050> (raw) In-Reply-To: <DM6PR12MB39937A19AE147CD9105C8D52CD8C9@DM6PR12MB3993.namprd12.prod.outlook.com> On Mon, Jul 18, 2022 at 06:46:32AM +0000, Manne, Nava kishore wrote: > Hi Yilun, > > Please find my response inline. > > > -----Original Message----- > > From: Xu Yilun <yilun.xu@intel.com> > > Sent: Friday, June 24, 2022 9:58 PM > > To: Nava kishore Manne <nava.manne@xilinx.com> > > Cc: mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; > > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > michal.simek@xilinx.com; linux-fpga@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; git@xilinx.com; Rob Herring <robh@kernel.org> > > Subject: Re: [PATCH v2 2/3] fpga: region: Add fpga-region 'power-domains' > > property > > > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > On Mon, May 23, 2022 at 07:15:16PM +0530, Nava kishore Manne wrote: > > > Add fpga-region 'power-domains' property to allow to handle the > > > FPGA/PL power domains. > > > > > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > > > Acked-by: Rob Herring <robh@kernel.org> > > > --- > > > Changes for v2: > > > - Updated power-domains description. > > > > > > .../devicetree/bindings/fpga/fpga-region.txt | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > index 7d3515264838..f299c3749505 100644 > > > --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > @@ -196,6 +196,20 @@ Optional properties: > > > - config-complete-timeout-us : The maximum time in microseconds time > > for the > > > FPGA to go to operating mode after the region has been programmed. > > > - child nodes : devices in the FPGA after programming. > > > +- power-domains : A phandle and power domain specifier pair to the > > power domain > > > + which is responsible for turning on/off the power to the FPGA/PL > > region. > > > > Could you help explain what is PL? > > > > > +Example: > > > + fpga_full: fpga-full { > > > + compatible = "fpga-region"; > > > + fpga-mgr = <&zynqmp_pcap>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + power-domains = <&zynqmp_firmware PL_PD>; > > > + }; > > > + > > > + The PL_PD power domain will be turned on before loading the > > > +bitstream and turned off while removing/unloading the bitstream using > > overlays. > > > > I think the single power-domain may not cover some use cases that of-fpga- > > region driver supports. > > I am not sure which use case you are talking about. Can you please point me the exact use case here? > > > It is possible there are already devices in fpga-region > > for static OF tree, or an overlay with no 'firmware-name' but 'external-fpga- > > config'. In these cases power domains may still be needed, is it? > > > > It's an optional property user can decide whether he needs this support or not for 'external-fpga-config > Use case. If an external-fpga-config FPGA region needs to enable a power domain before sub devices population, how could it config the DT? I assume in this patch "power-domains" property is only used before & after reconfiguration but external-fpga-config FPGA region may need no reconfiguration. > > > Another case is the fpga-region may need multiple power domains? > > > > In our use case full region and relevant partial regions have different power domains and > this patch is capable of handle different power domain regions (full and partial regions) If a FPGA region needs 2 or more power domains for partial reconfiguration, how could we find out and enable them all? From the 2 cases, I see as a generic driver, there may be need to enable different power domains at different moments. And I'm afraid a simple implementation of pm_runtime_get before reconfiguration may limit the usage of "power-domains" property for of-fpga-region. Thanks, Yilun > > > Since the of-fpga-region driver is a generic fpga-region driver, we may > > investigate more for a compatible power-domain solution. > > > > Please share your thoughts here we will try to align with it. > > Regards, > Navakishore.
WARNING: multiple messages have this Message-ID (diff)
From: Xu Yilun <yilun.xu@intel.com> To: "Manne, Nava kishore" <nava.kishore.manne@amd.com> Cc: Nava kishore Manne <nava.manne@xilinx.com>, "mdf@kernel.org" <mdf@kernel.org>, "hao.wu@intel.com" <hao.wu@intel.com>, "trix@redhat.com" <trix@redhat.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "michal.simek@xilinx.com" <michal.simek@xilinx.com>, "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "git@xilinx.com" <git@xilinx.com>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH v2 2/3] fpga: region: Add fpga-region 'power-domains' property Date: Thu, 21 Jul 2022 14:54:54 +0800 [thread overview] Message-ID: <20220721065454.GA1689481@yilunxu-OptiPlex-7050> (raw) In-Reply-To: <DM6PR12MB39937A19AE147CD9105C8D52CD8C9@DM6PR12MB3993.namprd12.prod.outlook.com> On Mon, Jul 18, 2022 at 06:46:32AM +0000, Manne, Nava kishore wrote: > Hi Yilun, > > Please find my response inline. > > > -----Original Message----- > > From: Xu Yilun <yilun.xu@intel.com> > > Sent: Friday, June 24, 2022 9:58 PM > > To: Nava kishore Manne <nava.manne@xilinx.com> > > Cc: mdf@kernel.org; hao.wu@intel.com; trix@redhat.com; > > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > michal.simek@xilinx.com; linux-fpga@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; git@xilinx.com; Rob Herring <robh@kernel.org> > > Subject: Re: [PATCH v2 2/3] fpga: region: Add fpga-region 'power-domains' > > property > > > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > On Mon, May 23, 2022 at 07:15:16PM +0530, Nava kishore Manne wrote: > > > Add fpga-region 'power-domains' property to allow to handle the > > > FPGA/PL power domains. > > > > > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > > > Acked-by: Rob Herring <robh@kernel.org> > > > --- > > > Changes for v2: > > > - Updated power-domains description. > > > > > > .../devicetree/bindings/fpga/fpga-region.txt | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > index 7d3515264838..f299c3749505 100644 > > > --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt > > > @@ -196,6 +196,20 @@ Optional properties: > > > - config-complete-timeout-us : The maximum time in microseconds time > > for the > > > FPGA to go to operating mode after the region has been programmed. > > > - child nodes : devices in the FPGA after programming. > > > +- power-domains : A phandle and power domain specifier pair to the > > power domain > > > + which is responsible for turning on/off the power to the FPGA/PL > > region. > > > > Could you help explain what is PL? > > > > > +Example: > > > + fpga_full: fpga-full { > > > + compatible = "fpga-region"; > > > + fpga-mgr = <&zynqmp_pcap>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges; > > > + power-domains = <&zynqmp_firmware PL_PD>; > > > + }; > > > + > > > + The PL_PD power domain will be turned on before loading the > > > +bitstream and turned off while removing/unloading the bitstream using > > overlays. > > > > I think the single power-domain may not cover some use cases that of-fpga- > > region driver supports. > > I am not sure which use case you are talking about. Can you please point me the exact use case here? > > > It is possible there are already devices in fpga-region > > for static OF tree, or an overlay with no 'firmware-name' but 'external-fpga- > > config'. In these cases power domains may still be needed, is it? > > > > It's an optional property user can decide whether he needs this support or not for 'external-fpga-config > Use case. If an external-fpga-config FPGA region needs to enable a power domain before sub devices population, how could it config the DT? I assume in this patch "power-domains" property is only used before & after reconfiguration but external-fpga-config FPGA region may need no reconfiguration. > > > Another case is the fpga-region may need multiple power domains? > > > > In our use case full region and relevant partial regions have different power domains and > this patch is capable of handle different power domain regions (full and partial regions) If a FPGA region needs 2 or more power domains for partial reconfiguration, how could we find out and enable them all? From the 2 cases, I see as a generic driver, there may be need to enable different power domains at different moments. And I'm afraid a simple implementation of pm_runtime_get before reconfiguration may limit the usage of "power-domains" property for of-fpga-region. Thanks, Yilun > > > Since the of-fpga-region driver is a generic fpga-region driver, we may > > investigate more for a compatible power-domain solution. > > > > Please share your thoughts here we will try to align with it. > > Regards, > Navakishore. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-21 7:03 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-23 13:45 [PATCH v2 0/3]Enable PM generic domain support Nava kishore Manne 2022-05-23 13:45 ` Nava kishore Manne 2022-05-23 13:45 ` [PATCH v2 1/3] dt-bindings: zynqmp: Add new PD_PL macro Nava kishore Manne 2022-05-23 13:45 ` Nava kishore Manne 2022-05-23 13:45 ` [PATCH v2 2/3] fpga: region: Add fpga-region 'power-domains' property Nava kishore Manne 2022-05-23 13:45 ` Nava kishore Manne 2022-06-24 16:28 ` Xu Yilun 2022-06-24 16:28 ` Xu Yilun 2022-07-18 6:46 ` Manne, Nava kishore 2022-07-18 6:46 ` Manne, Nava kishore 2022-07-21 6:54 ` Xu Yilun [this message] 2022-07-21 6:54 ` Xu Yilun 2022-08-16 10:22 ` Manne, Nava kishore 2022-08-16 10:22 ` Manne, Nava kishore 2022-08-18 2:58 ` Xu Yilun 2022-08-18 2:58 ` Xu Yilun 2022-07-21 7:38 ` Krzysztof Kozlowski 2022-07-21 7:38 ` Krzysztof Kozlowski 2022-05-23 13:45 ` [PATCH v2 3/3] fpga: region: Add runtime PM support Nava kishore Manne 2022-05-23 13:45 ` Nava kishore Manne 2022-06-20 5:38 ` Manne, Nava kishore 2022-06-20 5:38 ` Manne, Nava kishore 2022-06-20 7:34 ` Xu Yilun 2022-06-20 7:34 ` Xu Yilun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220721065454.GA1689481@yilunxu-OptiPlex-7050 \ --to=yilun.xu@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=git@xilinx.com \ --cc=hao.wu@intel.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=nava.kishore.manne@amd.com \ --cc=nava.manne@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.