From: Jakub Kicinski <kuba@kernel.org>
To: Hawkins Jiawei <yin31149@gmail.com>
Cc: kafai@fb.com, 18801353760@163.com, andrii@kernel.org,
ast@kernel.org, borisp@nvidia.com, bpf@vger.kernel.org,
daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com,
guwen@linux.alibaba.com, jakub@cloudflare.com,
john.fastabend@gmail.com, kgraul@linux.ibm.com,
kpsingh@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, paskripkin@gmail.com,
skhan@linuxfoundation.org, songliubraving@fb.com,
syzbot+5f26f85569bd179c18ce@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, yhs@fb.com
Subject: Re: [PATCH v4] net: fix refcount bug in sk_psock_get (2)
Date: Thu, 4 Aug 2022 08:29:13 -0700 [thread overview]
Message-ID: <20220804082913.5dac303c@kernel.org> (raw)
In-Reply-To: <20220804030514.7118-1-yin31149@gmail.com>
On Thu, 4 Aug 2022 11:05:15 +0800 Hawkins Jiawei wrote:
> I wonder if it is proper to gather these together in a patchset, for
> they are all about flags in sk_user_data, maybe:
>
> [PATCH v5 0/2] net: enhancement to flags in sk_user_data field
> - introduce the patchset
>
> [PATCH v5 1/2] net: clean up code for flags in sk_user_data field
> - refactor the things in include/linux/skmsg.h and
> include/net/sock.h
> - refactor the flags's usage by other code, such as
> net/core/skmsg.c and kernel/bpf/reuseport_array.c
>
> [PATCH v5 2/2] net: fix refcount bug in sk_psock_get (2)
> - add SK_USER_DATA_PSOCK flag in sk_user_data field
Usually the fix comes first, because it needs to be backported to
stable, and we don't want to have to pull extra commits into stable
and risk regressions in code which was not directly involved in the bug.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Hawkins Jiawei <yin31149@gmail.com>
Cc: songliubraving@fb.com, kafai@fb.com, ast@kernel.org,
edumazet@google.com, jakub@cloudflare.com, daniel@iogearbox.net,
borisp@nvidia.com, paskripkin@gmail.com,
john.fastabend@gmail.com, andrii@kernel.org, yhs@fb.com,
pabeni@redhat.com,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+5f26f85569bd179c18ce@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, kpsingh@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kgraul@linux.ibm.com, guwen@linux.alibaba.com,
bpf@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v4] net: fix refcount bug in sk_psock_get (2)
Date: Thu, 4 Aug 2022 08:29:13 -0700 [thread overview]
Message-ID: <20220804082913.5dac303c@kernel.org> (raw)
In-Reply-To: <20220804030514.7118-1-yin31149@gmail.com>
On Thu, 4 Aug 2022 11:05:15 +0800 Hawkins Jiawei wrote:
> I wonder if it is proper to gather these together in a patchset, for
> they are all about flags in sk_user_data, maybe:
>
> [PATCH v5 0/2] net: enhancement to flags in sk_user_data field
> - introduce the patchset
>
> [PATCH v5 1/2] net: clean up code for flags in sk_user_data field
> - refactor the things in include/linux/skmsg.h and
> include/net/sock.h
> - refactor the flags's usage by other code, such as
> net/core/skmsg.c and kernel/bpf/reuseport_array.c
>
> [PATCH v5 2/2] net: fix refcount bug in sk_psock_get (2)
> - add SK_USER_DATA_PSOCK flag in sk_user_data field
Usually the fix comes first, because it needs to be backported to
stable, and we don't want to have to pull extra commits into stable
and risk regressions in code which was not directly involved in the bug.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-08-04 15:29 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 15:34 [syzbot] WARNING: refcount bug in sk_psock_get (2) syzbot
2022-07-09 2:46 ` [PATCH] smc: fix " Hawkins Jiawei
2022-07-09 2:46 ` Hawkins Jiawei
2022-07-09 3:06 ` Jakub Kicinski
2022-07-09 3:06 ` Jakub Kicinski
2022-07-09 8:36 ` Hawkins Jiawei
2022-07-09 8:36 ` Hawkins Jiawei
2022-07-11 7:21 ` Wen Gu
2022-07-11 7:21 ` Wen Gu
2022-07-13 3:10 ` Hawkins Jiawei
2022-07-13 3:10 ` Hawkins Jiawei
2022-07-13 3:33 ` Jakub Kicinski
2022-07-13 3:33 ` Jakub Kicinski
2022-07-13 3:53 ` Hawkins Jiawei
2022-07-13 3:53 ` Hawkins Jiawei
2022-07-12 9:47 ` Dan Carpenter
2022-07-12 9:47 ` Dan Carpenter
2022-07-13 3:35 ` Hawkins Jiawei
2022-07-13 3:35 ` Hawkins Jiawei
2022-07-30 8:56 ` [PATCH v2] net/smc: " Hawkins Jiawei
2022-07-30 8:56 ` Hawkins Jiawei
2022-08-01 9:09 ` Jakub Sitnicki
2022-08-01 9:09 ` Jakub Sitnicki via Linux-kernel-mentees
2022-08-02 14:32 ` Hawkins Jiawei
2022-08-02 14:32 ` Hawkins Jiawei
2022-08-03 8:03 ` [PATCH v3] " Hawkins Jiawei
2022-08-03 8:03 ` Hawkins Jiawei
2022-08-03 11:27 ` Wen Gu
2022-08-03 11:27 ` Wen Gu
2022-08-03 12:07 ` Hawkins Jiawei
2022-08-03 12:07 ` Hawkins Jiawei
2022-08-03 12:41 ` [PATCH v4] net: " Hawkins Jiawei
2022-08-03 12:41 ` Hawkins Jiawei
2022-08-03 15:14 ` Jakub Kicinski
2022-08-03 15:14 ` Jakub Kicinski
2022-08-03 15:37 ` Martin KaFai Lau
2022-08-03 15:37 ` Martin KaFai Lau via Linux-kernel-mentees
2022-08-04 3:05 ` Hawkins Jiawei
2022-08-04 3:05 ` Hawkins Jiawei
2022-08-04 15:29 ` Jakub Kicinski [this message]
2022-08-04 15:29 ` Jakub Kicinski
2022-08-05 6:28 ` Hawkins Jiawei
2022-08-05 6:28 ` Hawkins Jiawei
2022-08-05 7:36 ` [PATCH net v5 0/2] net: enhancements to sk_user_data field Hawkins Jiawei
2022-08-05 7:36 ` Hawkins Jiawei
2022-08-05 7:48 ` [PATCH net v5 1/2] net: fix refcount bug in sk_psock_get (2) Hawkins Jiawei
2022-08-05 7:48 ` Hawkins Jiawei
2022-08-05 7:48 ` [PATCH net v5 2/2] net: refactor bpf_sk_reuseport_detach() Hawkins Jiawei
2022-08-05 7:48 ` Hawkins Jiawei
2022-08-15 18:24 ` Martin KaFai Lau via Linux-kernel-mentees
2022-08-15 18:24 ` Martin KaFai Lau
2022-08-05 10:29 ` [PATCH net v5 0/2] net: enhancements to sk_user_data field Jakub Sitnicki
2022-08-05 10:29 ` Jakub Sitnicki via Linux-kernel-mentees
2022-08-05 15:36 ` Hawkins Jiawei
2022-08-05 15:36 ` Hawkins Jiawei
2022-08-11 5:30 ` patchwork-bot+netdevbpf
2022-08-11 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804082913.5dac303c@kernel.org \
--to=kuba@kernel.org \
--cc=18801353760@163.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=borisp@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kgraul@linux.ibm.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paskripkin@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=songliubraving@fb.com \
--cc=syzbot+5f26f85569bd179c18ce@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yhs@fb.com \
--cc=yin31149@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.