All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lee Jones <lee@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	MandyJH Liu <mandyjh.liu@mediatek.com>
Cc: <iommu@lists.linux.dev>, <linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v6 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node
Date: Thu, 11 Aug 2022 10:57:55 +0800	[thread overview]
Message-ID: <20220811025813.21492-3-tinghan.shen@mediatek.com> (raw)
In-Reply-To: <20220811025813.21492-1-tinghan.shen@mediatek.com>

The max clock items for the dts node with compatible
'mediatek,mt8195-smi-sub-common' should be 3.

However, the dtbs_check of such node will get following message,
arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long
         From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml

It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
matches the 'else' conditions for gen2 HW without gals.

Rewrite the 'else' condition to specifically identify the compatibles
that utilizing gen2 HW without gals.

Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../memory-controllers/mediatek,smi-common.yaml       | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index 71bc5cefb49cf..4f5dd0a20109e 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -144,7 +144,16 @@ allOf:
             - const: gals0
             - const: gals1
 
-    else:  # for gen2 HW that don't have gals
+  - if:  # for gen2 HW that don't have gals
+      properties:
+        compatible:
+          enum:
+            - mediatek,mt2712-smi-common
+            - mediatek,mt6795-smi-common
+            - mediatek,mt8167-smi-common
+            - mediatek,mt8173-smi-common
+
+    then:
       properties:
         clocks:
           minItems: 2
-- 
2.18.0


WARNING: multiple messages have this Message-ID (diff)
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lee Jones <lee@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	MandyJH Liu <mandyjh.liu@mediatek.com>
Cc: <iommu@lists.linux.dev>, <linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v6 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node
Date: Thu, 11 Aug 2022 10:57:55 +0800	[thread overview]
Message-ID: <20220811025813.21492-3-tinghan.shen@mediatek.com> (raw)
In-Reply-To: <20220811025813.21492-1-tinghan.shen@mediatek.com>

The max clock items for the dts node with compatible
'mediatek,mt8195-smi-sub-common' should be 3.

However, the dtbs_check of such node will get following message,
arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long
         From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml

It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
matches the 'else' conditions for gen2 HW without gals.

Rewrite the 'else' condition to specifically identify the compatibles
that utilizing gen2 HW without gals.

Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../memory-controllers/mediatek,smi-common.yaml       | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index 71bc5cefb49cf..4f5dd0a20109e 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -144,7 +144,16 @@ allOf:
             - const: gals0
             - const: gals1
 
-    else:  # for gen2 HW that don't have gals
+  - if:  # for gen2 HW that don't have gals
+      properties:
+        compatible:
+          enum:
+            - mediatek,mt2712-smi-common
+            - mediatek,mt6795-smi-common
+            - mediatek,mt8167-smi-common
+            - mediatek,mt8173-smi-common
+
+    then:
       properties:
         clocks:
           minItems: 2
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-11  2:59 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  2:57 [PATCH v6 00/20] Add driver nodes for MT8195 SoC Tinghan Shen
2022-08-11  2:57 ` Tinghan Shen
2022-08-11  2:57 ` [PATCH v6 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-08-11  2:57   ` Tinghan Shen
2022-08-25 13:41   ` Matthias Brugger
2022-08-25 13:41     ` Matthias Brugger
2022-08-11  2:57 ` Tinghan Shen [this message]
2022-08-11  2:57   ` [PATCH v6 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-08-11  6:31   ` Krzysztof Kozlowski
2022-08-11  6:31     ` Krzysztof Kozlowski
2022-08-11  2:57 ` [PATCH v6 03/20] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-08-11  2:57   ` Tinghan Shen
2022-08-11  2:57 ` [PATCH v6 04/20] dt-bindings: power: mediatek: Support naming power controller node with unit address Tinghan Shen
2022-08-11  2:57   ` Tinghan Shen
2022-08-11  2:57 ` [PATCH v6 05/20] dt-bindings: power: mediatek: Update maintainer list Tinghan Shen
2022-08-11  2:57   ` Tinghan Shen
2022-08-11  2:57 ` [PATCH v6 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-08-11  2:57   ` Tinghan Shen
2022-08-11  7:05   ` Lee Jones
2022-08-11  7:05     ` Lee Jones
2022-08-11  2:58 ` [PATCH v6 07/20] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 08/20] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 09/20] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 10/20] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 11/20] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 12/20] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 13/20] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 14/20] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 15/20] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 16/20] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 17/20] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 18/20] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 19/20] arm64: dts: mt8195: Add gce node Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-11  2:58 ` [PATCH v6 20/20] arm64: dts: mt8195: Add display node for vdosys0 Tinghan Shen
2022-08-11  2:58   ` Tinghan Shen
2022-08-25 14:52 ` [PATCH v6 00/20] Add driver nodes for MT8195 SoC Matthias Brugger
2022-08-25 14:52   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811025813.21492-3-tinghan.shen@mediatek.com \
    --to=tinghan.shen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mandyjh.liu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.