Re: forcing an in-body From header

From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: Git Mailing List <git@vger.kernel.org>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: forcing an in-body From header
Date: Fri, 26 Aug 2022 12:48:28 -0400	[thread overview]
Message-ID: <20220826164828.cxsveqtjiyimdj7s@meerkat.local> (raw)
In-Reply-To: <c403e526-7455-4f26-fcef-97c99f9af539@rasmusvillemoes.dk>

On Fri, Aug 26, 2022 at 03:17:34PM +0200, Rasmus Villemoes wrote:
> Hi,
> 
> Some mailing lists mangle the real From: header, making it a little hard
> for maintainers to apply patches directly using 'git am'. See e.g.
> https://lists.openembedded.org/g/openembedded-core/message/166515 . One
> way to work around that is by having an in-body From: "header".

This is only tangentially related to the problem at hand, but the list in
question is also mirrored on lore.kernel.org:

https://lore.kernel.org/openembedded-core/20220531151052.3667079-1-sean.anderson@seco.com/

The mirroring is done with a direct push hook from groups.io, which is why we
get messages without all the groups.io mangling.

> However, merely setting sendemail.from or format.from is not enough to
> get such a header, if the value happens to be identical to the patch
> author (which it would usually be). So, could we get some config knob
> and/or command line switch to force an in-body from header? Then one
> could set that on a per-project basis, for projects with such mailing lists.

I agree that it's a nice feature to have, though I would put this into the
sendemail config instead of using an env variable, something like:

    [sendemail]
      in-body-headers = From

-K