From: Junio C Hamano <gitster@pobox.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: Git Mailing List <git@vger.kernel.org>,
Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: forcing an in-body From header
Date: Fri, 26 Aug 2022 10:11:13 -0700 [thread overview]
Message-ID: <xmqqtu5zx74e.fsf@gitster.g> (raw)
In-Reply-To: <c403e526-7455-4f26-fcef-97c99f9af539@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Fri, 26 Aug 2022 15:17:34 +0200")
Rasmus Villemoes <rv@rasmusvillemoes.dk> writes:
> I looked into the code, and while this is obviously just a hacky patch
> to see that I found the right spot, it doesn't seem to be too hard to
> implement properly.
I agree with you on all points in the above sentence ;-) I do not
think anybody minds if a command line option to "git format-patch"
added in builtin/log.c::cmd_format_patch() and a new configuration
variable taught to builtin/log.c::git_format_config() that gives
the default value for the new "force_in_body_from" member that will
be added to "struct rev_info" and relayed to "pretty_print_context"
when log-tree.c::fmt_output_commit() calls format_commit_messages().
Or something like that.
prev parent reply other threads:[~2022-08-26 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 13:17 forcing an in-body From header Rasmus Villemoes
2022-08-26 16:48 ` Konstantin Ryabitsev
2022-08-26 17:20 ` Junio C Hamano
2022-08-29 11:56 ` Rasmus Villemoes
2022-08-26 17:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtu5zx74e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.