From: Markus Schneider-Pargmann <msp@baylibre.com>
To: kernel test robot <lkp@intel.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Fabien Parent <parent.f@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kbuild-all@lists.01.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
Date: Mon, 29 Aug 2022 11:33:50 +0200 [thread overview]
Message-ID: <20220829093350.hu734rofg7luwvkp@blmsp> (raw)
In-Reply-To: <202208230714.8DNW6JjZ-lkp@intel.com>
Hi,
On Tue, Aug 23, 2022 at 07:44:26AM +0800, kernel test robot wrote:
> Hi Markus,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on clk/clk-next]
> [also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030
> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: loongarch-randconfig-c004-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230714.8DNW6JjZ-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/clk/mediatek/clk-mtk.c:64:1-6: WARNING: invalid free of devm_ allocated data
>
> vim +64 drivers/clk/mediatek/clk-mtk.c
>
> 9741b1a68035b54 James Liao 2015-04-23 61
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 62 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data)
> 300796cad22153f Chun-Jie Chen 2021-09-14 63 {
> 300796cad22153f Chun-Jie Chen 2021-09-14 @64 kfree(clk_data);
> 300796cad22153f Chun-Jie Chen 2021-09-14 65 }
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 66 EXPORT_SYMBOL_GPL(mtk_free_clk_data);
I don't see how this should be called with clk_data being initialized by
devm_*. Maybe I am bit code blind.
Do you have an actual call stack how this is supposed to happen? Also I
wasn't able to get the same warning with coccinelle (different
compiler).
Best,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Schneider-Pargmann <msp@baylibre.com>
To: kernel test robot <lkp@intel.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Fabien Parent <parent.f@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kbuild-all@lists.01.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
Date: Mon, 29 Aug 2022 11:33:50 +0200 [thread overview]
Message-ID: <20220829093350.hu734rofg7luwvkp@blmsp> (raw)
In-Reply-To: <202208230714.8DNW6JjZ-lkp@intel.com>
Hi,
On Tue, Aug 23, 2022 at 07:44:26AM +0800, kernel test robot wrote:
> Hi Markus,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on clk/clk-next]
> [also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030
> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: loongarch-randconfig-c004-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230714.8DNW6JjZ-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/clk/mediatek/clk-mtk.c:64:1-6: WARNING: invalid free of devm_ allocated data
>
> vim +64 drivers/clk/mediatek/clk-mtk.c
>
> 9741b1a68035b54 James Liao 2015-04-23 61
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 62 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data)
> 300796cad22153f Chun-Jie Chen 2021-09-14 63 {
> 300796cad22153f Chun-Jie Chen 2021-09-14 @64 kfree(clk_data);
> 300796cad22153f Chun-Jie Chen 2021-09-14 65 }
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 66 EXPORT_SYMBOL_GPL(mtk_free_clk_data);
I don't see how this should be called with clk_data being initialized by
devm_*. Maybe I am bit code blind.
Do you have an actual call stack how this is supposed to happen? Also I
wasn't able to get the same warning with coccinelle (different
compiler).
Best,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Markus Schneider-Pargmann <msp@baylibre.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data
Date: Mon, 29 Aug 2022 11:33:50 +0200 [thread overview]
Message-ID: <20220829093350.hu734rofg7luwvkp@blmsp> (raw)
In-Reply-To: <202208230714.8DNW6JjZ-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]
Hi,
On Tue, Aug 23, 2022 at 07:44:26AM +0800, kernel test robot wrote:
> Hi Markus,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on clk/clk-next]
> [also build test WARNING on robh/for-next linus/master v6.0-rc2 next-20220822]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/clk-mediatek-Add-mt8365-support/20220822-233030
> base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
> config: loongarch-randconfig-c004-20220821 (https://download.01.org/0day-ci/archive/20220823/202208230714.8DNW6JjZ-lkp(a)intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/clk/mediatek/clk-mtk.c:64:1-6: WARNING: invalid free of devm_ allocated data
>
> vim +64 drivers/clk/mediatek/clk-mtk.c
>
> 9741b1a68035b54 James Liao 2015-04-23 61
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 62 void mtk_free_clk_data(struct clk_hw_onecell_data *clk_data)
> 300796cad22153f Chun-Jie Chen 2021-09-14 63 {
> 300796cad22153f Chun-Jie Chen 2021-09-14 @64 kfree(clk_data);
> 300796cad22153f Chun-Jie Chen 2021-09-14 65 }
> 609cc5e1a82394e Chen-Yu Tsai 2022-05-19 66 EXPORT_SYMBOL_GPL(mtk_free_clk_data);
I don't see how this should be called with clk_data being initialized by
devm_*. Maybe I am bit code blind.
Do you have an actual call stack how this is supposed to happen? Also I
wasn't able to get the same warning with coccinelle (different
compiler).
Best,
Markus
next prev parent reply other threads:[~2022-08-29 9:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 15:26 [PATCH v4 0/4] clk: mediatek: Add mt8365 support Markus Schneider-Pargmann
2022-08-22 15:26 ` Markus Schneider-Pargmann
2022-08-22 15:26 ` [PATCH v4 1/4] dt-bindings: clock: mediatek: add bindings for MT8365 SoC Markus Schneider-Pargmann
2022-08-22 15:26 ` Markus Schneider-Pargmann
2022-08-22 17:29 ` Krzysztof Kozlowski
2022-08-22 17:29 ` Krzysztof Kozlowski
2022-08-22 17:31 ` Krzysztof Kozlowski
2022-08-22 17:31 ` Krzysztof Kozlowski
2022-09-30 22:11 ` Stephen Boyd
2022-09-30 22:11 ` Stephen Boyd
2022-08-22 15:26 ` [PATCH v4 2/4] clk: mediatek: Provide mtk_devm_alloc_clk_data Markus Schneider-Pargmann
2022-08-22 15:26 ` Markus Schneider-Pargmann
2022-08-22 23:44 ` kernel test robot
2022-08-22 23:44 ` kernel test robot
2022-08-29 9:33 ` Markus Schneider-Pargmann [this message]
2022-08-29 9:33 ` Markus Schneider-Pargmann
2022-08-29 9:33 ` Markus Schneider-Pargmann
2022-09-30 22:11 ` Stephen Boyd
2022-09-30 22:11 ` Stephen Boyd
2022-08-22 15:26 ` [PATCH v4 3/4] clk: mediatek: Export required common code symbols Markus Schneider-Pargmann
2022-08-22 15:26 ` Markus Schneider-Pargmann
2022-09-30 22:11 ` Stephen Boyd
2022-09-30 22:11 ` Stephen Boyd
2022-08-22 15:26 ` [PATCH v4 4/4] clk: mediatek: add driver for MT8365 SoC Markus Schneider-Pargmann
2022-08-22 15:26 ` Markus Schneider-Pargmann
2022-08-24 2:57 ` kernel test robot
2022-08-24 2:57 ` kernel test robot
2022-08-29 8:24 ` Markus Schneider-Pargmann
2022-08-29 8:24 ` Markus Schneider-Pargmann
2022-08-29 8:24 ` Markus Schneider-Pargmann
2022-09-30 22:12 ` Stephen Boyd
2022-09-30 22:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829093350.hu734rofg7luwvkp@blmsp \
--to=msp@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=parent.f@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.