From: Yue Hu <zbestahu@gmail.com> To: Gao Xiang <hsiangkao@linux.alibaba.com> Cc: linux-erofs@lists.ozlabs.org, Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] erofs: fix pcluster use-after-free on UP platforms Date: Fri, 2 Sep 2022 13:34:58 +0800 [thread overview] Message-ID: <20220902133458.000008b0.zbestahu@gmail.com> (raw) In-Reply-To: <20220902045710.109530-1-hsiangkao@linux.alibaba.com> On Fri, 2 Sep 2022 12:57:10 +0800 Gao Xiang <hsiangkao@linux.alibaba.com> wrote: > During stress testing with CONFIG_SMP disabled, KASAN reports as below: > > ================================================================== > BUG: KASAN: use-after-free in __mutex_lock+0xe5/0xc30 > Read of size 8 at addr ffff8881094223f8 by task stress/7789 > [ 3482.258885] > CPU: 0 PID: 7789 Comm: stress Not tainted 6.0.0-rc1-00002-g0d53d2e882f9 #3 > Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 > Call Trace: > <TASK> > .. > __mutex_lock+0xe5/0xc30 > .. > z_erofs_do_read_page+0x8ce/0x1560 > .. > z_erofs_readahead+0x31c/0x580 > .. > Freed by task 7787 > kasan_save_stack+0x1e/0x40 > kasan_set_track+0x20/0x30 > kasan_set_free_info+0x20/0x40 > __kasan_slab_free+0x10c/0x190 > kmem_cache_free+0xed/0x380 > rcu_core+0x3d5/0xc90 > __do_softirq+0x12d/0x389 > [ 3482.295630] > Last potentially related work creation: > kasan_save_stack+0x1e/0x40 > __kasan_record_aux_stack+0x97/0xb0 > call_rcu+0x3d/0x3f0 > erofs_shrink_workstation+0x11f/0x210 > erofs_shrink_scan+0xdc/0x170 > shrink_slab.constprop.0+0x296/0x530 > drop_slab+0x1c/0x70 > drop_caches_sysctl_handler+0x70/0x80 > proc_sys_call_handler+0x20a/0x2f0 > vfs_write+0x555/0x6c0 > ksys_write+0xbe/0x160 > do_syscall_64+0x3b/0x90 > > The root cause is that erofs_workgroup_unfreeze() doesn't reset > to orig_val thus it causes a race that the pcluster reuses unexpectedly > before freeing. > > Since UP platforms are quite rare now, such path becomes unnecessary. > Let's drop such specific-designed path directly instead. > > Fixes: 73f5c66df3e2 ("staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'") > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > --- > fs/erofs/internal.h | 29 ----------------------------- > 1 file changed, 29 deletions(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index cfee49d33b95..a01cc82795a2 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -195,7 +195,6 @@ struct erofs_workgroup { > atomic_t refcount; > }; > > -#if defined(CONFIG_SMP) > static inline bool erofs_workgroup_try_to_freeze(struct erofs_workgroup *grp, > int val) > { > @@ -224,34 +223,6 @@ static inline int erofs_wait_on_workgroup_freezed(struct erofs_workgroup *grp) > return atomic_cond_read_relaxed(&grp->refcount, > VAL != EROFS_LOCKED_MAGIC); > } > -#else > -static inline bool erofs_workgroup_try_to_freeze(struct erofs_workgroup *grp, > - int val) > -{ > - preempt_disable(); > - /* no need to spin on UP platforms, let's just disable preemption. */ > - if (val != atomic_read(&grp->refcount)) { > - preempt_enable(); > - return false; > - } > - return true; > -} > - > -static inline void erofs_workgroup_unfreeze(struct erofs_workgroup *grp, > - int orig_val) > -{ > - preempt_enable(); > -} > - > -static inline int erofs_wait_on_workgroup_freezed(struct erofs_workgroup *grp) > -{ > - int v = atomic_read(&grp->refcount); > - > - /* workgroup is never freezed on uniprocessor systems */ > - DBG_BUGON(v == EROFS_LOCKED_MAGIC); > - return v; > -} > -#endif /* !CONFIG_SMP */ > #endif /* !CONFIG_EROFS_FS_ZIP */ > Reviewed-by: Yue Hu <huyue2@coolpad.com> > /* we strictly follow PAGE_SIZE and no buffer head yet */
WARNING: multiple messages have this Message-ID (diff)
From: Yue Hu <zbestahu@gmail.com> To: Gao Xiang <hsiangkao@linux.alibaba.com> Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] erofs: fix pcluster use-after-free on UP platforms Date: Fri, 2 Sep 2022 13:34:58 +0800 [thread overview] Message-ID: <20220902133458.000008b0.zbestahu@gmail.com> (raw) In-Reply-To: <20220902045710.109530-1-hsiangkao@linux.alibaba.com> On Fri, 2 Sep 2022 12:57:10 +0800 Gao Xiang <hsiangkao@linux.alibaba.com> wrote: > During stress testing with CONFIG_SMP disabled, KASAN reports as below: > > ================================================================== > BUG: KASAN: use-after-free in __mutex_lock+0xe5/0xc30 > Read of size 8 at addr ffff8881094223f8 by task stress/7789 > [ 3482.258885] > CPU: 0 PID: 7789 Comm: stress Not tainted 6.0.0-rc1-00002-g0d53d2e882f9 #3 > Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 > Call Trace: > <TASK> > .. > __mutex_lock+0xe5/0xc30 > .. > z_erofs_do_read_page+0x8ce/0x1560 > .. > z_erofs_readahead+0x31c/0x580 > .. > Freed by task 7787 > kasan_save_stack+0x1e/0x40 > kasan_set_track+0x20/0x30 > kasan_set_free_info+0x20/0x40 > __kasan_slab_free+0x10c/0x190 > kmem_cache_free+0xed/0x380 > rcu_core+0x3d5/0xc90 > __do_softirq+0x12d/0x389 > [ 3482.295630] > Last potentially related work creation: > kasan_save_stack+0x1e/0x40 > __kasan_record_aux_stack+0x97/0xb0 > call_rcu+0x3d/0x3f0 > erofs_shrink_workstation+0x11f/0x210 > erofs_shrink_scan+0xdc/0x170 > shrink_slab.constprop.0+0x296/0x530 > drop_slab+0x1c/0x70 > drop_caches_sysctl_handler+0x70/0x80 > proc_sys_call_handler+0x20a/0x2f0 > vfs_write+0x555/0x6c0 > ksys_write+0xbe/0x160 > do_syscall_64+0x3b/0x90 > > The root cause is that erofs_workgroup_unfreeze() doesn't reset > to orig_val thus it causes a race that the pcluster reuses unexpectedly > before freeing. > > Since UP platforms are quite rare now, such path becomes unnecessary. > Let's drop such specific-designed path directly instead. > > Fixes: 73f5c66df3e2 ("staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}'") > Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> > --- > fs/erofs/internal.h | 29 ----------------------------- > 1 file changed, 29 deletions(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index cfee49d33b95..a01cc82795a2 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -195,7 +195,6 @@ struct erofs_workgroup { > atomic_t refcount; > }; > > -#if defined(CONFIG_SMP) > static inline bool erofs_workgroup_try_to_freeze(struct erofs_workgroup *grp, > int val) > { > @@ -224,34 +223,6 @@ static inline int erofs_wait_on_workgroup_freezed(struct erofs_workgroup *grp) > return atomic_cond_read_relaxed(&grp->refcount, > VAL != EROFS_LOCKED_MAGIC); > } > -#else > -static inline bool erofs_workgroup_try_to_freeze(struct erofs_workgroup *grp, > - int val) > -{ > - preempt_disable(); > - /* no need to spin on UP platforms, let's just disable preemption. */ > - if (val != atomic_read(&grp->refcount)) { > - preempt_enable(); > - return false; > - } > - return true; > -} > - > -static inline void erofs_workgroup_unfreeze(struct erofs_workgroup *grp, > - int orig_val) > -{ > - preempt_enable(); > -} > - > -static inline int erofs_wait_on_workgroup_freezed(struct erofs_workgroup *grp) > -{ > - int v = atomic_read(&grp->refcount); > - > - /* workgroup is never freezed on uniprocessor systems */ > - DBG_BUGON(v == EROFS_LOCKED_MAGIC); > - return v; > -} > -#endif /* !CONFIG_SMP */ > #endif /* !CONFIG_EROFS_FS_ZIP */ > Reviewed-by: Yue Hu <huyue2@coolpad.com> > /* we strictly follow PAGE_SIZE and no buffer head yet */
next prev parent reply other threads:[~2022-09-02 5:32 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-02 4:57 [PATCH] erofs: fix pcluster use-after-free on UP platforms Gao Xiang 2022-09-02 4:57 ` Gao Xiang 2022-09-02 5:34 ` Yue Hu [this message] 2022-09-02 5:34 ` Yue Hu 2022-09-05 15:14 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220902133458.000008b0.zbestahu@gmail.com \ --to=zbestahu@gmail.com \ --cc=chao@kernel.org \ --cc=hsiangkao@linux.alibaba.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.