From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lee Jones <lee@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Alessandro Zummo <a.zummo@towertech.it>, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com Subject: [PATCHv4 06/13] mfd: rk808: replace 'struct i2c_client' with 'struct device' Date: Thu, 20 Oct 2022 22:42:44 +0200 [thread overview] Message-ID: <20221020204251.108565-7-sebastian.reichel@collabora.com> (raw) In-Reply-To: <20221020204251.108565-1-sebastian.reichel@collabora.com> Put 'struct device' pointer into the MFD platform_data instead of the 'struct i2c_client' pointer. This simplifies the code and prepares the MFD for SPI support. Acked-for-MFD-by: Lee Jones <lee@kernel.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- drivers/mfd/rk808.c | 6 +++--- include/linux/mfd/rk808.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index 5e0e5f320525..b154ca96d812 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -570,7 +570,7 @@ static int rk808_power_off(struct sys_off_data *data) } ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) - dev_err(&rk808->i2c->dev, "Failed to shutdown device!\n"); + dev_err(rk808->dev, "Failed to shutdown device!\n"); return NOTIFY_DONE; } @@ -593,7 +593,7 @@ static int rk808_restart(struct sys_off_data *data) } ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) - dev_err(&rk808->i2c->dev, "Failed to restart device!\n"); + dev_err(rk808->dev, "Failed to restart device!\n"); return NOTIFY_DONE; } @@ -714,7 +714,7 @@ static int rk808_probe(struct i2c_client *client, return -EINVAL; } - rk808->i2c = client; + rk808->dev = &client->dev; i2c_set_clientdata(client, rk808); rk808->regmap = devm_regmap_init_i2c(client, rk808->regmap_cfg); diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index 9af1f3105f80..a89ddd9ba68e 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h @@ -787,7 +787,7 @@ enum { }; struct rk808 { - struct i2c_client *i2c; + struct device *dev; struct regmap_irq_chip_data *irq_data; struct regmap *regmap; long variant; -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lee Jones <lee@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Alessandro Zummo <a.zummo@towertech.it>, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com Subject: [PATCHv4 06/13] mfd: rk808: replace 'struct i2c_client' with 'struct device' Date: Thu, 20 Oct 2022 22:42:44 +0200 [thread overview] Message-ID: <20221020204251.108565-7-sebastian.reichel@collabora.com> (raw) In-Reply-To: <20221020204251.108565-1-sebastian.reichel@collabora.com> Put 'struct device' pointer into the MFD platform_data instead of the 'struct i2c_client' pointer. This simplifies the code and prepares the MFD for SPI support. Acked-for-MFD-by: Lee Jones <lee@kernel.org> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> --- drivers/mfd/rk808.c | 6 +++--- include/linux/mfd/rk808.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index 5e0e5f320525..b154ca96d812 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -570,7 +570,7 @@ static int rk808_power_off(struct sys_off_data *data) } ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) - dev_err(&rk808->i2c->dev, "Failed to shutdown device!\n"); + dev_err(rk808->dev, "Failed to shutdown device!\n"); return NOTIFY_DONE; } @@ -593,7 +593,7 @@ static int rk808_restart(struct sys_off_data *data) } ret = regmap_update_bits(rk808->regmap, reg, bit, bit); if (ret) - dev_err(&rk808->i2c->dev, "Failed to restart device!\n"); + dev_err(rk808->dev, "Failed to restart device!\n"); return NOTIFY_DONE; } @@ -714,7 +714,7 @@ static int rk808_probe(struct i2c_client *client, return -EINVAL; } - rk808->i2c = client; + rk808->dev = &client->dev; i2c_set_clientdata(client, rk808); rk808->regmap = devm_regmap_init_i2c(client, rk808->regmap_cfg); diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h index 9af1f3105f80..a89ddd9ba68e 100644 --- a/include/linux/mfd/rk808.h +++ b/include/linux/mfd/rk808.h @@ -787,7 +787,7 @@ enum { }; struct rk808 { - struct i2c_client *i2c; + struct device *dev; struct regmap_irq_chip_data *irq_data; struct regmap *regmap; long variant; -- 2.35.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-10-20 20:43 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-20 20:42 [PATCHv4 00/13] Introduce RK806 Support Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 01/13] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 02/13] regulator: rk808: " Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 03/13] rtc: " Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-11-25 23:52 ` Sebastian Reichel 2022-11-25 23:52 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 04/13] mfd: rk808: convert to device managed resources Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 05/13] mfd: rk808: use dev_err_probe Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel [this message] 2022-10-20 20:42 ` [PATCHv4 06/13] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 07/13] mfd: rk808: split into core and i2c Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-31 13:56 ` Lee Jones 2022-10-31 13:56 ` Lee Jones 2022-10-20 20:42 ` [PATCHv4 08/13] dt-bindings: mfd: add rk806 binding Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-21 22:19 ` Rob Herring 2022-10-21 22:19 ` Rob Herring 2022-10-20 20:42 ` [PATCHv4 09/13] mfd: rk8xx: add rk806 support Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-31 14:04 ` Lee Jones 2022-10-31 14:04 ` Lee Jones 2022-10-20 20:42 ` [PATCHv4 10/13] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 11/13] regulator: rk808: Use dev_err_probe Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-11-25 19:33 ` [PATCH v4 " Mark Brown 2022-11-25 19:33 ` Mark Brown 2022-11-25 23:46 ` Sebastian Reichel 2022-11-25 23:46 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 12/13] regulator: expose regulator_find_closest_bigger Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-10-20 20:42 ` [PATCHv4 13/13] regulator: rk808: add rk806 support Sebastian Reichel 2022-10-20 20:42 ` Sebastian Reichel 2022-11-28 19:05 ` (subset) [PATCHv4 00/13] Introduce RK806 Support Mark Brown 2022-11-28 19:05 ` Mark Brown 2022-12-11 19:59 ` Alexandre Belloni 2022-12-11 19:59 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221020204251.108565-7-sebastian.reichel@collabora.com \ --to=sebastian.reichel@collabora.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=kernel@collabora.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.