From: Shawn Guo <shawnguo@kernel.org> To: Alistair Francis <alistair@alistair23.me> Cc: lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, kernel@pengutronix.de, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, alistair23@gmail.com, linux-imx@nxp.com, amitk@kernel.org, s.hauer@pengutronix.de, linux@roeck-us.net, rui.zhang@intel.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org, andreas@kemnade.info, linux-kernel@vger.kernel.org, geert@linux-m68k.org Subject: Re: [PATCH v23 2/2] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a Date: Sat, 29 Oct 2022 21:08:00 +0800 [thread overview] Message-ID: <20221029130800.GZ125525@dragon> (raw) In-Reply-To: <20221029100646.294583-3-alistair@alistair23.me> On Sat, Oct 29, 2022 at 08:06:46PM +1000, Alistair Francis wrote: > Enable the silergy,sy7636a and silergy,sy7636a-regulator on the > reMarkable2. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 63 +++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index a2a91bfdd98e..58581295b9a0 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -22,6 +22,28 @@ memory@80000000 { > reg = <0x80000000 0x40000000>; > }; > > + thermal-zones { > + epd-thermal { > + thermal-sensors = <&epd_pmic>; > + polling-delay-passive = <30000>; > + polling-delay = <30000>; > + > + trips { > + trip0 { > + temperature = <49000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <50000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + > reg_brcm: regulator-brcm { > compatible = "regulator-fixed"; > regulator-name = "brcm_reg"; > @@ -84,6 +106,33 @@ wacom_digitizer: digitizer@9 { > }; > }; > > +&i2c4 { > + clock-frequency = <100000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_i2c4>; > + pinctrl-1 = <&pinctrl_i2c4>; > + status = "okay"; > + > + sy7636a: pmic@62 { > + compatible = "silergy,sy7636a"; > + reg = <0x62>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_epdpmic>; > + #address-cells = <1>; > + #size-cells = <0>; > + #thermal-sensor-cells = <0>; > + epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>; > + status = "okay"; The "okay" status is only needed to flip disabled devices. It can be dropped here. I fixed it up and applied both patches. Shawn > + > + regulators { > + reg_epdpmic: vcom { > + regulator-name = "vcom"; > + regulator-boot-on; > + }; > + }; > + }; > +}; > + > &snvs_pwrkey { > status = "okay"; > }; > @@ -177,6 +226,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > >; > }; > > + pinctrl_epdpmic: epdpmicgrp { > + fsl,pins = < > + MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074 > + MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014 > + >; > + }; > + > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > @@ -184,6 +240,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > >; > }; > > + pinctrl_i2c4: i2c4grp { > + fsl,pins = < > + MX7D_PAD_I2C4_SDA__I2C4_SDA 0x4000007f > + MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > -- > 2.38.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org> To: Alistair Francis <alistair@alistair23.me> Cc: lgirdwood@gmail.com, robh+dt@kernel.org, broonie@kernel.org, kernel@pengutronix.de, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, alistair23@gmail.com, linux-imx@nxp.com, amitk@kernel.org, s.hauer@pengutronix.de, linux@roeck-us.net, rui.zhang@intel.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org, andreas@kemnade.info, linux-kernel@vger.kernel.org, geert@linux-m68k.org Subject: Re: [PATCH v23 2/2] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a Date: Sat, 29 Oct 2022 21:08:00 +0800 [thread overview] Message-ID: <20221029130800.GZ125525@dragon> (raw) In-Reply-To: <20221029100646.294583-3-alistair@alistair23.me> On Sat, Oct 29, 2022 at 08:06:46PM +1000, Alistair Francis wrote: > Enable the silergy,sy7636a and silergy,sy7636a-regulator on the > reMarkable2. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 63 +++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index a2a91bfdd98e..58581295b9a0 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts > @@ -22,6 +22,28 @@ memory@80000000 { > reg = <0x80000000 0x40000000>; > }; > > + thermal-zones { > + epd-thermal { > + thermal-sensors = <&epd_pmic>; > + polling-delay-passive = <30000>; > + polling-delay = <30000>; > + > + trips { > + trip0 { > + temperature = <49000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + trip1 { > + temperature = <50000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + > reg_brcm: regulator-brcm { > compatible = "regulator-fixed"; > regulator-name = "brcm_reg"; > @@ -84,6 +106,33 @@ wacom_digitizer: digitizer@9 { > }; > }; > > +&i2c4 { > + clock-frequency = <100000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_i2c4>; > + pinctrl-1 = <&pinctrl_i2c4>; > + status = "okay"; > + > + sy7636a: pmic@62 { > + compatible = "silergy,sy7636a"; > + reg = <0x62>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_epdpmic>; > + #address-cells = <1>; > + #size-cells = <0>; > + #thermal-sensor-cells = <0>; > + epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>; > + status = "okay"; The "okay" status is only needed to flip disabled devices. It can be dropped here. I fixed it up and applied both patches. Shawn > + > + regulators { > + reg_epdpmic: vcom { > + regulator-name = "vcom"; > + regulator-boot-on; > + }; > + }; > + }; > +}; > + > &snvs_pwrkey { > status = "okay"; > }; > @@ -177,6 +226,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14 > >; > }; > > + pinctrl_epdpmic: epdpmicgrp { > + fsl,pins = < > + MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074 > + MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014 > + >; > + }; > + > pinctrl_i2c1: i2c1grp { > fsl,pins = < > MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > @@ -184,6 +240,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > >; > }; > > + pinctrl_i2c4: i2c4grp { > + fsl,pins = < > + MX7D_PAD_I2C4_SDA__I2C4_SDA 0x4000007f > + MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > + >; > + }; > + > pinctrl_uart1: uart1grp { > fsl,pins = < > MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79 > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-29 13:08 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-29 10:06 [PATCH v23 0/2] Add support for the silergy,sy7636a Alistair Francis 2022-10-29 10:06 ` Alistair Francis 2022-10-29 10:06 ` [PATCH v23 1/2] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis 2022-10-29 10:06 ` Alistair Francis 2022-10-29 10:06 ` [PATCH v23 2/2] ARM: dts: imx7d-remarkable2: " Alistair Francis 2022-10-29 10:06 ` Alistair Francis 2022-10-29 13:08 ` Shawn Guo [this message] 2022-10-29 13:08 ` Shawn Guo 2022-11-11 23:17 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221029130800.GZ125525@dragon \ --to=shawnguo@kernel.org \ --cc=alistair23@gmail.com \ --cc=alistair@alistair23.me \ --cc=amitk@kernel.org \ --cc=andreas@kemnade.info \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.