All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Daniel Machon <daniel.machon@microchip.com>,
	UNGLinuxDriver@microchip.com, Sergey Shtylyov <s.shtylyov@omp.ru>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Jonathan Marek <jonathan@marek.ca>,
	Martin Botka <martin.botka@somainline.org>,
	Taniya Das <tdas@codeaurora.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Stephan Gerhold <stephan@gerhold.net>,
	Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
	krishna Lanka <quic_vamslank@quicinc.com>,
	Iskren Chernev <iskren.chernev@gmail.com>,
	Del Regno <angelogioacchino.delregno@somainline.org>,
	Robert Foss <robert.foss@linaro.org>,
	Jeffrey Hugo <quic_jhugo@quicinc.com>,
	Govind Singh <govinds@codeaurora.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Oleksij Rempel <linux@rempel-privat.de>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports
Date: Mon, 31 Oct 2022 13:57:37 -0500	[thread overview]
Message-ID: <20221031185737.GA3249912-robh@kernel.org> (raw)
In-Reply-To: <20221028140326.43470-2-krzysztof.kozlowski@linaro.org>

On Fri, Oct 28, 2022 at 10:03:25AM -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
> 

Shouldn't this constrained by dsa-port.yaml (or the under review 
ethernet switch schemas that split out the DSA parts)?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Please give it a time for Rob's bot to process this.
> ---
>  Documentation/devicetree/bindings/net/asix,ax88178.yaml       | 4 +++-
>  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml  | 4 +++-
>  .../devicetree/bindings/net/microchip,lan966x-switch.yaml     | 4 ++--
>  .../devicetree/bindings/net/microchip,sparx5-switch.yaml      | 3 ++-
>  .../devicetree/bindings/net/mscc,vsc7514-switch.yaml          | 3 ++-
>  .../bindings/net/renesas,r8a779f0-ether-switch.yaml           | 4 ++--
>  6 files changed, 14 insertions(+), 8 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@somainline.org>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	 Daniel Machon <daniel.machon@microchip.com>,
	UNGLinuxDriver@microchip.com,
	 Sergey Shtylyov <s.shtylyov@omp.ru>,
	Manivannan Sadhasivam <mani@kernel.org>,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Jonathan Marek <jonathan@marek.ca>,
	 Martin Botka <martin.botka@somainline.org>,
	Taniya Das <tdas@codeaurora.org>,
	 Christian Marangi <ansuelsmth@gmail.com>,
	Stephan Gerhold <stephan@gerhold.net>,
	 Shawn Guo <shawn.guo@linaro.org>, Vinod Koul <vkoul@kernel.org>,
	 krishna Lanka <quic_vamslank@quicinc.com>,
	Iskren Chernev <iskren.chernev@gmail.com>,
	 Del Regno <angelogioacchino.delregno@somainline.org>,
	 Robert Foss <robert.foss@linaro.org>,
	Jeffrey Hugo <quic_jhugo@quicinc.com>,
	 Govind Singh <govinds@codeaurora.org>,
	Loic Poulain <loic.poulain@linaro.org>,
	 Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Oleksij Rempel <linux@rempel-privat.de>,
	 Horatiu Vultur <horatiu.vultur@microchip.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	 Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports
Date: Mon, 31 Oct 2022 13:57:37 -0500	[thread overview]
Message-ID: <20221031185737.GA3249912-robh@kernel.org> (raw)
In-Reply-To: <20221028140326.43470-2-krzysztof.kozlowski@linaro.org>

On Fri, Oct 28, 2022 at 10:03:25AM -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
> 

Shouldn't this constrained by dsa-port.yaml (or the under review 
ethernet switch schemas that split out the DSA parts)?

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Please give it a time for Rob's bot to process this.
> ---
>  Documentation/devicetree/bindings/net/asix,ax88178.yaml       | 4 +++-
>  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml  | 4 +++-
>  .../devicetree/bindings/net/microchip,lan966x-switch.yaml     | 4 ++--
>  .../devicetree/bindings/net/microchip,sparx5-switch.yaml      | 3 ++-
>  .../devicetree/bindings/net/mscc,vsc7514-switch.yaml          | 3 ++-
>  .../bindings/net/renesas,r8a779f0-ether-switch.yaml           | 4 ++--
>  6 files changed, 14 insertions(+), 8 deletions(-)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-10-31 18:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 14:03 [PATCH 1/2] dt-bindings: clock: qcom,gcc-ipq8074: use common GCC schema Krzysztof Kozlowski
2022-10-28 14:03 ` Krzysztof Kozlowski
2022-10-28 14:03 ` [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-10-28 14:03   ` Krzysztof Kozlowski
2022-10-30 17:04   ` Oleksij Rempel
2022-10-30 17:04     ` Oleksij Rempel
2022-10-31 18:57   ` Rob Herring [this message]
2022-10-31 18:57     ` Rob Herring
2022-11-02 15:48     ` Krzysztof Kozlowski
2022-11-02 15:48       ` Krzysztof Kozlowski
2022-11-01  0:03   ` Jakub Kicinski
2022-11-02 15:34     ` Krzysztof Kozlowski
2022-10-28 14:03 ` [PATCH 2/2] dt-bindings: clock: qcom: cleanup Krzysztof Kozlowski
2022-10-28 14:03   ` Krzysztof Kozlowski
2022-10-28 14:14   ` Jeffrey Hugo
2022-10-28 14:14     ` Jeffrey Hugo
2022-10-31 19:01   ` Rob Herring
2022-10-31 19:01     ` Rob Herring
2022-10-31 18:51 ` [PATCH 1/2] dt-bindings: clock: qcom,gcc-ipq8074: use common GCC schema Rob Herring
2022-10-31 18:51   ` Rob Herring
2022-11-01 19:48 ` Stephen Boyd
2022-11-02 16:28   ` Krzysztof Kozlowski
2022-11-02 16:28     ` Krzysztof Kozlowski
  -- strict thread matches above, loose matches on Subject: below --
2022-10-28  1:54 [PATCH] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-10-28  1:54 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221031185737.GA3249912-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=agross@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=ansuelsmth@gmail.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=daniel.machon@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=edumazet@google.com \
    --cc=govinds@codeaurora.org \
    --cc=horatiu.vultur@microchip.com \
    --cc=iskren.chernev@gmail.com \
    --cc=jonathan@marek.ca \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=loic.poulain@linaro.org \
    --cc=mani@kernel.org \
    --cc=martin.botka@somainline.org \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_jhugo@quicinc.com \
    --cc=quic_vamslank@quicinc.com \
    --cc=robert.foss@linaro.org \
    --cc=s.shtylyov@omp.ru \
    --cc=sboyd@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=stephan@gerhold.net \
    --cc=tdas@codeaurora.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.